diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2021-01-21 15:41:14 +0100 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2021-01-26 09:02:21 +0100 |
| commit | 0f668aa0857815f388ef1bb880efa4b2e889edaf (patch) | |
| tree | 8a2a7301b5c43429fd95369a24022584ca211433 /test/e2e | |
| parent | 7b186dcb9e79c15a4d5506db8922281cd8034a58 (diff) | |
| download | podman-0f668aa0857815f388ef1bb880efa4b2e889edaf.tar.gz podman-0f668aa0857815f388ef1bb880efa4b2e889edaf.tar.bz2 podman-0f668aa0857815f388ef1bb880efa4b2e889edaf.zip | |
workdir presence checks
A container's workdir can be specified via the CLI via `--workdir` and
via an image config with the CLI having precedence.
Since images have a tendency to specify workdirs without necessarily
shipping the paths with the root FS, make sure that Podman creates the
workdir. When specified via the CLI, do not create the path, but check
for its existence and return a human-friendly error.
NOTE: `crun` is performing a similar check that would yield exit code
127. With this change, however, Podman performs the check and yields
exit code 126. Since this is specific to `crun`, I do not consider it
to be a breaking change of Podman.
Fixes: #9040
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'test/e2e')
| -rw-r--r-- | test/e2e/run_working_dir_test.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/test/e2e/run_working_dir_test.go b/test/e2e/run_working_dir_test.go index 7d8db361c..59538448e 100644 --- a/test/e2e/run_working_dir_test.go +++ b/test/e2e/run_working_dir_test.go @@ -2,7 +2,6 @@ package integration import ( "os" - "strings" . "github.com/containers/podman/v2/test/utils" . "github.com/onsi/ginkgo" @@ -41,12 +40,9 @@ var _ = Describe("Podman run", func() { }) It("podman run a container using non existing --workdir", func() { - if !strings.Contains(podmanTest.OCIRuntime, "crun") { - Skip("Test only works on crun") - } session := podmanTest.Podman([]string{"run", "--workdir", "/home/foobar", ALPINE, "pwd"}) session.WaitWithDefaultTimeout() - Expect(session.ExitCode()).To(Equal(127)) + Expect(session.ExitCode()).To(Equal(126)) }) It("podman run a container on an image with a workdir", func() { |