diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-09-15 16:18:46 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2022-09-15 20:10:34 -0600 |
| commit | cfbc4aaeb50b5fb12ec9363328bb08fc459a1067 (patch) | |
| tree | e396257e102a885561638fe6702d6c0a6e917743 /test/system/015-help.bats | |
| parent | 750726e62c13941a739ef70040a1ec0d745cdb43 (diff) | |
| download | podman-cfbc4aaeb50b5fb12ec9363328bb08fc459a1067.tar.gz podman-cfbc4aaeb50b5fb12ec9363328bb08fc459a1067.tar.bz2 podman-cfbc4aaeb50b5fb12ec9363328bb08fc459a1067.zip | |
Cleanup: fix problems reported by shell lint
Followup to #15616, which is not usable as it is (way, way, way
too much noise) but actually found a few real nits that should
be fixed.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/system/015-help.bats')
| -rw-r--r-- | test/system/015-help.bats | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/system/015-help.bats b/test/system/015-help.bats index dd5a7ed44..927645f29 100644 --- a/test/system/015-help.bats +++ b/test/system/015-help.bats @@ -121,7 +121,7 @@ function check_help() { # Exceptions: these commands don't work rootless if is_rootless; then # "pause is not supported for rootless containers" - if [ "$cmd" = "pause" -o "$cmd" = "unpause" ]; then + if [[ "$cmd" = "pause" ]] || [[ "$cmd" = "unpause" ]]; then continue fi # "network rm" too @@ -162,17 +162,17 @@ function check_help() { # Any command that takes subcommands, prints its help and errors if called # without one. - dprint "podman $@" + dprint "podman $*" run_podman '?' "$@" is "$status" 125 "'podman $*' without any subcommand - exit status" - is "$output" ".*Usage:.*Error: missing command '.*$@ COMMAND'" \ + is "$output" ".*Usage:.*Error: missing command '.*$* COMMAND'" \ "'podman $*' without any subcommand - expected error message" # Assume that 'NoSuchCommand' is not a command - dprint "podman $@ NoSuchCommand" + dprint "podman $* NoSuchCommand" run_podman '?' "$@" NoSuchCommand is "$status" 125 "'podman $* NoSuchCommand' - exit status" - is "$output" "Error: unrecognized command .*$@ NoSuchCommand" \ + is "$output" "Error: unrecognized command .*$* NoSuchCommand" \ "'podman $* NoSuchCommand' - expected error message" # This can happen if the output of --help changes, such as between |