Migrate away from docker.io

CI and system tests currently pull some images from docker.io.
Eliminate that, by:

  - building a custom image containing much of what we need
    for testing; and
  - copying other needed images to quay.io

(Reason: effective 2020-11-01 docker.io will limit the
number of image pulls).

The principal change is to create a new quay.io/libpod/testimage,
using the new test/system/build-testimage script, instead of
relying on quay.io/libpod/alpine_labels. We also switch to
using a hardcoded :YYYYMMDD tag, instead of :latest, in an
attempt to futureproof our CI. This image includes 'httpd'
from busybox-extras, which we use in our networking test
(previously we had to pull and run busybox from docker.io).

The testimage can and should be extended as needed for future
tests, e.g. adding test file content or other useful tools.

For the '--pull' tests which require actually pulling from
the registry, I've created an image with the same name but
tagged :00000000 so it will never be pulled by default.
Since this image is only used minimally, it's just busybox.

Unfortunately there remain two cases we cannot solve in
this tiny alpine-based image:

  1) docker registry
  2) systemd

For those, I've (manually) run:

    podman pull [ docker.io/library/registry:2.7 | registry.fedoraproject.org/fedora:31 ]
    podman tag !$ quay.io/...
    podman push !$

...and amended the calling tests accordingly.

I've tried to make the the smallest reasonable diff, not the
smallest possible one. I hope it's a reasonable tradeoff.

Signed-off-by: Ed Santiago <santiago@redhat.com>

1 files changed, 14 insertions, 9 deletions

diff --git a/test/system/030-run.bats b/test/system/030-run.bats
index 198c8881d..0b92554b8 100644
--- a/test/system/030-run.bats
+++ b/test/system/030-run.bats
@@ -134,24 +134,29 @@ echo $rand        |   0 | $rand
     run_podman run --pull=never $IMAGE true
     is "$output" "" "--pull=never [present]: no output"
 
-    # Now test with busybox, which we don't have present
-    run_podman 125 run --pull=never busybox true
-    is "$output" "Error: unable to find a name and tag match for busybox in repotags: no such image" "--pull=never [busybox/missing]: error"
+    # Now test with a remote image which we don't have present (the 00 tag)
+    NONLOCAL_IMAGE="$PODMAN_TEST_IMAGE_REGISTRY/$PODMAN_TEST_IMAGE_USER/$PODMAN_TEST_IMAGE_NAME:00000000"
 
-    run_podman run --pull=missing busybox true
-    is "$output" "Trying to pull .*" "--pull=missing [busybox/missing]: fetches"
+    run_podman 125 run --pull=never $NONLOCAL_IMAGE true
+    is "$output" "Error: unable to find a name and tag match for $NONLOCAL_IMAGE in repotags: no such image" "--pull=never [with image not present]: error"
 
-    run_podman run --pull=always busybox true
-    is "$output" "Trying to pull .*" "--pull=always [busybox/present]: fetches"
+    run_podman run --pull=missing $NONLOCAL_IMAGE true
+    is "$output" "Trying to pull .*" "--pull=missing [with image NOT PRESENT]: fetches"
+
+    run_podman run --pull=missing $NONLOCAL_IMAGE true
+    is "$output" "" "--pull=missing [with image PRESENT]: does not re-fetch"
+
+    run_podman run --pull=always $NONLOCAL_IMAGE true
+    is "$output" "Trying to pull .*" "--pull=always [with image PRESENT]: re-fetches"
 
     run_podman rm -a
-    run_podman rmi busybox
+    run_podman rmi $NONLOCAL_IMAGE
 }
 
 # 'run --rmi' deletes the image in the end unless it's used by another container
 @test "podman run --rmi" {
     # Name of a nonlocal image. It should be pulled in by the first 'run'
-    NONLOCAL_IMAGE=busybox
+    NONLOCAL_IMAGE="$PODMAN_TEST_IMAGE_REGISTRY/$PODMAN_TEST_IMAGE_USER/$PODMAN_TEST_IMAGE_NAME:00000000"
     run_podman 1 image exists $NONLOCAL_IMAGE
 
     # Run a container, without --rm; this should block subsequent --rmi