Implement review feedback

- document a recommended convention for fail-fast tests

- document the requirement for jq. (And, add a fail-fast
  test for its presence; remove the duplicated checks
  in subtests)

- add further sanity checks to 'help' test. Add missing
  documentation. Remove a no-longer-needed workaround for
  usage-message bug fixed in #2486

- add a documented TEMPLATE

- and, since we're at 1.1, enable 'Remote API' check in
  version test

- better diagnostics in setup/teardown; add vim filetype hint;
  better formatting of actual-vs-expect errors

- new pod-top, logs, build tests

- improve error messages

- add $IMAGE alias for ridiculous $PODMAN_TEST_IMAGE_FQN

- final cleanup, in prep for merge

Signed-off-by: Ed Santiago <santiago@redhat.com>

1 files changed, 4 insertions, 2 deletions

diff --git a/test/system/050-stop.bats b/test/system/050-stop.bats
index d04e22606..093606ece 100644
--- a/test/system/050-stop.bats
+++ b/test/system/050-stop.bats
@@ -4,7 +4,7 @@ load helpers
 
 # Very simple test
 @test "podman stop - basic test" {
-    run_podman run -d $PODMAN_TEST_IMAGE_FQN sleep 60
+    run_podman run -d $IMAGE sleep 60
     cid="$output"
 
     # Run 'stop'. Time how long it takes.
@@ -37,7 +37,7 @@ load helpers
     # different variations of this test.
     for t_opt in '' '--time=5' '--timeout=5'; do
         # Run a simple container that logs output on SIGTERM
-        run_podman run -d $PODMAN_TEST_IMAGE_FQN sh -c \
+        run_podman run -d $IMAGE sh -c \
                    "trap 'echo Received SIGTERM, finishing; exit' SIGTERM; echo READY; while :; do sleep 1; done"
         cid="$output"
         wait_for_ready $cid
@@ -63,3 +63,5 @@ load helpers
         run_podman rm $cid
     done
 }
+
+# vim: filetype=sh