Implement review feedback

- document a recommended convention for fail-fast tests

- document the requirement for jq. (And, add a fail-fast
  test for its presence; remove the duplicated checks
  in subtests)

- add further sanity checks to 'help' test. Add missing
  documentation. Remove a no-longer-needed workaround for
  usage-message bug fixed in #2486

- add a documented TEMPLATE

- and, since we're at 1.1, enable 'Remote API' check in
  version test

- better diagnostics in setup/teardown; add vim filetype hint;
  better formatting of actual-vs-expect errors

- new pod-top, logs, build tests

- improve error messages

- add $IMAGE alias for ridiculous $PODMAN_TEST_IMAGE_FQN

- final cleanup, in prep for merge

Signed-off-by: Ed Santiago <santiago@redhat.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/test/system/110-history.bats b/test/system/110-history.bats
index c00949bd1..84a1e42b4 100644
--- a/test/system/110-history.bats
+++ b/test/system/110-history.bats
@@ -16,21 +16,19 @@ load helpers
 
         eval set -- "$options"
 
-        run_podman history "$@" $PODMAN_TEST_IMAGE_FQN
+        run_podman history "$@" $IMAGE
         is "$output" "$expect" "podman history $options"
     done
 }
 
 @test "podman history - json" {
-    type -path jq >/dev/null || die "FAIL: please 'dnf -y install jq'"
-
     tests="
 id        | [0-9a-f]\\\{64\\\}
 created   | [0-9-]\\\+T[0-9:]\\\+\\\.[0-9]\\\+Z
 size      | -\\\?[0-9]\\\+
 "
 
-    run_podman history --format json $PODMAN_TEST_IMAGE_FQN
+    run_podman history --format json $IMAGE
 
     parse_table "$tests" | while read field expect; do
         # HACK: we can't include '|' in the table
@@ -47,3 +45,5 @@ size      | -\\\?[0-9]\\\+
     done
 
 }
+
+# vim: filetype=sh