system tests: add assert(), and start using it

Problem: the system test 'is()' checker was poorly thought out.
For example, there is no way to check for inequality or for
absence of a substring.

Solution, step 1: introduce new assert(), copied almost verbatim
from buildah, where it has been successful in addressing the
gaps in is().

The logical next step is to search the tests for 'die' and
for 'run', looking for negative assertions which we can
replace with assert(). There were a lot, and in the process
I found a number of ugly bugs in the tests themselves. I've
taken the liberty of fixing these.

Important note: at this time we have both assert() and is().
Replacing all instances of is() would be impossible to review.

Signed-off-by: Ed Santiago <santiago@redhat.com>

1 files changed, 4 insertions, 7 deletions

diff --git a/test/system/255-auto-update.bats b/test/system/255-auto-update.bats
index 5a8bf4218..6cdae2ada 100644
--- a/test/system/255-auto-update.bats
+++ b/test/system/255-auto-update.bats
@@ -178,9 +178,8 @@ function _confirm_update() {
     is "$output" "$oldID" "container rolled back to previous image"
 
     run_podman container inspect --format "{{.ID}}" $cname
-    if [[ $output == $containerID ]]; then
-        die "container has not been restarted during rollback (previous id: $containerID, current id: $output)"
-    fi
+    assert "$output" != "$containerID" \
+           "container has not been restarted during rollback"
 }
 
 @test "podman auto-update - label io.containers.autoupdate=disabled" {
@@ -329,11 +328,9 @@ EOF
     for cname in "${cnames[@]}"; do
         run_podman inspect --format "{{.Image}}" $cname
         if [[ -n "${expect_update[$cname]}" ]]; then
-            if [[ "$output" == "$img_id" ]]; then
-                die "$cname: image ID ($output) did not change"
-            fi
+            assert "$output" != "$img_id" "$cname: image ID did not change"
         else
-            is "$output" "$img_id" "Image should not be changed."
+            assert "$output" = "$img_id" "Image ID should not be changed."
         fi
     done
 }