podman ssh work, using new c/common interface

implement new ssh interface into podman

this completely redesigns the entire functionality of podman image scp,
podman system connection add, and podman --remote. All references to golang.org/x/crypto/ssh
have been moved to common as have native ssh/scp execs and the new usage of the sftp package.

this PR adds a global flag, --ssh to podman which has two valid inputs `golang` and `native` where golang is the default.
Users should not notice any difference in their everyday workflows if they continue using the golang option. UNLESS they have been using an improperly verified ssh key, this will now fail. This is because podman was incorrectly using the
ssh callback method to IGNORE the ssh known hosts file which is very insecure and golang tells you not yo use this in production.

The native paths allows for immense flexibility, with a new containers.conf field `SSH_CONFIG` that specifies a specific ssh config file to be used in all operations. Else the users ~/.ssh/config file will be used.
podman --remote currently only uses the golang path, given its deep interconnection with dialing multiple clients and urls.

My goal after this PR is to go back and abstract the idea of podman --remote from golang's dialed clients, as it should not be so intrinsically connected. Overall, this is a v1 of a long process of offering native ssh, and one that covers some good ground with podman system connection add and podman image scp.

Signed-off-by: Charlie Doern <cdoern@redhat.com>

2 files changed, 76 insertions, 0 deletions

diff --git a/test/system/900-ssh.bats b/test/system/900-ssh.bats
new file mode 100644
index 000000000..0757f5838
--- /dev/null
+++ b/test/system/900-ssh.bats
@@ -0,0 +1,61 @@
+#!/usr/bin/env bats
+#
+# Simplest set of podman tests. If any of these fail, we have serious problems.
+#
+
+load helpers
+
+# Override standard setup! We don't yet trust podman-images or podman-rm
+function setup() {
+    if ! is_remote; then
+        skip "only applicable on podman-remote"
+    fi
+
+    basic_setup
+}
+
+function teardown() {
+    if ! is_remote; then
+        return
+    fi
+
+    # In case test function failed to clean up
+    if [[ -n $_SERVICE_PID ]]; then
+        run kill $_SERVICE_PID
+    fi
+
+    # see test/system/272-system-connection.bats for why this is needed
+    mount \
+        | grep $PODMAN_TMPDIR \
+        | awk '{print $3}' \
+        | xargs -l1 --no-run-if-empty umount
+
+    run_podman system connection rm --all
+
+    basic_teardown
+}
+
+function _run_podman_remote() {
+    PODMAN=${PODMAN%%--url*} run_podman "$@"
+}
+
+@test "podman --ssh test" {
+    skip_if_no_ssh "cannot run these tests without an ssh binary"
+    # Start server
+    _SERVICE_PORT=$(random_free_port 63000-64999)
+
+    ${PODMAN%%-remote*} --root ${PODMAN_TMPDIR}/root \
+                        --runroot ${PODMAN_TMPDIR}/runroot \
+                        system service -t 99 tcp:localhost:$_SERVICE_PORT &
+    _SERVICE_PID=$!
+    wait_for_port localhost $_SERVICE_PORT
+
+    notme=${PODMAN_ROOTLESS_USER}
+
+    uid=$(id -u $notme)
+
+    run_podman 125 --ssh=native system connection add testing ssh://$notme@localhost:22/run/user/$uid/podman/podman.sock
+    is "$output" "Error: exit status 255"
+
+    # need to figure out how to podman remote test with the new ssh
+}
diff --git a/test/system/helpers.bash b/test/system/helpers.bash
index 19bc6547c..b821175bb 100644
--- a/test/system/helpers.bash
+++ b/test/system/helpers.bash
@@ -347,6 +347,10 @@ function wait_for_port() {
 # BEGIN miscellaneous tools
 
 # Shortcuts for common needs:
+function no_ssh() {
+    [ "$(man ssh)" -ne 0 ]
+}
+
 function is_ubuntu() {
     grep -qiw ubuntu /etc/os-release
 }
@@ -470,6 +474,17 @@ function _add_label_if_missing() {
 }
 
 ######################
+#  skip_if_no_ssh #  ...with an optional message
+######################
+function skip_if_no_ssh() {
+    if no_ssh; then
+        local msg=$(_add_label_if_missing "$1" "ssh")
+        skip "${msg:-not applicable with no ssh binary}"
+    fi
+}
+
+
+######################
 #  skip_if_rootless  #  ...with an optional message
 ######################
 function skip_if_rootless() {