diff options
| author | Paul Holzinger <pholzing@redhat.com> | 2021-06-03 16:07:43 +0200 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2021-06-11 13:06:07 -0400 |
| commit | 26eae3bf89bcaf486ee297088102161d9c02311a (patch) | |
| tree | dadf859f6909afd1e5f4f94126243c15b7259cc1 /test/system | |
| parent | c751544facb3fb891f40d4d125940a51c0477494 (diff) | |
| download | podman-26eae3bf89bcaf486ee297088102161d9c02311a.tar.gz podman-26eae3bf89bcaf486ee297088102161d9c02311a.tar.bz2 podman-26eae3bf89bcaf486ee297088102161d9c02311a.zip | |
remote: always send resize before the container starts
There is race condition in the remote client attach logic. Because the
resize api call was handled in an extra goroutine the container was
started before the resize call happend. To fix this we have to call
resize in the same goroutine as attach. When the first resize is done
start a goroutine to listen on SIGWINCH in the background and resize
again if the signal is received.
Fixes #9859
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
<MH: Fixed cherry-pick conflicts>
Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'test/system')
| -rw-r--r-- | test/system/450-interactive.bats | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/system/450-interactive.bats b/test/system/450-interactive.bats index a9bf52ee8..a2db39492 100644 --- a/test/system/450-interactive.bats +++ b/test/system/450-interactive.bats @@ -56,8 +56,7 @@ function teardown() { stty rows $rows cols $cols <$PODMAN_TEST_PTY # ...and make sure stty under podman reads that. - # FIXME: 'sleep 1' is needed for podman-remote; without it, there's - run_podman run -it --name mystty $IMAGE sh -c 'sleep 1;stty size' <$PODMAN_TEST_PTY + run_podman run -it --name mystty $IMAGE stty size <$PODMAN_TEST_PTY is "$output" "$rows $cols" "stty under podman reads the correct dimensions" } |