diff options
| author | Paul Holzinger <pholzing@redhat.com> | 2022-02-21 16:28:04 +0100 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2022-02-23 14:32:05 -0500 |
| commit | e1d5c812d09295ffa0a0a1d30ffc28b1a504e03d (patch) | |
| tree | 47cc0cd23f777286369bf1ec61713b4fbefda518 /test/system | |
| parent | 2b85f62a23e592a115fe8cab0c1b1f4b2dda36da (diff) | |
| download | podman-e1d5c812d09295ffa0a0a1d30ffc28b1a504e03d.tar.gz podman-e1d5c812d09295ffa0a0a1d30ffc28b1a504e03d.tar.bz2 podman-e1d5c812d09295ffa0a0a1d30ffc28b1a504e03d.zip | |
provide better error on invalid flag
Add a extra `See 'podman command --help'` to the error output.
With this patch you now get:
```
$ podman run -h
Error: flag needs an argument: 'h' in -h
See 'podman run --help'
```
Fixes #13082
Fixes #13002
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'test/system')
| -rw-r--r-- | test/system/001-basic.bats | 3 | ||||
| -rw-r--r-- | test/system/300-cli-parsing.bats | 14 |
2 files changed, 16 insertions, 1 deletions
diff --git a/test/system/001-basic.bats b/test/system/001-basic.bats index 9b0a71285..761bb0f76 100644 --- a/test/system/001-basic.bats +++ b/test/system/001-basic.bats @@ -88,7 +88,8 @@ function setup() { # ...but no matter what, --remote is never allowed after subcommand PODMAN="${podman_non_remote} ${podman_args[@]}" run_podman 125 version --remote - is "$output" "Error: unknown flag: --remote" "podman version --remote" + is "$output" "Error: unknown flag: --remote +See 'podman version --help'" "podman version --remote" } @test "podman-remote: defaults" { diff --git a/test/system/300-cli-parsing.bats b/test/system/300-cli-parsing.bats index 92c073102..ec493d3d8 100644 --- a/test/system/300-cli-parsing.bats +++ b/test/system/300-cli-parsing.bats @@ -12,4 +12,18 @@ load helpers run_podman run --rm --label 'true="false"' $IMAGE true } +@test "podman flag error" { + local name="podman" + if is_remote; then + name="podman-remote" + fi + run_podman 125 run -h + is "$output" "Error: flag needs an argument: 'h' in -h +See '$name run --help'" "expected error output" + + run_podman 125 bad --invalid + is "$output" "Error: unknown flag: --invalid +See '$name --help'" "expected error output" +} + # vim: filetype=sh |