summaryrefslogtreecommitdiff
path: root/test/system
diff options
context:
space:
mode:
authorValentin Rothberg <vrothberg@redhat.com>2022-05-24 09:54:51 +0200
committerValentin Rothberg <vrothberg@redhat.com>2022-05-24 13:20:20 +0200
commitf5450b1e8299e8a11251c3c33c78d80c6e51c96d (patch)
treedfd383eb8da72804f83b070642769b5b0f8bb87c /test/system
parent737b100c5e0bf704bae6864621c3cf5eb41df2bf (diff)
downloadpodman-f5450b1e8299e8a11251c3c33c78d80c6e51c96d.tar.gz
podman-f5450b1e8299e8a11251c3c33c78d80c6e51c96d.tar.bz2
podman-f5450b1e8299e8a11251c3c33c78d80c6e51c96d.zip
system tests: fix flake waiting for container to run
I have seen some system tests flake waiting for a container to transition into a specific running state. My theory is that the waiting time was not sufficient on nodes under high load. Hence, increase the waiting time. Also replace the break with a return to spare some cycles to redundantly compare with the already checked state. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Diffstat (limited to 'test/system')
-rw-r--r--test/system/helpers.bash10
1 files changed, 5 insertions, 5 deletions
diff --git a/test/system/helpers.bash b/test/system/helpers.bash
index 6868f2691..fe9e971fb 100644
--- a/test/system/helpers.bash
+++ b/test/system/helpers.bash
@@ -397,25 +397,25 @@ function _ensure_pod_state() {
for i in {0..5}; do
run_podman pod inspect $1 --format "{{.State}}"
if [[ $output == "$2" ]]; then
- break
+ return
fi
sleep 0.5
done
- is "$output" "$2" "unexpected pod state"
+ die "Timed out waiting for pod $1 to enter state $2"
}
# Wait for the container's (1st arg) running state (2nd arg)
function _ensure_container_running() {
- for i in {0..5}; do
+ for i in {0..20}; do
run_podman container inspect $1 --format "{{.State.Running}}"
if [[ $output == "$2" ]]; then
- break
+ return
fi
sleep 0.5
done
- is "$output" "$2" "unexpected pod state"
+ die "Timed out waiting for container $1 to enter state running=$2"
}
###########################