summaryrefslogtreecommitdiff
path: root/test/system
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2021-10-05 11:13:49 +0200
committerPaul Holzinger <pholzing@redhat.com>2021-10-06 17:51:07 +0200
commitfbce7584d786ed99354a4b33a9c127abd673c3bb (patch)
tree2726f6e2df81a368323398330a786b3ae25afa64 /test/system
parent8bcc086b1b9d8aa0ef3bb08d37542adf9de26ac5 (diff)
downloadpodman-fbce7584d786ed99354a4b33a9c127abd673c3bb.tar.gz
podman-fbce7584d786ed99354a4b33a9c127abd673c3bb.tar.bz2
podman-fbce7584d786ed99354a4b33a9c127abd673c3bb.zip
libpod: fix race when closing STDIN
There is a race where `conn.Close()` was called before `conn.CloseWrite()`. In this case `CloseWrite` will fail and an useless error is printed. To fix this we move the the `CloseWrite()` call to the same goroutine to remove the race. This ensures that `CloseWrite()` is called before `Close()` and never afterwards. Also fixed podman-remote run where the STDIN was never was closed. This is causing flakes in CI testing. [NO TESTS NEEDED] Fixes #11856 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'test/system')
-rw-r--r--test/system/030-run.bats6
1 files changed, 6 insertions, 0 deletions
diff --git a/test/system/030-run.bats b/test/system/030-run.bats
index 4080f08b4..44c2ee509 100644
--- a/test/system/030-run.bats
+++ b/test/system/030-run.bats
@@ -725,4 +725,10 @@ EOF
is "$output" "Error: strconv.ParseInt: parsing \"a\": invalid syntax"
}
+@test "podman run closes stdin" {
+ random_1=$(random_string 25)
+ run_podman run -i --rm $IMAGE cat <<<"$random_1"
+ is "$output" "$random_1" "output matches STDIN"
+}
+
# vim: filetype=sh