summaryrefslogtreecommitdiff
path: root/test/utils
diff options
context:
space:
mode:
authorChris Evich <cevich@redhat.com>2019-02-28 09:38:02 -0500
committerChris Evich <cevich@redhat.com>2019-03-01 09:18:45 -0500
commitf67859ffb396be13cb8c4b8d91343b77de4eb288 (patch)
tree44a2ef27d992198f2ce0d9a6e0f0ec6a07c0008f /test/utils
parente30628eeda9898a64c0a5ed541536d8d5a3cf13c (diff)
downloadpodman-f67859ffb396be13cb8c4b8d91343b77de4eb288.tar.gz
podman-f67859ffb396be13cb8c4b8d91343b77de4eb288.tar.bz2
podman-f67859ffb396be13cb8c4b8d91343b77de4eb288.zip
Fix SystemExec completion race
Some callers assume when SystemExec returns, the command has completed. Other callers explicitly wait for completion (as required). However, forgetting to do that is an incredibly easy mistake to make. Fix this by adding an explicit parameter to the function. This requires every caller to deliberately state whether or not a completion-check is required. Also address **many** resource naming / cleanup completion-races. Signed-off-by: Chris Evich <cevich@redhat.com>
Diffstat (limited to 'test/utils')
-rw-r--r--test/utils/utils.go1
1 files changed, 1 insertions, 0 deletions
diff --git a/test/utils/utils.go b/test/utils/utils.go
index 098779321..499466f5a 100644
--- a/test/utils/utils.go
+++ b/test/utils/utils.go
@@ -326,6 +326,7 @@ func SystemExec(command string, args []string) *PodmanSession {
if err != nil {
Fail(fmt.Sprintf("unable to run command: %s %s", command, strings.Join(args, " ")))
}
+ session.Wait(defaultWaitTimeout)
return &PodmanSession{session}
}