diff options
| author | Valentin Rothberg <vrothberg@redhat.com> | 2022-09-13 09:38:42 +0200 |
|---|---|---|
| committer | Valentin Rothberg <vrothberg@redhat.com> | 2022-09-13 10:59:57 +0200 |
| commit | 0ea5080c9156853b7806879226e23ab0405815d6 (patch) | |
| tree | 1a706b88a6aee2740d21b85c0e1c9dc7ecc48f7c /test | |
| parent | 4aeaeafde54eb223468ae3ea8425ab548e90e8e8 (diff) | |
| download | podman-0ea5080c9156853b7806879226e23ab0405815d6.tar.gz podman-0ea5080c9156853b7806879226e23ab0405815d6.tar.bz2 podman-0ea5080c9156853b7806879226e23ab0405815d6.zip | |
generate systemd: warn on --restart without --new
Emit a warning to the user when generating a unit with --new on a
container that was created with a custom --restart policy. As shown
in #15284, a custom --restart policy in that case can lead to issues
on system shutdown where systemd attempts to nuke the unit but Podman
keeps on restarting the container.
Fixes: #15284
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/system/250-systemd.bats | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/test/system/250-systemd.bats b/test/system/250-systemd.bats index 0e1dc356d..ddec3a492 100644 --- a/test/system/250-systemd.bats +++ b/test/system/250-systemd.bats @@ -81,6 +81,13 @@ function service_cleanup() { skip "FIXME: 2022-09-01: requires conmon-2.1.4, ubuntu has 2.1.3" fi + # Warn when a custom restart policy is used without --new (see #15284) + run_podman create --restart=always $IMAGE + cid="$output" + run_podman generate systemd $cid + is "$output" ".*Container $cid has restart policy .*always.* which can lead to issues on shutdown.*" "generate systemd emits warning" + run_podman rm -f $cid + cname=$(random_string) # See #7407 for --pull=always. run_podman create --pull=always --name $cname --label "io.containers.autoupdate=registry" $IMAGE \ |