diff options
| author | Paul Holzinger <paul.holzinger@web.de> | 2021-01-31 15:46:39 +0100 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2021-02-04 13:52:26 -0500 |
| commit | be6afd10d98e01643ab2c6553126bc17dc6e7dfb (patch) | |
| tree | 659f1dfffd550bd1a4df11afe7d506085b33fae4 /test | |
| parent | f4c828f827516684b33ff8f30cf4b266313c1964 (diff) | |
| download | podman-be6afd10d98e01643ab2c6553126bc17dc6e7dfb.tar.gz podman-be6afd10d98e01643ab2c6553126bc17dc6e7dfb.tar.bz2 podman-be6afd10d98e01643ab2c6553126bc17dc6e7dfb.zip | |
Fix --network parsing for podman pod create
The `--network` flag is parsed differently for `podman pod create`.
This causes confusion and problems for users. The extra parsing
logic ignored unsupported network options such as `none`,
`container:...` and `ns:...` and instead interpreted them as cni
network names.
Tests are added to ensure the correct errors are shown.
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
Diffstat (limited to 'test')
| -rw-r--r-- | test/e2e/pod_create_test.go | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/test/e2e/pod_create_test.go b/test/e2e/pod_create_test.go index 9c448a81e..575f9df68 100644 --- a/test/e2e/pod_create_test.go +++ b/test/e2e/pod_create_test.go @@ -476,4 +476,21 @@ entrypoint ["/fromimage"] Expect(status3.ExitCode()).To(Equal(0)) Expect(strings.Contains(status3.OutputToString(), "Degraded")).To(BeTrue()) }) + + It("podman create with unsupported network options", func() { + podCreate := podmanTest.Podman([]string{"pod", "create", "--network", "none"}) + podCreate.WaitWithDefaultTimeout() + Expect(podCreate.ExitCode()).To(Equal(125)) + Expect(podCreate.ErrorToString()).To(ContainSubstring("pods presently do not support network mode none")) + + podCreate = podmanTest.Podman([]string{"pod", "create", "--network", "container:doesnotmatter"}) + podCreate.WaitWithDefaultTimeout() + Expect(podCreate.ExitCode()).To(Equal(125)) + Expect(podCreate.ErrorToString()).To(ContainSubstring("pods presently do not support network mode container")) + + podCreate = podmanTest.Podman([]string{"pod", "create", "--network", "ns:/does/not/matter"}) + podCreate.WaitWithDefaultTimeout() + Expect(podCreate.ExitCode()).To(Equal(125)) + Expect(podCreate.ErrorToString()).To(ContainSubstring("pods presently do not support network mode path")) + }) }) |