summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2021-09-23 15:15:35 +0200
committerMatthew Heon <matthew.heon@pm.me>2021-09-29 16:39:29 -0400
commit6ef2d3bd8f1343dc9d47039b054046e7df91824c (patch)
treed4c9ff9c3be2671c4a02dcf83bad47ebaf5893f1 /test
parent063ba47d7c02b91f454058f1eacb85cabdb72f77 (diff)
downloadpodman-6ef2d3bd8f1343dc9d47039b054046e7df91824c.tar.gz
podman-6ef2d3bd8f1343dc9d47039b054046e7df91824c.tar.bz2
podman-6ef2d3bd8f1343dc9d47039b054046e7df91824c.zip
shell completion: do not show images without tag
The shell completion should only suggest arguments that work. Using a image without tag does not work in many cases. Having both the version with and without tag also forces users to press one key more because tab completion will always stop at the colon. Fixes #11673 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'test')
-rw-r--r--test/system/600-completion.bats4
1 files changed, 1 insertions, 3 deletions
diff --git a/test/system/600-completion.bats b/test/system/600-completion.bats
index fbb0da231..5f4610e9e 100644
--- a/test/system/600-completion.bats
+++ b/test/system/600-completion.bats
@@ -110,12 +110,10 @@ function check_shell_completion() {
is "$output" ".*localhost/$random_image_name:$random_image_tag${nl}" \
"$* $cmd: actual image listed in suggestions"
- # check that we complete the image with and without tag after at least one char is typed
+ # check that we complete the image with tag after at least one char is typed
run_completion "$@" $cmd "${extra_args[@]}" "${random_image_name:0:1}"
is "$output" ".*$random_image_name:$random_image_tag${nl}" \
"$* $cmd: image name:tag included in suggestions"
- is "$output" ".*$random_image_name${nl}" \
- "$* $cmd: image name(w/o tag) included in suggestions"
# check that we complete the image id after at least two chars are typed
run_completion "$@" $cmd "${extra_args[@]}" "${random_image_id:0:2}"