diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2021-02-23 13:02:35 +0100 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2021-02-23 13:02:35 +0100 |
| commit | e5ac28f3b968661e5c2603880a5c4576d590f3dd (patch) | |
| tree | 378d34ca1cb862ea65deff2292085198a39770da /test | |
| parent | 96fc9d983e0fc5bae48c3cec3acce86cdb6e1059 (diff) | |
| download | podman-e5ac28f3b968661e5c2603880a5c4576d590f3dd.tar.gz podman-e5ac28f3b968661e5c2603880a5c4576d590f3dd.tar.bz2 podman-e5ac28f3b968661e5c2603880a5c4576d590f3dd.zip | |
container removal: handle already removed containers
Since commit d54478d8eaec, a container's lock is released before
attempting to stop it via the OCI runtime. This opened the window
for various kinds of race conditions. One of them led to #9479 where
the removal+cleanup sequences of a `run --rm` session overlapped with
`rm -af`. Make both execution paths more robust by handling the case of
an already removed container.
Fixes: #9479
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/system/055-rm.bats | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/test/system/055-rm.bats b/test/system/055-rm.bats index 0107114b5..a5770f20f 100644 --- a/test/system/055-rm.bats +++ b/test/system/055-rm.bats @@ -51,6 +51,13 @@ load helpers run_podman rm $rand $external_cid } +@test "podman rm <-> run --rm race" { + # A container's lock is released before attempting to stop it. This opens + # the window for race conditions that led to #9479. + run_podman run --rm -d $IMAGE sleep infinity + run_podman rm -af +} + # I'm sorry! This test takes 13 seconds. There's not much I can do about it, # please know that I think it's justified: podman 1.5.0 had a strange bug # in with exit status was not preserved on some code paths with 'rm -f' |