diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2020-09-15 13:23:42 +0200 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2020-09-15 13:33:22 +0200 |
| commit | ce6efadd5cfe48bc8af4798a4747b74398cb4a1e (patch) | |
| tree | 042439c6980bede92b1115abbe4da5d28366951d /test | |
| parent | 5c47a331ba768d57ef94b9595415500f4e911964 (diff) | |
| download | podman-ce6efadd5cfe48bc8af4798a4747b74398cb4a1e.tar.gz podman-ce6efadd5cfe48bc8af4798a4747b74398cb4a1e.tar.bz2 podman-ce6efadd5cfe48bc8af4798a4747b74398cb4a1e.zip | |
run/create: record raw image
Record the user-specified "raw" image name in the SpecGenerator, so we
can pass it along to the config when creating a container. We need a
separate field as the image name in the generator may be set to the
ID of the previously pulled image - ultimately the cause of #7404.
Reverting the image name from the ID to the user input would not work
since "alpine" for pulling iterates over the search registries in the
registries.conf but looking up "alpine" normalizes to
"localhost/alpine".
Recording the raw-image name directly in the generator was the best of
the options I considered as no hidden magic from search registries or
normalizations (that may or may not change in the future) can interfere.
The auto-update backend enforces that the raw-image name is a
fully-qualified reference, so we need to worry about that in the front
end.
Fixes: #7407
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/system/250-systemd.bats | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/system/250-systemd.bats b/test/system/250-systemd.bats index bbb5a10fb..9bd3e15a1 100644 --- a/test/system/250-systemd.bats +++ b/test/system/250-systemd.bats @@ -41,7 +41,8 @@ function teardown() { fi cname=$(random_string) - run_podman create --name $cname --label "io.containers.autoupdate=image" --detach $IMAGE top + # See #7407 for --pull=always. + run_podman create --pull=always --name $cname --label "io.containers.autoupdate=image" --detach $IMAGE top run_podman generate systemd --new $cname echo "$output" > "$UNIT_FILE" |