summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorOndra Machacek <omachace@redhat.com>2022-01-20 15:08:29 +0100
committerOndra Machacek <omachace@redhat.com>2022-01-21 10:01:32 +0100
commit9d815707e226b432ebd38682826a96e7a00cb46e (patch)
tree81d4e7148d42eb7cbf532fc6423627be3044d415 /test
parent1d6e154a73505cd0366cdeec7cc8582dd3ac2191 (diff)
downloadpodman-9d815707e226b432ebd38682826a96e7a00cb46e.tar.gz
podman-9d815707e226b432ebd38682826a96e7a00cb46e.tar.bz2
podman-9d815707e226b432ebd38682826a96e7a00cb46e.zip
Fix nil pointer dereference for configmap optional
This PR fixes nil pointer dereference for configmap optional parameter. When optional parameter is not passed, the code tried to acces the parameter which caused nil pointer dereference. Signed-off-by: Ondra Machacek <omachace@redhat.com>
Diffstat (limited to 'test')
-rw-r--r--test/e2e/play_kube_test.go29
1 files changed, 29 insertions, 0 deletions
diff --git a/test/e2e/play_kube_test.go b/test/e2e/play_kube_test.go
index 63c9bf7f3..cbaa8d6a4 100644
--- a/test/e2e/play_kube_test.go
+++ b/test/e2e/play_kube_test.go
@@ -78,6 +78,25 @@ spec:
- 24h
status: {}
`
+
+var podWithoutConfigMapDefined = `
+apiVersion: v1
+kind: Pod
+metadata:
+ name: testpod1
+spec:
+ containers:
+ - name: alpine
+ image: quay.io/libpod/alpine:latest
+ volumeMounts:
+ - name: mycm
+ mountPath: /mycm
+ volumes:
+ - name: mycm
+ configMap:
+ name: mycm
+`
+
var sharedNamespacePodYaml = `
apiVersion: v1
kind: Pod
@@ -1235,6 +1254,16 @@ var _ = Describe("Podman play kube", func() {
}
})
+ It("podman play kube with non-existing configmap", func() {
+ err := writeYaml(podWithoutConfigMapDefined, kubeYaml)
+ Expect(err).To(BeNil())
+
+ kube := podmanTest.Podman([]string{"play", "kube", kubeYaml})
+ kube.WaitWithDefaultTimeout()
+ Expect(kube).Should(Exit(125))
+ Expect(kube.ErrorToString()).To(ContainSubstring("failed to create volume \"mycm\": no such ConfigMap \"mycm\""))
+ })
+
It("podman play kube test HostAliases with --no-hosts", func() {
pod := getPod(withHostAliases("192.168.1.2", []string{
"test1.podman.io",