diff options
author | Ed Santiago <santiago@redhat.com> | 2022-05-10 05:27:13 -0600 |
---|---|---|
committer | Matthew Heon <mheon@redhat.com> | 2022-06-14 13:14:15 -0400 |
commit | ce407828d029f189ebb0649ac724bc4b4066e79d (patch) | |
tree | 2217d0d975eabef31092234a55fd3371031c52b0 /utils | |
parent | 42e70a0c9477ffd4e6f5129f8b50be43de216188 (diff) | |
download | podman-ce407828d029f189ebb0649ac724bc4b4066e79d.tar.gz podman-ce407828d029f189ebb0649ac724bc4b4066e79d.tar.bz2 podman-ce407828d029f189ebb0649ac724bc4b4066e79d.zip |
bloat check: make more robust
The use of 'C^' (parent) in 'git rebase' is counterintuitive,
at least to me: when C is a merge of multiple commits, rebase
picks each of those commits. That probably makes good sense
to a git expert, which I'm not.
Solution: forget using '^', just calculate the baseline sizes
by doing a checkout of the PR's parent.
Also: compute PR parent using git-merge-base instead of
blindly trusting $DEST_BRANCH (which may be volatile as
other PRs are merged).
Also: run git-rebase directly, not via make rule. That
indirection is too confusing here.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'utils')
0 files changed, 0 insertions, 0 deletions