diff options
| author | Matthew Heon <mheon@redhat.com> | 2022-06-08 09:27:19 -0400 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2022-06-09 09:11:18 -0400 |
| commit | c77691f06f619bf15d0f83690a1dbbfe72f92b7a (patch) | |
| tree | 54f1cab2a670c6bca31fa9a2618629e2d4eb7994 /vendor/github.com/ghodss/yaml/yaml.go | |
| parent | 643a692360bf769d12dc8b73acaa3481b0f07992 (diff) | |
| download | podman-c77691f06f619bf15d0f83690a1dbbfe72f92b7a.tar.gz podman-c77691f06f619bf15d0f83690a1dbbfe72f92b7a.tar.bz2 podman-c77691f06f619bf15d0f83690a1dbbfe72f92b7a.zip | |
Do not error on signalling a just-stopped container
Previous PR #12394 tried to address this, but made a mistake:
containers that have just exited do not move to the Exited state
but rather the Stopped state - as such, the code would never have
run (there is no way we start `podman kill`, and the container
transitions to Exited while we are doing it - that requires
holding the container lock, which Kill already does).
Fix the code to check Stopped as well (we omit Exited entirely
but it's a cheap check and our state logic could change in the
future). Also, return an error, instead of exiting cleanly - the
Kill failed, after all. ErrCtrStateInvalid is already handled by
the sig-proxy logic so there won't be issues.
[NO NEW TESTS NEEDED] This fixes a race that I cannot reproduce
myself, and I have no idea how we'd repro in CI.
Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'vendor/github.com/ghodss/yaml/yaml.go')
0 files changed, 0 insertions, 0 deletions