diff options
author | Ed Santiago <santiago@redhat.com> | 2021-03-11 13:12:11 -0700 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2021-03-11 16:21:51 -0700 |
commit | 660a72993c425d9242641a846596b5ca33d6368f (patch) | |
tree | 6a5ccf294bdbbca5c056df8dcffad242f370789b /vendor/github.com/stretchr/testify/require | |
parent | 8d33bfabaa20612718d909494c2ceec26482d279 (diff) | |
download | podman-660a72993c425d9242641a846596b5ca33d6368f.tar.gz podman-660a72993c425d9242641a846596b5ca33d6368f.tar.bz2 podman-660a72993c425d9242641a846596b5ca33d6368f.zip |
sdnotify tests: try real hard to kill socat processes
podman gating tests are hanging in the new Fedora CI setup;
long and tedious investigation suggests that 'socat' processes
are being left unkilled, which then causes BATS to hang when
it (presumably) runs a final 'wait' in its end cleanup.
The two principal changes are to exec socat in a subshell
with fd3 closed, and to pkill its child processes before
killing the process itself. I don't know if both are needed.
The pkill definitely is; the exec may just be superstition.
Since I've wasted more than a day of PTO time on this, I'm
okay with a little superstition. What I do know is that with
these two changes, my reproducer fails to reproduce in over
one hour of trying (normally it fails within 5 minutes).
AND, update: only rawhide (f35) leaves stray socat processes
behind. f33 and ubuntu do not, so 'pkill -P' fails.
I really have no idea what's going on.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'vendor/github.com/stretchr/testify/require')
0 files changed, 0 insertions, 0 deletions