summaryrefslogtreecommitdiff
path: root/vendor
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2022-06-15 13:10:32 -0600
committerEd Santiago <santiago@redhat.com>2022-06-22 11:26:15 -0600
commitef563c5a1e1a638a99dc615a34324d068993c106 (patch)
treeda8c5258df3edc92443dabd44f4b88335177fddf /vendor
parentca26d44d3b8e1208dafd0e71caadc6b67ebb52b2 (diff)
downloadpodman-ef563c5a1e1a638a99dc615a34324d068993c106.tar.gz
podman-ef563c5a1e1a638a99dc615a34324d068993c106.tar.bz2
podman-ef563c5a1e1a638a99dc615a34324d068993c106.zip
logformatter: link to logs using Cirrus API
One day we may use AWS for part of CI. Do you want to maintain two separate code paths in this script for linking to artifacts in multiple cloud providers? Can you say no? I knew you could. Cirrus already knows the location of the artifacts and provides a transparent mechanism for accessing them. Use it. This PR exposed a nasty bug in our environment-variable handling: envariables passed through to the containerized environment were being double-space-escaped, so "FOO=a b" ended up as "FOO=a\ b" (with a backslash), with one consequence being invalid URLs. The solution is simple: run 'podman -e FOO', not '-e FOO=value'. Finally, reinstate the environment-variable dump (in comments). I had removed this in a moment of panic over leaking secrets, but no, that doesn't happen. Exclude scary-sounding vars anyway. Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'vendor')
0 files changed, 0 insertions, 0 deletions