1 files changed, 44 insertions, 43 deletions

diff --git a/cmd/podman/volume_rm.go b/cmd/podman/volume_rm.go
index 3fb623624..03b6ccae1 100644
--- a/cmd/podman/volume_rm.go
+++ b/cmd/podman/volume_rm.go
@@ -3,69 +3,70 @@ package main
 import (
 	"fmt"
 
-	"github.com/containers/libpod/cmd/podman/libpodruntime"
+	"github.com/containers/libpod/cmd/podman/cliconfig"
+	"github.com/containers/libpod/pkg/adapter"
 	"github.com/pkg/errors"
-	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-var volumeRmDescription = `
+var (
+	volumeRmCommand     cliconfig.VolumeRmValues
+	volumeRmDescription = `
 podman volume rm
 
 Remove one or more existing volumes. Will only remove volumes that are
 not being used by any containers. To remove the volumes anyways, use the
 --force flag.
 `
+	_volumeRmCommand = &cobra.Command{
+		Use:     "rm",
+		Aliases: []string{"remove"},
+		Short:   "Remove one or more volumes",
+		Long:    volumeRmDescription,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			volumeRmCommand.InputArgs = args
+			volumeRmCommand.GlobalFlags = MainGlobalOpts
+			return volumeRmCmd(&volumeRmCommand)
+		},
+		Example: `podman volume rm myvol1 myvol2
+  podman volume rm --all
+  podman volume rm --force myvol`,
+	}
+)
 
-var volumeRmFlags = []cli.Flag{
-	cli.BoolFlag{
-		Name:  "all, a",
-		Usage: "Remove all volumes",
-	},
-	cli.BoolFlag{
-		Name:  "force, f",
-		Usage: "Remove a volume by force, even if it is being used by a container",
-	},
-}
-
-var volumeRmCommand = cli.Command{
-	Name:                   "rm",
-	Aliases:                []string{"remove"},
-	Usage:                  "Remove one or more volumes",
-	Description:            volumeRmDescription,
-	Flags:                  volumeRmFlags,
-	Action:                 volumeRmCmd,
-	ArgsUsage:              "[VOLUME-NAME ...]",
-	SkipArgReorder:         true,
-	UseShortOptionHandling: true,
+func init() {
+	volumeRmCommand.Command = _volumeRmCommand
+	volumeRmCommand.SetUsageTemplate(UsageTemplate())
+	flags := volumeRmCommand.Flags()
+	flags.BoolVarP(&volumeRmCommand.All, "all", "a", false, "Remove all volumes")
+	flags.BoolVarP(&volumeRmCommand.Force, "force", "f", false, "Remove a volume by force, even if it is being used by a container")
 }
 
-func volumeRmCmd(c *cli.Context) error {
+func volumeRmCmd(c *cliconfig.VolumeRmValues) error {
 	var err error
 
-	if err = validateFlags(c, volumeRmFlags); err != nil {
-		return err
+	if (len(c.InputArgs) > 0 && c.All) || (len(c.InputArgs) < 1 && !c.All) {
+		return errors.New("choose either one or more volumes or all")
 	}
 
-	runtime, err := libpodruntime.GetRuntime(c)
+	runtime, err := adapter.GetRuntime(&c.PodmanCommand)
 	if err != nil {
 		return errors.Wrapf(err, "error creating libpod runtime")
 	}
 	defer runtime.Shutdown(false)
-
-	ctx := getContext()
-
-	vols, lastError := getVolumesFromContext(c, runtime)
-	for _, vol := range vols {
-		err = runtime.RemoveVolume(ctx, vol, c.Bool("force"), false)
-		if err != nil {
-			if lastError != nil {
-				logrus.Errorf("%q", lastError)
-			}
-			lastError = errors.Wrapf(err, "failed to remove volume %q", vol.Name())
-		} else {
-			fmt.Println(vol.Name())
+	deletedVolumeNames, err := runtime.RemoveVolumes(getContext(), c)
+	if err != nil {
+		if len(deletedVolumeNames) > 0 {
+			printDeleteVolumes(deletedVolumeNames)
+			return err
 		}
 	}
-	return lastError
+	printDeleteVolumes(deletedVolumeNames)
+	return err
+}
+
+func printDeleteVolumes(volumes []string) {
+	for _, v := range volumes {
+		fmt.Println(v)
+	}
 }