diff options
Diffstat (limited to 'libpod/options.go')
-rw-r--r-- | libpod/options.go | 52 |
1 files changed, 52 insertions, 0 deletions
diff --git a/libpod/options.go b/libpod/options.go index 1bf3ff9e6..3ca80e96c 100644 --- a/libpod/options.go +++ b/libpod/options.go @@ -997,6 +997,9 @@ func WithDNSSearch(searchDomains []string) CtrCreateOption { if ctr.valid { return ErrCtrFinalized } + if ctr.config.UseImageResolvConf { + return errors.Wrapf(ErrInvalidArg, "cannot add DNS search domains if container will not create /etc/resolv.conf") + } ctr.config.DNSSearch = searchDomains return nil } @@ -1008,6 +1011,9 @@ func WithDNS(dnsServers []string) CtrCreateOption { if ctr.valid { return ErrCtrFinalized } + if ctr.config.UseImageResolvConf { + return errors.Wrapf(ErrInvalidArg, "cannot add DNS servers if container will not create /etc/resolv.conf") + } var dns []net.IP for _, i := range dnsServers { result := net.ParseIP(i) @@ -1027,6 +1033,9 @@ func WithDNSOption(dnsOptions []string) CtrCreateOption { if ctr.valid { return ErrCtrFinalized } + if ctr.config.UseImageResolvConf { + return errors.Wrapf(ErrInvalidArg, "cannot add DNS options if container will not create /etc/resolv.conf") + } ctr.config.DNSOption = dnsOptions return nil } @@ -1038,6 +1047,11 @@ func WithHosts(hosts []string) CtrCreateOption { if ctr.valid { return ErrCtrFinalized } + + if ctr.config.UseImageHosts { + return errors.Wrapf(ErrInvalidArg, "cannot add hosts if container will not create /etc/hosts") + } + ctr.config.HostAdd = hosts return nil } @@ -1184,6 +1198,44 @@ func WithCtrNamespace(ns string) CtrCreateOption { } } +// WithUseImageResolvConf tells the container not to bind-mount resolv.conf in. +// This conflicts with other DNS-related options. +func WithUseImageResolvConf() CtrCreateOption { + return func(ctr *Container) error { + if ctr.valid { + return ErrCtrFinalized + } + + if len(ctr.config.DNSServer) != 0 || + len(ctr.config.DNSSearch) != 0 || + len(ctr.config.DNSOption) != 0 { + return errors.Wrapf(ErrInvalidArg, "not creating resolv.conf conflicts with DNS options") + } + + ctr.config.UseImageResolvConf = true + + return nil + } +} + +// WithUseImageHosts tells the container not to bind-mount /etc/hosts in. +// This conflicts with WithHosts(). +func WithUseImageHosts() CtrCreateOption { + return func(ctr *Container) error { + if ctr.valid { + return ErrCtrFinalized + } + + if len(ctr.config.HostAdd) != 0 { + return errors.Wrapf(ErrInvalidArg, "not creating /etc/hosts conflicts with adding to the hosts file") + } + + ctr.config.UseImageHosts = true + + return nil + } +} + // withIsInfra sets the container to be an infra container. This means the container will be sometimes hidden // and expected to be the first container in the pod. func withIsInfra() CtrCreateOption { |