summaryrefslogtreecommitdiff
path: root/pkg/bindings
diff options
context:
space:
mode:
Diffstat (limited to 'pkg/bindings')
-rw-r--r--pkg/bindings/connection.go2
-rw-r--r--pkg/bindings/test/images_test.go6
2 files changed, 4 insertions, 4 deletions
diff --git a/pkg/bindings/connection.go b/pkg/bindings/connection.go
index 2e5fc9cb8..116af9709 100644
--- a/pkg/bindings/connection.go
+++ b/pkg/bindings/connection.go
@@ -116,7 +116,7 @@ func (c *Connection) DoRequest(httpBody io.Reader, httpMethod, endpoint string,
safePathValues := make([]interface{}, len(pathValues))
// Make sure path values are http url safe
for i, pv := range pathValues {
- safePathValues[i] = url.QueryEscape(pv)
+ safePathValues[i] = url.PathEscape(pv)
}
// Lets eventually use URL for this which might lead to safer
// usage
diff --git a/pkg/bindings/test/images_test.go b/pkg/bindings/test/images_test.go
index 2906d55cd..227f28d16 100644
--- a/pkg/bindings/test/images_test.go
+++ b/pkg/bindings/test/images_test.go
@@ -67,10 +67,10 @@ var _ = Describe("Podman images", func() {
// Inspect with partial ID
_, err = images.GetImage(connText, data.ID[0:12], nil)
Expect(err).To(BeNil())
- // Inspect by ID
+
//Inspect by long name should work, it doesnt (yet) i think it needs to be html escaped
- //_, err = images.GetImage(connText, alpine, nil)
- //Expect(err).To(BeNil())
+ _, err = images.GetImage(connText, alpine, nil)
+ Expect(err).To(BeNil())
})
It("remove image", func() {
// Remove invalid image should be a 404