3 files changed, 28 insertions, 9 deletions
diff --git a/pkg/adapter/containers.go b/pkg/adapter/containers.go
index b0c75cf49..7514f30d2 100644
--- a/pkg/adapter/containers.go
+++ b/pkg/adapter/containers.go
@@ -9,6 +9,7 @@ import (
 	"github.com/containers/libpod/libpod"
 	"github.com/containers/libpod/pkg/adapter/shortcuts"
 	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
 )
 
 // GetLatestContainer gets the latest Container and wraps it in an adapter Container
@@ -45,9 +46,10 @@ func (r *LocalRuntime) LookupContainer(idOrName string) (*Container, error) {
 // StopContainers stops container(s) based on CLI inputs.
 // Returns list of successful id(s), map of failed id(s) + error, or error not from container
 func (r *LocalRuntime) StopContainers(ctx context.Context, cli *cliconfig.StopValues) ([]string, map[string]error, error) {
-	timeout := uint(0)
-	if cli.Flags().Changed("timeout") {
-		timeout = uint(cli.Timeout)
+	var timeout *uint
+	if cli.Flags().Changed("timeout") || cli.Flags().Changed("time") {
+		t := uint(cli.Timeout)
+		timeout = &t
 	}
 
 	var (
@@ -61,11 +63,18 @@ func (r *LocalRuntime) StopContainers(ctx context.Context, cli *cliconfig.StopVa
 	}
 
 	for _, c := range ctrs {
-		err := c.StopWithTimeout(timeout)
-		if err != nil && errors.Cause(err) != libpod.ErrCtrStopped {
-			failures[c.ID()] = err
-		} else {
+		if timeout == nil {
+			t := c.StopTimeout()
+			timeout = &t
+			logrus.Debugf("Set timeout to container %s default (%d)", c.ID(), *timeout)
+		}
+		if err := c.StopWithTimeout(*timeout); err == nil {
 			ok = append(ok, c.ID())
+		} else if errors.Cause(err) == libpod.ErrCtrStopped {
+			ok = append(ok, c.ID())
+			logrus.Debugf("Container %s is already stopped", c.ID())
+		} else {
+			failures[c.ID()] = err
 		}
 	}
 	return ok, failures, nil
diff --git a/pkg/logs/logs.go b/pkg/logs/logs.go
index bbd5509b1..7fb5c7ea8 100644
--- a/pkg/logs/logs.go
+++ b/pkg/logs/logs.go
@@ -35,7 +35,10 @@ import (
 
 const (
 	// timeFormat is the time format used in the log.
-	timeFormat = time.RFC3339Nano
+	// It is a modified version of RFC3339Nano that guarantees trailing
+	// zeroes are not trimmed, taken from
+	// https://github.com/golang/go/issues/19635
+	timeFormat = "2006-01-02T15:04:05.000000000Z07:00"
 )
 
 // LogStreamType is the type of the stream in CRI container log.
diff --git a/pkg/rootless/rootless_linux.go b/pkg/rootless/rootless_linux.go
index 98692707f..55fba900e 100644
--- a/pkg/rootless/rootless_linux.go
+++ b/pkg/rootless/rootless_linux.go
@@ -102,7 +102,7 @@ func tryMappingTool(tool string, pid int, hostID int, mappings []idtools.IDMap)
 
 // JoinNS re-exec podman in a new userNS and join the user namespace of the specified
 // PID.
-func JoinNS(pid uint) (bool, int, error) {
+func JoinNS(pid uint, preserveFDs int) (bool, int, error) {
 	if os.Geteuid() == 0 || os.Getenv("_LIBPOD_USERNS_CONFIGURED") != "" {
 		return false, -1, nil
 	}
@@ -117,6 +117,13 @@ func JoinNS(pid uint) (bool, int, error) {
 	if int(pidC) < 0 {
 		return false, -1, errors.Errorf("cannot re-exec process")
 	}
+	if preserveFDs > 0 {
+		for fd := 3; fd < 3+preserveFDs; fd++ {
+			// These fds were passed down to the runtime.  Close them
+			// and not interfere
+			os.NewFile(uintptr(fd), fmt.Sprintf("fd-%d", fd)).Close()
+		}
+	}
 
 	ret := C.reexec_in_user_namespace_wait(pidC)
 	if ret < 0 {