summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #6478 from rhatdan/abisupportOpenShift Merge Robot2020-06-03
|\ | | | | Remove use of ABISupport buildtag
| * Remove use of ABISupport buildtagDaniel J Walsh2020-06-03
| | | | | | | | | | | | | | | | | | | | We need to default to building podman. If you specify no build tags you will not build podman, not podman-remote. Just using remote flag to indicate podman-remote and !remote for podman. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #6483 from mheon/cleanup_on_stopOpenShift Merge Robot2020-06-03
|\ \ | | | | | | When stopping containers locally, ensure cleanup runs
| * | When stopping containers locally, ensure cleanup runsMatthew Heon2020-06-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cleanup process was already running and ensuring that mounts and networking configuration was cleaned up on container stop, but this was async from the actual `podman stop` command which breaks some expectations - the container is still mounted at the end of `podman stop` and will be cleaned up soon, but not immediately. Fortunately, it's a trivial change to resolve this. Fixes #5747 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #6461 from chuanchang/add_contaner_cases_for_apiv2OpenShift Merge Robot2020-06-03
|\ \ \ | |/ / |/| | test.apiv2: add test cases for committing an image from a container
| * | test.apiv2: add test cases for committing an image from a containerAlex Jia2020-06-03
| | | | | | | | | | | | | | | | | | | | | Testing query parameters: container, repo, tag, comment, author, changes and pause. Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
* | | Merge pull request #6465 from rhatdan/remoteOpenShift Merge Robot2020-06-03
|\ \ \ | | | | | | | | Add more Remote tests
| * | | Add more Remote testsDaniel J Walsh2020-06-03
| |/ / | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6469 from jwhonce/wip/authOpenShift Merge Robot2020-06-03
|\ \ \ | | | | | | | | V2 Add support for ssh authentication methods
| * | | V2 Add support for ssh authentication methodsJhon Honce2020-06-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * podman --remote ssh://<user>:<password>@<host>:<port><path> * podman --remote ssh://<user>:<password>@<host>:<port><path> \ --identity <path> --passphrase <phrase> * ssh-add <key> podman --remote ssh://<user>@<host><path> * Fix `podman help` to run even if podman missing components * Prompt for passphrase on stdin IFF key is protected and passphrase not given via any other configuration * cobra flags do not support optional value flags therefore refactored --remote to be a boolean and --url will now contain the URI to Podman service Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #6473 from mheon/fix_inspect_segfaultOpenShift Merge Robot2020-06-03
|\ \ \ \ | |/ / / |/| | | Fix a segfault in `podman inspect -l` w/ no containers
| * | | Fix a segfault in `podman inspect -l` w/ no containersMatthew Heon2020-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We also need to rework container/image inspect to be separate, but that can happen in another PR. Fixes #6472 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #6477 from rhatdan/specOpenShift Merge Robot2020-06-03
|\ \ \ \ | |_|_|/ |/| | | RHEL8 and Centos8 don't have oci-runtime yet
| * | | RHEL8 and Centos8 don't have oci-runtime yetDaniel J Walsh2020-06-03
| | |/ | |/| | | | | | | | | | | | | | | | For the time being we need to just require runc this should fix rdoproject.org/github-check Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6474 from QiWang19/remote-cidfile-testOpenShift Merge Robot2020-06-03
|\ \ \ | |/ / |/| | Turn on remote rm_test
| * | Turn on remote rm_test --cidfileQi Wang2020-06-02
|/ / | | | | | | | | | | Turn on remote rm_test --cidfile Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Merge pull request #6471 from mheon/troubleshooting_77OpenShift Merge Robot2020-06-03
|\ \ | | | | | | Remove reference to "upcoming" RHEL 7.7
| * | Remove reference to "upcoming" RHEL 7.7Matthew Heon2020-06-02
| |/ | | | | | | | | | | | | | | | | 7.7 has been released for a while now, so change troubleshooting reference to indicate that. Fixes #6349 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #6468 from mheon/remote_detached_execOpenShift Merge Robot2020-06-03
|\ \ | | | | | | Enable detached exec for remote
| * | Bump Conmon in COPR specMatthew Heon2020-06-02
| | | | | | | | | | | | | | | | | | We need 2.0.17 for detached remote exec. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Enable detached exec for remoteMatthew Heon2020-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The biggest obstacle here was cleanup - we needed a way to remove detached exec sessions after they exited, but there's no way to tell if an exec session will be attached or detached when it's created, and that's when we must add the exit command that would do the removal. The solution was adding a delay to the exit command (5 minutes), which gives sufficient time for attached exec sessions to retrieve the exit code of the session after it exits, but still guarantees that they will be removed, even for detached sessions. This requires Conmon 2.0.17, which has the new `--exit-delay` flag. As part of the exit command rework, we can drop the hack we were using to clean up exec sessions (remove them as part of inspect). This is a lot cleaner, and I'm a lot happier about it. Otherwise, this is just plumbing - we need a bindings call for detached exec, and that needed to be added to the tunnel mode backend for entities. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #6467 from baude/v2windowsenvOpenShift Merge Robot2020-06-02
|\ \ \ | |_|/ |/| | make env handling os dependent
| * | make env handling os dependentBrent Baude2020-06-02
| | | | | | | | | | | | | | | | | | environment variables are handled differently on windows vs linux. here we split them to be handled but no actually processing of windows environment variables was done. it can be added for future. hoowever, now we dont get errors on windows about processing them. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #6435 from QiWang19/uidOpenShift Merge Robot2020-06-02
|\ \ \ | | | | | | | | check --user range for rootless containers
| * | | check --user range for rootless containersQi Wang2020-06-02
| | | | | | | | | | | | | | | | | | | | | | | | Check --user range if it's a uid for rootless containers. Returns error if it is out of the range. From https://github.com/containers/libpod/issues/6431#issuecomment-636124686 Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #6460 from vrothberg/no-truncOpenShift Merge Robot2020-06-02
|\ \ \ \ | |_|_|/ |/| | | images --no-trunc: fix ID formatting
| * | | images --no-trunc: fix ID formattingValentin Rothberg2020-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the redundant `sha256:` prefix from the image IDs. Fixes: #6459 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #6457 from rhatdan/psgoOpenShift Merge Robot2020-06-02
|\ \ \ \ | |_|_|/ |/| | | Update vendor containers/psgo
| * | | Update vendor containers/psgoDaniel J Walsh2020-06-02
| |/ / | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6445 from ↵OpenShift Merge Robot2020-06-02
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.12.3 Bump github.com/onsi/ginkgo from 1.12.2 to 1.12.3
| * | | Bump github.com/onsi/ginkgo from 1.12.2 to 1.12.3dependabot-preview[bot]2020-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.12.2 to 1.12.3. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.12.2...v1.12.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #6463 from ↵OpenShift Merge Robot2020-06-02
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/coreos/go-systemd/v22-22.1.0 Bump github.com/coreos/go-systemd/v22 from 22.0.0 to 22.1.0
| * | | | Bump github.com/coreos/go-systemd/v22 from 22.0.0 to 22.1.0dependabot-preview[bot]2020-06-02
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.0.0 to 22.1.0. - [Release notes](https://github.com/coreos/go-systemd/releases) - [Commits](https://github.com/coreos/go-systemd/compare/v22.0.0...v22.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #6462 from ↵OpenShift Merge Robot2020-06-02
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.0-rc90 Bump github.com/opencontainers/runc from 1.0.0-rc9 to 1.0.0-rc90
| * | | Bump github.com/opencontainers/runc from 1.0.0-rc9 to 1.0.0-rc90dependabot-preview[bot]2020-06-02
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.0-rc9 to 1.0.0-rc90. - [Release notes](https://github.com/opencontainers/runc/releases) - [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc9...v1.0.0-rc90) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6455 from rhatdan/detatchkeysOpenShift Merge Robot2020-06-02
|\ \ \ | | | | | | | | Add information on detach-keys
| * | | Add information on detach-keysDaniel J Walsh2020-06-01
| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #6411 from mheon/exec_bindingsOpenShift Merge Robot2020-06-02
|\ \ \ \ | | | | | | | | | | Add bindings for exec and enable attached remote exec
| * | | | Add bindings for exec and enable attached remoteMatthew Heon2020-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds bindings for starting exec sessions, and then uses them to wire up detached exec. Code is heavily based on Attach code for containers, slightly modified to handle exec sessions. Bindings are presently attached-only, detached is pending on a Conmon update landing in CI. I'll probably get to that next. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #6443 from SCHEN2015/combine_ro_readonlyOpenShift Merge Robot2020-06-02
|\ \ \ \ \ | |_|_|/ / |/| | | | Combine the code of dealing with 'readonly' and 'ro'.
| * | | | Combine the code of dealing with 'readonly' and 'ro'.Charles Shih2020-06-02
|/ / / / | | | | | | | | | | | | | | | | | | | | https://github.com/containers/libpod/pull/6380#discussion_r432391376 Signed-off-by: Charles Shih <schrht@gmail.com>
* | | | Merge pull request #6456 from edsantiago/batsOpenShift Merge Robot2020-06-01
|\ \ \ \ | | | | | | | | | | system tests : more tests
| * | | | system tests : more testsEd Santiago2020-06-01
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - exec: add test for #5046, in which conmon swallowed chars on a large byte transfer - pod: add 'pod exists' tests, both positive and negative; consolidate tests; add '--label', and check in 'pod inspect' add 'pod ps' tests - networking: add test for #5466, in which detached run with --userns=keep-id would not forward a port Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #6350 from rhatdan/buildOpenShift Merge Robot2020-06-01
|\ \ \ \ | | | | | | | | | | Don't build code on remoteclient
| * | | | Don't build code on remoteclientDaniel J Walsh2020-05-29
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #6453 from jwhonce/wip/errorsOpenShift Merge Robot2020-06-01
|\ \ \ \ \ | | | | | | | | | | | | Add invalid value to error message
| * | | | | Add invalid value to error messageJhon Honce2020-06-01
| | |_|_|/ | |/| | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #6454 from rhatdan/remoteOpenShift Merge Robot2020-06-01
|\ \ \ \ \ | |_|_|/ / |/| | | | Remove skipifremote checks in images_test.go
| * | | | turn on remote testing for images. podman-remote build now works.Daniel J Walsh2020-06-01
| |/ / / | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #6449 from baude/v2podlabelsOpenShift Merge Robot2020-06-01
|\ \ \ \ | |/ / / |/| | / | | |/ | |/| Add support for format {{.Label}}
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-29 07:42:14 +0000