summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Use /tmp/podman-run-* for backup XDG_RUNTIME_DIRDaniel J Walsh2020-11-04
| | | | | | | We need to block systemd from cleaning up this directory by dropping a /usr/lib/tmpfiles.d/podman.conf file in place. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #8225 from ↵OpenShift Merge Robot2020-11-04
|\ | | | | | | | | debarshiray/wip/rishi/exec_test-use-containsubstring Improve error messages from failing tests
| * Improve error messages from failing testsDebarshi Ray2020-11-03
| | | | | | | | | | | | | | | | | | | | Using a function like ContainSubstring or Equal is better because if the test fails it will log a descriptive error that includes the actual string generated during the test. This is more helpful than a function like BeTrue that will only indicate that an assertion failed without giving further details of the failure. Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
* | Merge pull request #8237 from vorburger/patch-1OpenShift Merge Robot2020-11-04
|\ \ | | | | | | Add tip re. typical root cause of "Exec format error" to troubleshooting.md
| * | Add tip re. typical root cause of "Exec format error" to troubleshooting.mdMichael Vorburger ⛑️2020-11-03
| | | | | | | | | | | | Signed-off-by: Michael Vorburger <mike@vorburger.ch>
* | | Merge pull request #8229 from vrothberg/pr-templateOpenShift Merge Robot2020-11-04
|\ \ \ | | | | | | | | [CI:DOCS] add a PR template
| * | | add a PR templateValentin Rothberg2020-11-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a pull-request template that points to the section in the contributing guidelines and to remind users to use the `[CI:DOCS]` prefix if applicable. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #8209 from mwhahaha/issue-8208OpenShift Merge Robot2020-11-03
|\ \ \ \ | |_|/ / |/| | | Change http ConnState actions between new and active
| * | | Change http ConnState actions between new and activeAlex Schultz2020-10-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently it double counts connections because it's incrementing the total for both the new and active states. Based on the comments, we should only count new connections for the total count and perform the timer stop actions when the connection has transitioned to an active state. Closes #8208 Signed-off-by: Alex Schultz <aschultz@redhat.com>
* | | Merge pull request #8232 from ashley-cui/volfiltOpenShift Merge Robot2020-11-03
|\ \ \ | | | | | | | | Make volume filters inclusive
| * | | Make volume filters inclusiveAshley Cui2020-11-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using multiple filters, return a volume that matches any one of the used filters, rather than matching both of the filters. This is for compatibility with docker's cli, and more importantly, the apiv2 compat endpoint Closes #6765 Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #8233 from baude/umohnani8OpenShift Merge Robot2020-11-03
|\ \ \ \ | | | | | | | | | | [CI:DOCS]Add Urvashi to podman OWNERS
| * | | | [CI:DOCS]Add Urvashi to podman OWNERSbaude2020-11-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lets add Urvashi to podman OWNERS so she can review and merge PRs. Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #8213 from saschagrunert/osusergoOpenShift Merge Robot2020-11-03
|\ \ \ \ \ | | | | | | | | | | | | Use osusergo build tag for static build
| * | | | | Use osusergo build tag for static buildSascha Grunert2020-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now use the `osusergo` build tag to not use the glibc functions which occur in the warnings but them from golang the os/user package. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | | | | Merge pull request #8219 from rhafer/rootless-mountsOpenShift Merge Robot2020-11-03
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | docs: Mention mounts.conf location for non-root users
| * | | | | docs: Mention mounts.conf location for non-root usersRalf Haferkamp2020-11-02
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Ralf Haferkamp <rhafer@suse.com>
* | | | | | Merge pull request #8204 from jwhonce/jira/run-976OpenShift Merge Robot2020-11-03
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Add test/apiv2/rest_api tests to make target
| * | | | | Add test/apiv2/rest_api tests to make targetJhon Honce2020-11-02
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * renamed old API tests to not be discovered, they do not pass * Updated the API tests to use a pristine storage configuration * Skipped attach test, it needs to be re-written Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #8231 from baude/fedorarootlesscpulimitOpenShift Merge Robot2020-11-03
|\ \ \ \ \ | | | | | | | | | | | | fedora rootless cpu settings
| * | | | | fedora rootless cpu settingsbaude2020-11-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fedora does not have the the ability in rootless to set cpu limits. this requires a simple fix for fedora 33 to pass ci tests. Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #8226 from ↵OpenShift Merge Robot2020-11-03
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | debarshiray/wip/rishi/toolbox_test-userns-keepid-HOME Test $HOME when it's parent is bind mounted with --userns=keep-id
| * | | | | Test $HOME when it's parent is bind mounted with --userns=keep-idDebarshi Ray2020-11-03
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When --userns=keep-id is used, Podman is supposed to set up the home directory of the user inside the container to match that on the host as long as the home directory or any of its parents are marked as volumes to be bind mounted into the container. Currently, the test only considers the case where the home directory itself is bind mounted into the container. It doesn't cover the Podman code that walks through all the bind mounts looking for ancestors in case the home directory itself wasn't specified as a bind mount. Therefore, this improves the existing test added in commit 6ca8067956128585 ("Setup HOME environment when using --userns=keep-id") Note that this test can't be run as root. The home directory of the root user is /root, and it's parent is /. Bind mounting the entire / from the host into the container prevents it from starting: Error: openat2 ``: No such file or directory: OCI not found Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
* | | | | Merge pull request #8224 from jjasghar/patch-1OpenShift Merge Robot2020-11-03
|\ \ \ \ \ | | | | | | | | | | | | Update README.md
| * | | | | Update README.mdJJ Asghar2020-11-02
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | Typo Signed-off-by: JJ Asghar <jjasghar@gmail.com>
* | | | | Merge pull request #8217 from giuseppe/caps-ambientOpenShift Merge Robot2020-11-03
|\ \ \ \ \ | |/ / / / |/| | | | specgen: add support for ambient capabilities
| * | | | specgen: keep capabilities with --userns=keep-idGiuseppe Scrivano2020-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if --userns=keep-id is specified and not --user is specified, take the unprivileged capabilities code path so that ambient capabilities are honored in the container. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | specgen: fix check for root userGiuseppe Scrivano2020-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if the username is specified in the USER:GROUP form, make sure we only check for USER. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | specgen: add support for ambient capabilitiesGiuseppe Scrivano2020-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if the kernel supports ambient capabilities (Linux 4.3+), also set them when running with euid != 0. This is different that what Moby does, as ambient capabilities are never set. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #8166 from rhatdan/unbindableOpenShift Merge Robot2020-11-02
|\ \ \ \ \ | |_|/ / / |/| | | | Allow users to mount with unbindable flag
| * | | | Add better support for unbindable volume mountsDaniel J Walsh2020-11-02
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Allow users to specify unbindable on volume command line Switch internal mounts to rprivate to help prevent leaks. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8207 from xordspar0/common-period-quotaOpenShift Merge Robot2020-11-02
|\ \ \ \ | | | | | | | | | | Centralize cores and period/quota conversion code
| * | | | Centralize cores and period/quota conversion codeJordan Christiansen2020-10-31
| |/ / / | | | | | | | | | | | | Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
* | | | Merge pull request #8210 from TomSweeneyRedHat/dev/tsweeney/fixpull2OpenShift Merge Robot2020-11-02
|\ \ \ \ | |_|/ / |/| | | Match build pull functionality with Docker's
| * | | Match build pull functionality with Docker'sTomSweeneyRedHat2020-10-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a continuation of #8189 and #8085. When doing a `docker build` command, if the `--pull` command is not specified or set to `false` the pullOption used is `PullifMissing`. This causes the build to pull the image only if it is not present in local storage. It also will raise an error if the image is not found in the registry (or the registry is down), even if the image is present in local storage. If the `--pull` command IS specified or specified with an argument of `true`, the build will always pull the image from the registries. This uses the pullOption `PullAlways`. It also will raise an error if the image is not found in the registry, even if the image is present in local storage. These changes now brings the pull functionality for `podman build` into line with `docker build`. However, I consider this to be a breaking change. Previously if you did `podman build --pull`, `podman build` or `podman build --pull = true`, then the image would be pulled from the registry if there was not an image in local storage or if the image in the registry was newer than the one in local storage. An error would *NOT* be raised if there was not an image in the registry or the registry was down as long as there was a copy in the local storage. An error would be raised if the image could not be retrieved from both the registry and local storage. This is the PullOption `PullIfNewer`. I believe this also differs from what Buildah does at this time but I'm too beat to chase that down at the moment. Personally I'd like to use the `PullIfNewer` for at least `--pull` and `--pull=true` so that you don't get an error if the registry has a network hiccup and the image is already stored locally. But this differs from Docker. I'd like to post scrum about this at our next stand up to make sure we're all on the same page about the ramifications of this change. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #8212 from ↵OpenShift Merge Robot2020-11-02
|\ \ \ | |/ / |/| | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.23.8 Bump github.com/containers/storage from 1.23.7 to 1.23.8
| * | Bump github.com/containers/storage from 1.23.7 to 1.23.8dependabot-preview[bot]2020-11-02
|/ / | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.23.7 to 1.23.8. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.23.7...v1.23.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #8197 from giuseppe/check-cgroupv2-swap-enabledOpenShift Merge Robot2020-10-31
|\ \ | | | | | | specgen, cgroup2: check whether memory swap is enabled
| * | specgen, cgroup2: check whether memory swap is enabledGiuseppe Scrivano2020-10-30
| | | | | | | | | | | | | | | | | | add a similar check to what we do on cgroup v1. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | specgen: split cgroup v1 and cgroup v2 codeGiuseppe Scrivano2020-10-30
| | | | | | | | | | | | | | | | | | refactor function into two separate ones. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #8203 from Luap99/fix-8194OpenShift Merge Robot2020-10-31
|\ \ \ | | | | | | | | Fix dnsname when joining a different network namespace in a pod
| * | | Fix dnsname when joining a different network namespace in a podPaul Holzinger2020-10-30
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | When creating a container in a pod the podname was always set as the dns entry. This is incorrect when the container is not part of the pods network namespace. This happend both rootful and rootless. To fix this check if we are part of the pods network namespace and if not use the container name as dns entry. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #8100 from QiWang19/mirror-manifestOpenShift Merge Robot2020-10-31
|\ \ \ | |_|/ |/| | manifest list inspect single image
| * | manifest list inspect single imageQi Wang2020-10-30
| |/ | | | | | | | | | | If the image name not a manifest list type, enable manifest inspect to return manifest of single image manifest type vnd.docker.distribution.manifest.v2+json. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Merge pull request #8201 from QiWang19/search-limitOpenShift Merge Robot2020-10-30
|\ \ | | | | | | Remove search limit since pagination support
| * | Remove search limit since pagination supportQi Wang2020-10-30
| |/ | | | | | | | | | | Remove the search limit check since the c/image v5.6.0 supports pagination and can give result over 100 entries. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Merge pull request #8202 from TomSweeneyRedHat/dev/tsweeney/buildahv1.17.0OpenShift Merge Robot2020-10-30
|\ \ | | | | | | Bump Buildah to v1.17.0
| * | Bump Buildah to v1.17.0TomSweeneyRedHat2020-10-30
| | | | | | | | | | | | | | | | | | Bump Buildah to v1.17.0 on Master. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #8177 from rhatdan/wrapOpenShift Merge Robot2020-10-30
|\ \ \ | | | | | | | | Stop excessive wrapping of errors
| * | | Stop excessive wrapping of errorsDaniel J Walsh2020-10-30
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the builtin golang functions like os.Stat and os.Open report errors including the file system object path. We should not wrap these errors and put the file path in a second time, causing stuttering of errors when they get presented to the user. This patch tries to cleanup a bunch of these errors. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-20 04:33:19 +0000