aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Cirrus: Fix tag & branch go checks failingChris Evich2022-10-03
| | | | | | | | When running on a branch or tag, `req_env_vars()` will call `exit(1)` because `$CIRRUS_PR` is empty (as expected). The original intention was to simply skip language checks on non-PRs. Fix the condition to match. Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #16028 from edsantiago/docs_dedup_compression-formatOpenShift Merge Robot2022-10-03
|\ | | | | [CI:DOCS] Man pages: refactor common options: --compression-format
| * Man pages: refactor common options: --compression-formatEd Santiago2022-10-02
| | | | | | | | | | | | Easy one: text was already identical across both files. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #15846 from jakecorrenti/pod-logs-latestOpenShift Merge Robot2022-10-03
|\ \ | |/ |/| `podman pod logs -l` no longer panics
| * `podman pod logs -l` no longer panicsJake Correnti2022-09-29
| | | | | | | | | | | | | | Fixed issue where executing the command `podman pod logs -l` would panic because it was indexing into an empty arguments array. Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
* | Merge pull request #16016 from Luap99/netns-cleanupOpenShift Merge Robot2022-10-01
|\ \ | | | | | | cleanup: always delete netns mount
| * | cleanup: always delete netns mountPaul Holzinger2022-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should not keep the netns if there was a cleanup problem. Deleting the netns will also delete the virtual links inside and thus make the IPs available again for the next use. context: https://github.com/containers/netavark/issues/302 [NO NEW TESTS NEEDED] This is very hard to trigger reliable and it would need to work with cni and netavark. This mostly happens because of specic bugs but those will be fixed and then this test would fail. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #15978 from iamkirkbater/add-brew-to-issue-templateOpenShift Merge Robot2022-10-01
|\ \ \ | | | | | | | | [CI:DOCS] Adds brew info podman to issue template.
| * | | Adds brew info podman to issue template.Kirk Bater2022-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Just a quick little addition to provide the command to get the package info from brew for those who might not know. Signed-off-by: Kirk Bater <kirk.bater@gmail.com>
* | | | Merge pull request #16015 from mtrmac/pgzip-updateOpenShift Merge Robot2022-10-01
|\ \ \ \ | |_|/ / |/| | | Update for https://github.com/klauspost/pgzip/pull/50
| * | | Update for https://github.com/klauspost/pgzip/pull/50Miloslav Trmač2022-09-30
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | ... to fix reads of compressed data by docker-archive: > go get github.com/klauspost/pgzip@master > make vendor Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | | Merge pull request #16010 from vrothberg/container-inspectOpenShift Merge Robot2022-09-30
|\ \ \ | | | | | | | | container inspect: include image digest
| * | | container inspect: include image digestValentin Rothberg2022-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Include the digest of the image in `podman container inspect`. The image digest is a key information for auditing as it defines the identify of an image. This way, it can be determined whether a container used an image with a given CVE etc. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | Merge pull request #16008 from rhatdan/VENDOROpenShift Merge Robot2022-09-30
|\ \ \ \ | | | | | | | | | | Update vendor containers/(common,image)
| * | | | Update vendor containers/(common,image)Daniel J Walsh2022-09-30
| |/ / / | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #15999 from edsantiago/docs_dedup_sign-passphrase-fileOpenShift Merge Robot2022-09-30
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Man pages: Refactor common options: --sign-passphrase-file
| * | | | Man pages: Refactor common options: --sign-passphrase-fileEd Santiago2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Trivial one: no human intervention needed, the man page text was already identical between both files. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #16001 from cevich/image_readmeOpenShift Merge Robot2022-09-30
|\ \ \ \ \ | |_|/ / / |/| | | | [CI:DOCS] Add quay-description update reminder
| * | | | [CI:DOCS] Add quay-description update reminderChris Evich2022-09-29
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #16005 from sstosh/fix-typoOpenShift Merge Robot2022-09-30
|\ \ \ \ \ | | | | | | | | | | | | Fix typo about e2e tests name
| * | | | | Fix typo about e2e tests nameToshiki Sonoda2022-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * podman stop --all -> podman kill --all * podman pause --filter -> podman restart --filter [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | | | Merge pull request #15868 from rst0git/podman-run-checkpoint-imgOpenShift Merge Robot2022-09-30
|\ \ \ \ \ \ | |/ / / / / |/| | | | | cmd/podman: add support for checkpoint images
| * | | | | Add test for podman run with checkpoint imageRadostin Stoyanov2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `podman run` command has been extended with support for checkpoint images. A checkpoint image contains image files generated by criu that allow to restore the runtime state of containerized applications. This patch adds a test case for this functionality. Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
| * | | | | cmd/podman: add support for checkpoint imagesRadostin Stoyanov2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch extends the podman run command with support for checkpoint images. When `podman run` is invoked with an image that contains a checkpoint, it would restore the container from that checkpoint. Example: podman run -d --name looper busybox /bin/sh -c \ 'i=0; while true; do echo $i; i=$(expr $i + 1); sleep 1; done' podman container checkpoint --create-image checkpoint-image-1 looper podman run checkpoint-image-1 Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
| * | | | | restore: make IsCheckpointImage reusableRadostin Stoyanov2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Podman allows to store a container checkpoints as an images. This patch makes the check that is used to recognise such checkpoint images reusable by moving it in utils. This functionality will be reused in a subsequent patch to extend the `podman run` command with support for checkpoint images. Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
* | | | | | Merge pull request #15909 from cdoern/restoreOpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix restore API endpoint
| * | | | | | fix restore API endpointcdoern2022-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | restore endpoint was totally ignoring --pod, it was missing from the schema and from query handling on the api handlers side. add support for it here. resolves #15018 Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | | | | Merge pull request #15782 from cevich/bundle_build_tasksOpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Cirrus: Task consolidation
| * | | | | | | Cirrus: Combine build and code consistency tasksChris Evich2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's conceivable for CI to spend a lot of time testing code which otherwise should be rejected due to quality problems. Previously this was validated in a dedicated task, however a failure would still fail the CI run. Simplify the number of CI tasks by combining the consistency check at the tail-end of the build task. Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | | | | | Cirrus: Combine pre-test checks into build taskChris Evich2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, two tasks always ran first, prior to anything else. One to verify network and external-service connectivity. Another to verify certain important `.cirrus.yml` standards are met. However, as the total number of tasks continues to grow, the need to keep these basic checks as dedicated prerequisites is of decreasing value/importance. Fold these two checks into a new `pretesting_script` component of the Fedora `build` task, on both `x86_64` and `aarch64`. Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | | | | | Cirrus: Minor YAML comment/whitespace fixChris Evich2022-09-29
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | | Merge pull request #15998 from Luap99/play-kube-hostnetOpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | podman kube play allow --network host
| * | | | | | Man pages: refactor common options: --networkEd Santiago2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tricky one. In particular: podman-kube-play did not enumerate the "host" option; here I take the liberty of using it in the common network.md, so it will appear in podman-kube-play.1. If that is wrong, please tell me ASAP: I will need to un-refactor podman-kube-play. Other decisions: * move the "invalid if" text to the bottom, because it can't be shared between pod and container man pages. * ditto for "together with --pod" * kube-play said "Change the network mode of"; all the others said ">SET< the network mode >FOR< ...". I chose the latter, so that's what kube-play will have also. Again, if that's wrong, please lmk. Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | podman kube play allow --network hostPaul Holzinger2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I see no reason to block --network host with kube play and force users to have to set it in the yaml file. This is just confusing when compared to the other podman create/run --network options, see discussion in #15945. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | | | Merge pull request #15994 from Luap99/flake-15990OpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | fix "podman system prune networks" flake
| * | | | | | | fix "podman system prune networks" flakePaul Holzinger2022-09-29
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since by default the network config dir is shared in the e2e tests any other parallel running test could remove a network and cause this test to fail. Fixes #15990 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | | | Merge pull request #15987 from flouthoc/bump-commonOpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | vendor: bump c/common to `v0.49.2-0.20220929111928-2d1b45ae2423`
| * | | | | | vendor: bump c/common to v0.49.2-0.20220929111928-2d1b45ae2423Aditya R2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
* | | | | | | Merge pull request #15996 from edsantiago/docs_dedup_log-optOpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | [CI:DOCS] Man pages: refactor common options: --log-opt
| * | | | | | Man pages: refactor common options: --log-optEd Santiago2022-09-29
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simple in reality, but hard to review due to lots of little diffs: - "Logging driver specific options" was only in podman-run; I added it to create and kube-play. - whitespace changes, the 'e.g.'s got consistent 4-space indentation - the "same keys" and "supported only" sentences, I moved up to be closer to **tag** and without intervening whitespace, because they were unclear as they were: I believe the intent is to apply those sentences only to **tag**, not to the **--log-opt** option itself. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #15992 from Luap99/revert-15988OpenShift Merge Robot2022-09-29
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Revert "remote: fix manifest add --annotation"
| * | | | | Revert "remote: fix manifest add --annotation"Paul Holzinger2022-09-29
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 32f54a81ed797597827123b671b6e73194354327. `pkg/bindings` is supported outside of podman and we have to keep it stable. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #15988 from sstosh/manifest-annotate-remoteOpenShift Merge Robot2022-09-29
|\ \ \ \ \ | | | | | | | | | | | | remote: fix manifest add --annotation
| * | | | | remote: fix manifest add --annotationToshiki Sonoda2022-09-29
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * `manifest add --annotation option` adds annotations field on remote environment. * `manifest inspect` prints annotations field on remote environment. Fixes: #15952 Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | | Merge pull request #15981 from edsantiago/dont_storageoptOpenShift Merge Robot2022-09-29
|\ \ \ \ \ | | | | | | | | | | | | System tests: stop deep-checking log-level
| * | | | | System tests: stop deep-checking log-levelEd Santiago2022-09-28
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was testing --log-level by --storage-opt=mount_program=/bin/false Stop doing that. It's just constantly breaking everything (#15698 and #15977). I am violently of the opinion that a command-line option must not destroy a user's system (except for --set-something, --config, something that makes it very very clear that it is a lasting change). I seem to be in the minority on this opinion. So, I give up. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #15971 from ↵OpenShift Merge Robot2022-09-29
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.2 build(deps): bump github.com/container-orchestrated-devices/container-device-interface from 0.5.1 to 0.5.2
| * | | | | build(deps): bump ↵dependabot[bot]2022-09-28
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | github.com/container-orchestrated-devices/container-device-interface Bumps [github.com/container-orchestrated-devices/container-device-interface](https://github.com/container-orchestrated-devices/container-device-interface) from 0.5.1 to 0.5.2. - [Release notes](https://github.com/container-orchestrated-devices/container-device-interface/releases) - [Commits](https://github.com/container-orchestrated-devices/container-device-interface/compare/v0.5.1...v0.5.2) --- updated-dependencies: - dependency-name: github.com/container-orchestrated-devices/container-device-interface dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #15962 from dfr/freebsd-volumeOpenShift Merge Robot2022-09-29
|\ \ \ \ \ | |_|/ / / |/| | | | Add volume support for FreeBSD
| * | | | libpod: Add volume support for FreeBSDDoug Rabson2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-26 22:36:00 +0000