summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* cleanup network stack as well as storage when container shuts down.Daniel J Walsh2018-02-08
| | | | | | This patch will cleanup the network stack when the container exits Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* remove shebang from bash completionLokesh Mandvekar2018-02-08
| | | | | | | | | | | | | | | shebang presence causes rpmlint error: "non-executable-script /usr/share/bash-completion/completions/podman 644 /bin/bash" completions aren't executable in themselves so there's no need for a shebang there. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Closes: #313 Approved by: rhatdan
* Merge pull request #293 from rhatdan/sd_notifyMatthew Heon2018-02-07
|\ | | | | Need to add LISTEN_PID environment variable to conmon command
| * Need to add LISTEN_PID environment variable to conmon commandDaniel J Walsh2018-02-05
| | | | | | | | | | | | | | Without this field then conmon will not pass the proper data down to the OCI Runtime. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #290 from umohnani8/templatesDaniel J Walsh2018-02-07
|\ \ | | | | | | Fix when the --format flag prints a new line at the end
| * | Fix when the --format flag prints a new line at the endumohnani82018-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the output is to a terminal, return a new line at the end of the output so that the output is visually appealing. If the output is being piped, or saved to a file, basically not being outputted to a terminal, do not print a new line at the end of the output. This ensures any further data manipulation with the results happens smoothly without requiring to remember the '/n' at the end of the output. Signed-off-by: umohnani8 <umohnani@redhat.com>
* | | Merge pull request #300 from baude/ginkgo_versionDaniel J Walsh2018-02-07
|\ \ \ | | | | | | | | More ginkgo migration
| * | | More ginkgo migrationbaude2018-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * attach * run_exit * save * tag * version * run_privileged -> privileged Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #310 from baude/coprBrent Baude2018-02-07
|\ \ \ \ | | | | | | | | | | Add the spec file to podman
| * | | | Add the spec file to podmanbaude2018-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Taking the fedora spec file and adding it to the git repo for copr Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #309 from mheon/pause_state_errorDaniel J Walsh2018-02-07
|\ \ \ \ \ | |/ / / / |/| | | | Change pause so only running containers are valid
| * | | | Change pause so only running containers are validMatthew Heon2018-02-07
| | |/ / | |/| | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #289 from TomSweeneyRedHat/dev/tsweeney/usernameDaniel J Walsh2018-02-07
|\ \ \ \ | | | | | | | | | | Change un/pwd handling to match Buildah's
| * | | | Change un/pwd handling to match Buildah'sTomSweeneyRedHat2018-02-06
| | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | | Merge pull request #303 from umohnani8/certsDaniel J Walsh2018-02-07
|\ \ \ \ \ | |_|/ / / |/| | | | Change default certs dir to /etc/containers/certs.d
| * | | | Change default certs dir to /etc/containers/certs.dumohnani82018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated man pages to reflect the change Signed-off-by: umohnani8 <umohnani@redhat.com>
| * | | | Vendor in latest containers/imageumohnani82018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes the default certs directory to /etc/containers/certs.d Signed-off-by: umohnani8 <umohnani@redhat.com>
* | | | | Merge pull request #307 from rhatdan/sudoDaniel J Walsh2018-02-07
|\ \ \ \ \ | | | | | | | | | | | | Change sudo examples to use $ instead of $
| * | | | | Change sudo examples to use $ instead of $Daniel J Walsh2018-02-07
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sudo is not required when running as root, and # indicates that you are already root. $ indicates you are not root. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* / / / / Error on attempting to restart containerMatthew Heon2018-02-07
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #304 Approved by: baude
* | | | Match podman inspect output to docker inspectumohnani82018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Made a change to make sure that the output paths of podman inspect matches that of docker inspect. For example to get the stop signal you should be able to do podman inspect ctr --format {{.Config.StopSignal}} and the same thing in docker will give the same results. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #292 Approved by: rhatdan
* | | | Touchup podman kill manpageMatthew Heon2018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #299 Approved by: rhatdan
* | | | Change stop signal default to SIGTERMMatthew Heon2018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #299 Approved by: rhatdan
* | | | Add podman search commandumohnani82018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman search queries a registry for a matching image and prints the output. I added a new flag called "registry" giving the user the option to search a specific registry if they don't want to search all their default registries. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #241 Approved by: rhatdan
* | | | Vendor in latest containers/imageumohnani82018-02-06
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | Latest containers/image has support for searching registries. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #241 Approved by: rhatdan
* | | avoid period character at the beginning of newlineLokesh Mandvekar2018-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise causes rpmlint error for manpage Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Closes: #296 Approved by: baude
* | | Migrate more tests to ginkgobaude2018-02-06
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Migrate the following to the ginkgo integration tests: * images * import * inspect * logs * run_dns Signed-off-by: baude <bbaude@redhat.com> Closes: #295 Approved by: mheon
* / sysfs should be mounted rw for privilegedbaude2018-02-06
|/ | | | | | | | | sysfs should be mounted rw for a privileged container. Signed-off-by: baude <bbaude@redhat.com> Closes: #279 Approved by: rhatdan
* Migrate diff, exec, export, and history to ginkgobaude2018-02-05
| | | | | | | | | | Migrate the diff, exec, export, and history bats tests to the ginkgo test suite. Signed-off-by: baude <bbaude@redhat.com> Closes: #287 Approved by: baude
* Integration testing readmebaude2018-02-05
| | | | | | | | | Wrote a small primer to setup for integration testing. Signed-off-by: baude <bbaude@redhat.com> Closes: #288 Approved by: rhatdan
* Deprecate --format for podman topbaude2018-02-05
| | | | | | | | | | | | | | | | | | | Issue #169 describes a common failure when running podman top where if the commands inside the container container a space in them, podman will panic. This was occuring because we take the output from ps and attempt to format it nicely for output and things like JSON. Given that this cannot be predicted or dealt with programatically, the decision was made to deprecate the format switch and simply output what ps provides us. Migrated top integration tests to ginkgo. Resolves Issue: https://github.com/projectatomic/libpod/issues/169 Signed-off-by: baude <bbaude@redhat.com> Closes: #291 Approved by: rhatdan
* Pass NOTIFY_SOCKET and LISTEN_FDS env to OCI RUntime if setDaniel J Walsh2018-02-05
| | | | | | | | | | | | | | In order to have sd_notify from systemd to work in containers we need to pass down the NOTIFY_SOCKET environment variable to the container. LISTEN_FDS, tells the application inside of the container to use socket activation and grab the FDS that are leaked into the container. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #271 Approved by: umohnani8
* Allow users to specify logpathDaniel J Walsh2018-02-03
| | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #135 Approved by: mheon
* Migrate Create|Commit to ginkgobaude2018-02-02
| | | | | | | | | | | | Migrate create and commit bats tests to the ginkgo test suite. In doing so, some structures had to be moved to pkg/podmanstructs/podmanstructs.go so we could do better verification of test results. Signed-off-by: baude <bbaude@redhat.com> Closes: #286 Approved by: rhatdan
* Merge pull request #284 from mheon/update_vendorsDaniel J Walsh2018-02-02
|\ | | | | Update containerd/cgroups to fix perf issue
| * Update stats code to reflect changes to containerd stats APIMatthew Heon2018-02-01
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * Update containerd/cgroups repo fix perf issueMatthew Heon2018-02-01
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
* | Merge pull request #282 from randomvariable/fix/sandboxDaniel J Walsh2018-02-02
|\ \ | | | | | | Set default configuration container type annotation to sandbox
| * | Set default configuration container type annotation to sandboxNaadir Jeewa2018-02-01
| | | | | | | | | | | | | | | | | | | | | | | | This allows podman to provide sufficient hints to start containers with Intel Clear Containers: https://github.com/clearcontainers/runtime/blob/master/docs/architecture/architecture.md#oci-annotations Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>
* | | Fix --cert-dir path for podman loginumohnani82018-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman login would add on the registry name to the cert-dir path making containers/image look in a directory that did not exist for certificates. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #283 Approved by: rhatdan
* | | Migrate kill tests to ginkgobaude2018-02-01
| |/ |/| | | | | | | | | | | | | | | | | Migrate kill tests to the ginkgo suite and remove the podman_kill bats. Signed-off-by: baude <bbaude@redhat.com> Closes: #281 Approved by: baude
* | Add authfile, cert-dir and creds params to buildTomSweeneyRedHat2018-02-01
| | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #280 Approved by: mheon
* | Implment network == nonebaude2018-01-31
|/ | | | | | | | | | When network == none, the container should only have a loopback interface and that's it. Signed-off-by: baude <bbaude@redhat.com> Closes: #176 Approved by: baude
* libpod/runtime.go: Stick paths in arraysbaude2018-01-31
| | | | | | | | | | | To account for more path possibilities, we now iterate a string array of possible paths to try and find paths to runc and conmon. Signed-off-by: baude <bbaude@redhat.com> Closes: #278 Approved by: baude
* Ginkgo Tests: ps, pull, push and rmbaude2018-01-31
| | | | | | | | | | | | | Migrate ps, pull, push, and rm from bats to ginkgo. Also, fixed a conditional issue with adding ports when an image defines the port and the user wants to override it. Signed-off-by: baude <bbaude@redhat.com> Closes: #277 Approved by: baude
* libpod/runtime.go: runtime pathbaude2018-01-31
| | | | | | | | | | | | Ubuntu installs runc to /usr/sbin/runc so we now account for that. Also, added small check when creating a new runtime that if we cannot find the runc binary, we bail out. Signed-off-by: baude <bbaude@redhat.com> Closes: #276 Approved by: baude
* docs/tutorials/podman_tutorial.md: Add Ubuntubaude2018-01-30
| | | | | | | | | Adding in how to install and run podman on Ubuntu. Signed-off-by: baude <bbaude@redhat.com> Closes: #275 Approved by: baude
* libpod/container_api: Set hostname in ENVbaude2018-01-30
| | | | | | | | | | The container's hostname should be set as an environment variable for the container. Signed-off-by: baude <bbaude@redhat.com> Closes: #273 Approved by: baude
* Migrate start, stats, stop to Ginkgobaude2018-01-30
| | | | | | | | | | Migrate the start, stats, and stop integration tests to the Ginkgo style. Signed-off-by: baude <bbaude@redhat.com> Closes: #274 Approved by: mheon
* Add StopWithTimeout API function for containersMatthew Heon2018-01-30
| | | | | | | | | | Normal Stop should not need a timeout, and should use the default Add a function that does accept a timeout aside it Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #272 Approved by: rhatdan