summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Trivial refactor on volume additionMatthew Heon2018-05-03
| | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* When adding volumes to DB, handle nontrivial casesMatthew Heon2018-05-03
| | | | | | | | | | We want to make sure we don't add anything but the host volume, and the volumes can include options and container locations. Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Add accessors for new image fields in container configMatthew Heon2018-05-03
| | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Store user Volumes, Entrypoint, Command in databaseMatthew Heon2018-05-03
| | | | | | | | | | | We need these for commit, and they cannot be properly deduced from just the OCI spec, so save them in the database so we can retrieve them for commit. Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Further fix Godoc comments in options.goMatthew Heon2018-05-03
| | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Update hooks to use config bool to detect volume mountsMatthew Heon2018-05-03
| | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Fix Godoc comments in options.goMatthew Heon2018-05-03
| | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Add config bool to indicate there are user volumesMatthew Heon2018-05-03
| | | | | | | | | | This allows us to accurately trigger OCI hooks that trigger on the presence of volume mounts. Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #700 Approved by: rhatdan
* Print the Buildah comment from commit to given writerMatthew Heon2018-05-03
| | | | | | | | | Much better than unconditionally dumping to stdout Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #706 Approved by: rhatdan
* Do not print unnecessary Buildah details during commitMatthew Heon2018-05-03
| | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #706 Approved by: rhatdan
* remove options from create/run that we cannot supportbaude2018-05-02
| | | | | | | Signed-off-by: baude <bbaude@redhat.com> Closes: #711 Approved by: rhatdan
* fix typos in the inspect json structsbaude2018-05-02
| | | | | | | | | Resolves: #633 Signed-off-by: baude <bbaude@redhat.com> Closes: #710 Approved by: rhatdan
* Fix podman logout --all flagumohnani82018-05-02
| | | | | | | | | | | podman logout --all should remove cached credentials for all registries in the auth.json file. Before this, it was asking for a registry to be given with the --all flag also. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #712 Approved by: rhatdan
* podman should assign a host port to -p when omittedbaude2018-05-01
| | | | | | | | | | | If the user does not provide a host port when adding -p to create/run, podman should inject an available random port. podman run -p 80 .... podman should assign a random port to the host and expose the container port 80 to it Signed-off-by: baude <bbaude@redhat.com> Closes: #703 Approved by: rhatdan
* Vendor in latest buildahumohnani82018-05-01
| | | | | | | | | Adds in --iidfile flag to podman build. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #707 Approved by: mheon
* Fix misc stuff found by jhoncebaude2018-04-30
| | | | | | | | | | | During the python client implementation, jhonce found some return types that needed correction as well as a panic related to history which is now corrected. Signed-off-by: baude <bbaude@redhat.com> Closes: #704 Approved by: rhatdan
* libpod.conf: Podman's conmon path on openSUSEValentin Rothberg2018-04-30
| | | | | | | | | Add the path to Podman's conmon for openSUSE and SLE. Signed-off-by: Valentin Rothberg <vrothberg@suse.com> Closes: #698 Approved by: mheon
* Add iidfile parame to build and commit man pagesTomSweeneyRedHat2018-04-30
| | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #693 Approved by: mheon
* do not commit default volumes from containerbaude2018-04-30
| | | | | | | | | | | when performing a container commit, we should not add the default list of volumes for a container to the resulting image. it will cause the resulting image to crash when run subsequently. Signed-off-by: baude <bbaude@redhat.com> Closes: #699 Approved by: mheon
* correct varlink command in service filebaude2018-04-30
| | | | | | | | | | The struct of the varlink command changed to accept a URI as input. This was never updated in the service file Signed-off-by: baude <bbaude@redhat.com> Closes: #691 Approved by: mheon
* Vendor in latest containers/imageumohnani82018-04-30
| | | | | | | | | | | Fixes podman pull to pull a public image even if $XDG_RUNTIME_DIR does not exist for authentication. Public images don't require credentials to access. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #701 Approved by: rhatdan
* Make ':' a restricted character for file namesumohnani82018-04-30
| | | | | | | | | | | file names for podman load, save, export, and import cannot contain ":" in them. It is a reserved character for parsing filenames. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #694 Approved by: rhatdan
* Add more validation to --volume flag for run and createumohnani82018-04-30
| | | | | | | | | | Return error if the host and container paths is a relative path. Only absolute paths allowed. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #695 Approved by: rhatdan
* Fix libseccomp not working in travisDaniel J Walsh2018-04-30
| | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #697 Approved by: mheon
* CONTRIBUTING: Document PR approval and link to OWNERSW. Trevor King2018-04-28
| | | | | | | | | | | | Remove a dead "Becoming a Maintainer" link and that stub section, since libpod currently doesn't document that process. By leaving it undocumented, maintainer changes falls back to the usual pull-request review process. Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #688 Approved by: rhatdan
* OWNERS: rename 'assignees' to 'approvers'W. Trevor King2018-04-28
| | | | | | | | | | | | | As CRI-O did in [1]. 'assignees' is deprecated and 'approvers' is effectively the same thing [2]. [1]: https://github.com/kubernetes-incubator/cri-o/pull/1103 [2]: https://github.com/kubernetes/test-infra/issues/3851 Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #688 Approved by: rhatdan
* Merge pull request #689 from mheon/bump_0_4_4Matthew Heon2018-04-27
|\ | | | | Bump to v0.4.4
| * Bump gitvalidation epochMatthew Heon2018-04-27
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * Bump to v0.5.1-devMatthew Heon2018-04-27
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * Bump to v0.4.4v0.4.4Matthew Heon2018-04-27
|/ | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
* Use buildah commit and bud in podmanbaude2018-04-27
| | | | | | | | | | | Vendor in buildah and use as much of commit and bug as possible for podman build and commit. Resolves #586 Signed-off-by: baude <bbaude@redhat.com> Closes: #681 Approved by: mheon
* README: Link to CONTRIBUTING.mdW. Trevor King2018-04-27
| | | | | | | | | | | | | | | | Make that information more easily discoverable. And since CONTRIBUTING.md already mentions IRC, we can drop the IRC reference from the README to DRY things up. Also update CONTRIBUTING.md to replace the stale #cri-o reference left over from the initial libpod/podman fork. While I was touching this line, I also shuffled some of the wording around to tighten that sentence up. Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #687 Approved by: rhatdan
* Remove systemd-cat supportJhon Honce2018-04-27
| | | | | | | | | - CI does not support systemd-cat Signed-off-by: Jhon Honce <jhonce@redhat.com> Closes: #683 Approved by: rhatdan
* Refactor unittest for varlink componentJhon Honce2018-04-27
| | | | | | | | | | | | - Allow unittest's to run as normal user - Refactor tests to use unittest features - Refactor tests to use fixtures to track resources - Update test runner script to clean up on failure Signed-off-by: Jhon Honce <jhonce@redhat.com> Closes: #683 Approved by: rhatdan
* Update .gitignore for python workJhon Honce2018-04-27
| | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com> Closes: #683 Approved by: rhatdan
* Modify secrets pkgumohnani82018-04-27
| | | | | | | | | | | Made a mistake in my earlier patch. I though that if you add an empty string to an array, the length of the array would still be 0... Realised this when vendoring the secrets pkg into cri-o. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #685 Approved by: mheon
* varlink imagesbaude2018-04-26
| | | | | | | | | | | | | implement varlink image functions for working with libpod with the exception of a couple due to incompletions on the libpod side of things (build). also, created a first pass at a libpodpy package which will stand as a client to working with libpod's varlink methods using python. Signed-off-by: baude <bbaude@redhat.com> Closes: #669 Approved by: baude
* Retrieve IP addresses for container from DBMatthew Heon2018-04-26
| | | | | | | | | | Instead of execing out to the host's IP, use the IP address we got back from CNI to populate Inspect's IP address information. Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #680 Approved by: umohnani8
* Add --default-mounts-file hidden flagumohnani82018-04-26
| | | | | | | | | | | The hidden flag is used to override the path of the default mounts file for testing purposes. Also modified the secrets pkg to allow for this override to happen. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #678 Approved by: mheon
* Add isolation note to build man pageTomSweeneyRedHat2018-04-26
| | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #677 Approved by: rhatdan
* Modify man pages so they compile correctly in mandbDaniel J Walsh2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes an issue where if you did man -k podman-run podman-run (1) - (unknown subject) Now you will see man -k podman-run podman-run (1) - Run a command in a new container More importantly man -k containers | grep podman podman (1) - Simple management tool for containers and images podman-kill (1) - Kills one or more containers with a signal podman-pause (1) - Pause one or more containers podman-ps (1) - Prints out information about containers podman-rm (1) - Remove one or more containers podman-start (1) - Start one or more containers podman-stats (1) - Display a live stream of 1 or more containers' resource usage statistics podman-stop (1) - Stop one or more containers podman-unpause (1) - Unpause one or more containers podman-wait (1) - Waits on one or more containers to stop and prints exit code Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #676 Approved by: mheon
* Strip transport from image name when looking for local imagebaude2018-04-26
| | | | | | | | | | | When a user pulls an image using a transport, like docker-daemon, we try to lookup the new image in storage by the input name after the pull. Because the input name has a transport (different than local storage), that lookup would fail. Signed-off-by: baude <bbaude@redhat.com> Closes: #644 Approved by: rhatdan
* Merge pull request #674 from TomasTomecek/readme-fix-formattingDaniel J Walsh2018-04-26
|\ | | | | readme: improve formatting, add links
| * readme: improve formatting, add linksTomas Tomecek2018-04-26
|/ | | | Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
* updated epoch for bad dcobaude2018-04-25
| | | | | | | Signed-off-by: baude <bbaude@redhat.com> Closes: #673 Approved by: mheon
* Only generate the varlink glue code if needed and from the vendor dirHarald Hoyer2018-04-25
| | | | | Closes: #671 Approved by: baude
* Latest revendoring deleted the cmd dir in varlinkbaude2018-04-25
| | | | | | | Signed-off-by: baude <bbaude@redhat.com> Closes: #672 Approved by: baude
* Remove more Errorf in favor of WrapfMatthew Heon2018-04-25
| | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #668 Approved by: rhatdan
* Do not eat error messages from pullImageMatthew Heon2018-04-25
| | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com> Closes: #668 Approved by: rhatdan
* Updated varlink vendored codebaude2018-04-25
| | | | | | | Signed-off-by: baude <bbaude@redhat.com> Closes: #670 Approved by: mheon