summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* stats: list all running containers unless specified otherwiseValentin Rothberg2019-10-23
| | | | | | | | | | Unless specified otherwise by --all, --latest or via arguments, list all running containers. This matches the behaviour of Docker and is also illustrated in the man pages where containers and options are marked to be optional. Fixes: #4274 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #4321 from baude/readthedocsinitOpenShift Merge Robot2019-10-22
|\ | | | | Initial checking for readthedocs
| * Initial checking for readthedocsbaude2019-10-22
|/ | | | Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #4287 from mheon/anonymous_volumesOpenShift Merge Robot2019-10-22
|\ | | | | Add support for anonymous volumes to `podman run -v`
| * Add support for anonymous volumes to `podman run -v`Matthew Heon2019-10-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when `podman run` encountered a volume mount without separate source and destination (e.g. `-v /run`) we would assume that both were the same - a bind mount of `/run` on the host to `/run` in the container. However, this does not match Docker's behavior - in Docker, this makes an anonymous named volume that will be mounted at `/run`. We already have (more limited) support for these anonymous volumes in the form of image volumes. Extend this support to allow it to be used with user-created volumes coming in from the `-v` flag. This change also affects how named volumes created by the container but given names are treated by `podman run --rm` and `podman rm -v`. Previously, they would be removed with the container in these cases, but this did not match Docker's behaviour. Docker only removed anonymous volumes. With this patch we move to that model as well; `podman run -v testvol:/test` will not have `testvol` survive the container being removed by `podman rm -v`. The sum total of these changes let us turn on volume removal in `--rm` by default. Fixes: #4276 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #4299 from stevengubler/masterOpenShift Merge Robot2019-10-22
|\ \ | | | | | | Markdown Formatting Fixes
| * | Markdown Formatting FixesSteven Gubler2019-10-18
| | | | | | | | | | | | Signed-off-by: Steven Gubler <stevegubler@protonmail.com>
* | | Merge pull request #4313 from haircommander/unused-varOpenShift Merge Robot2019-10-22
|\ \ \ | | | | | | | | exec: remove unused var
| * | | exec: remove unused varPeter Hunt2019-10-21
| | | | | | | | | | | | | | | | Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | Merge pull request #4284 from mheon/fix_vol_inspectOpenShift Merge Robot2019-10-21
|\ \ \ \ | | | | | | | | | | Show volume options in 'volume inspect'
| * | | | Rewrite backend for remote 'volume inspect'Matthew Heon2019-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to use the new Inspect() endpoint instead of trying to JSON the actual volume structs. Currently, the output seems completely nonsensical; it seems like we're JSONing the struct for the Varlink connection itself? This should restore sanity and match the format of remote and local inspect on volumes. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Show volume options in 'volume inspect'Matthew Heon2019-10-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We initialized the map to show them, but didn't actually copy them in, so they weren't being displayed. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #4309 from giuseppe/write-storage-overridesOpenShift Merge Robot2019-10-21
|\ \ \ \ \ | | | | | | | | | | | | rootless: write storage overrides to the conf file
| * | | | | rootless: write storage overrides to the conf fileGiuseppe Scrivano2019-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sure the user overrides are stored in the configuration file when first created. Closes: https://github.com/containers/libpod/issues/2659 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #4125 from baude/remotestdinOpenShift Merge Robot2019-10-20
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Add ability to redirect bash for run -i
| * | | | | Add ability to redirect bash for run -ibaude2019-10-15
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #4297 from cnbattle/masterOpenShift Merge Robot2019-10-18
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | README.md update latest version to 1.6.2
| * | | | | Merge pull request #4292 from mheon/bump-1.6.2OpenShift Merge Robot2019-10-18
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bump to v1.6.2 Signed-off-by: cnbattle <qiaicn@gmail.com>
* | \ \ \ \ \ Merge pull request #4269 from giuseppe/do-not-set-lingering-mode-by-defaultOpenShift Merge Robot2019-10-18
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | rootless: do not enable lingering mode
| * | | | | | | troubleshooting.md: document lingering modeGiuseppe Scrivano2019-10-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | | | | rootless: do not enable lingering modeGiuseppe Scrivano2019-10-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | do not automatically enable lingering mode. Closes: https://github.com/containers/libpod/issues/4224 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | | | Merge pull request #4241 from haircommander/kube-test-refactorOpenShift Merge Robot2019-10-18
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | play kube: refactor test suite
| * | | | | | | | play kube: Container->CtrPeter Hunt2019-10-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for berevity Signed-off-by: Peter Hunt <pehunt@redhat.com>
| * | | | | | | | play kube: refactor test suitePeter Hunt2019-10-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The play kube test suite has many different cases to cover, and should only grow in coverage over time The old design was difficult to extend, and there was lots of duplicated code. The largest pain point was the Container struct needed to be changed often, and doing so caused changes every test case Instead, adopt the `withOption` idiom. Now, adding a new option for customizing just involves adding a new withOption function, and changing the struct definition and initialization in one place. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | | | | | | Merge pull request #4282 from chuanchang/bz1731117OpenShift Merge Robot2019-10-18
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / |/| | | | | | | | System tests: make sure exec pid hash w/o leaking
| * | | | | | | | System tests: make sure exec pid hash w/o leakingAlex Jia2019-10-18
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman exec leaks an exec_pid_<hash> file for every exec in tmpfs, it's known rhbz#1731117, this case makes sure leakage issue has been fixed. rhbz: https://bugzilla.redhat.com/show_bug.cgi?id=1731117 Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
* | | | | | | | Merge pull request #4292 from mheon/bump-1.6.2OpenShift Merge Robot2019-10-17
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | / / / / | | |_|/ / / / | |/| | | | | Bump to v1.6.2
| * | | | | | Bump gitvalidation epochMatthew Heon2019-10-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | | | Bump to v1.6.3-devMatthew Heon2019-10-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | | | Bump to v1.6.2v1.6.2Matthew Heon2019-10-17
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | Merge pull request #4290 from mheon/release_notes_1.6.2_finalOpenShift Merge Robot2019-10-17
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Finalize release notes for v1.6.2
| * | | | | Finalize release notes for v1.6.2Matthew Heon2019-10-17
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #4271 from tylarb/stdin_attachOpenShift Merge Robot2019-10-17
|\ \ \ \ \ | |_|_|_|/ |/| | | | Attach to container if it was created with --interactive
| * | | | Attach stdin to container at start if it was created with --interactiveTyler Ramer2019-10-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check to see if the container's start config includes the interactive flag when determining to attach or ignore stdin stream. This is in line with behavior of Docker CLI and engine Signed-off-by: Tyler Ramer <tyaramer@gmail.com>
* | | | | Merge pull request #4199 from jwhonce/wip/exit_with_errorOpenShift Merge Robot2019-10-17
|\ \ \ \ \ | | | | | | | | | | | | Refactor tests when checking for error exit codes
| * | | | | Refactor tests when checking for error exit codesJhon Honce2019-10-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than checking for non-zero, we need to check for >0 to distinguish between timeouts and error exit codes. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | Merge pull request #4279 from giuseppe/rootless-drop-dep-dockerOpenShift Merge Robot2019-10-17
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | rootless: drop dependency on docker
| * | | | | rootless: drop dependency on dockerGiuseppe Scrivano2019-10-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use the definition from "golang.org/x/sys/unix". Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #4280 from mheon/bump-1.6.2-rc1OpenShift Merge Robot2019-10-16
|\ \ \ \ \ \ | | | | | | | | | | | | | | Bump to v1.6.2-RC1
| * | | | | | Bump gitvalidation epochMatthew Heon2019-10-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | | | Bump to v1.6.2-devMatthew Heon2019-10-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | | | Bump to v1.6.2-rc1v1.6.2-rc1Matthew Heon2019-10-16
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | Merge pull request #4278 from mheon/release_notes_1.6.2OpenShift Merge Robot2019-10-16
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add release notes for Podman 1.6.2
| * | | | | Add release notes for Podman 1.6.2Matthew Heon2019-10-16
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #4270 from dasmfm/podman-start-fixOpenShift Merge Robot2019-10-16
|\ \ \ \ \ | |/ / / / |/| | | | Fix output message for "podman start" command.
| * | | | start: print full container IDbklimenko2019-10-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now the "podman start" command prints the full ID and has the same behaviour as other commands. Signed-off-by: Boris Klimenko <2@borisklimenko.ru>
* | | | | Merge pull request #4273 from mheon/no_runtimeOpenShift Merge Robot2019-10-16
|\ \ \ \ \ | | | | | | | | | | | | Add a MissingRuntime implementation
| * | | | | Add a MissingRuntime implementationMatthew Heon2019-10-15
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a container is created with a given OCI runtime, but then it is uninstalled or removed from the configuration file, Libpod presently reacts very poorly. The EvictContainer code can potentially remove these containers, but we still can't see them in `podman ps` (aside from the massive logrus.Errorf messages they create). Providing a minimal OCI runtime implementation for missing runtimes allows us to behave better. We'll be able to retrieve containers from the database, though we still pop up an error for each missing runtime. For containers which are stopped, we can remove them as normal. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #4272 from baude/rootlesstatsnetOpenShift Merge Robot2019-10-16
|\ \ \ \ \ | | | | | | | | | | | | rootless v2 cannot collect network stats
| * | | | | rootless v2 cannot collect network statsbaude2019-10-15
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | network statistics cannot be collected for rootless network devices with the current implementation. for now, we return nil so that stats will at least for users. Fixes:#4268 Signed-off-by: baude <bbaude@redhat.com>