summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Do not copy up when volume is not emptyMatthew Heon2020-02-12
| | | | | | | | | | | | | | | | | When Docker performs a copy up, it first verifies that the volume being copied into is empty; thus, for volumes that have been modified elsewhere (e.g. manually copying into then), the copy up will not be performed at all. Duplicate this behavior in Podman by checking if the volume is empty before copying. Furthermore, move setting copyup to false further up. This will prevent a potential race where copy up could happen more than once if Podman was killed after some files had been copied but before the DB was updated. This resolves CVE-2020-1726. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #5143 from stefanb2/topic-pr-4477-2OpenShift Merge Robot2020-02-10
|\ | | | | docs: add workaround for --device with rootless containers (II)
| * docs: add workaround for --device with rootless containers (II)Stefan Becker2020-02-10
| | | | | | | | | | | | | | | | | | | | Update documentation for crun >= 0.11. See https://github.com/containers/crun/commit/6df930821d80a8e151674f0fda1321fba93bb92d Fixes #4477 Signed-off-by: Stefan Becker <chemobejk@gmail.com>
* | Merge pull request #5122 from mtrmac/image-object-creationOpenShift Merge Robot2020-02-10
|\ \ | | | | | | Simplify image object creation
| * | Modify Runtime.getImage to return a storage.ImageMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | ... because both callers only care about that aspect of the return value. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Document an aspect of newFromStorage behaviorMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Introduce a Runtime.newImage constructorMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | ... so that _all_ Image objects are created in a single place that is easy to update. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Move Image.getLocalImage to Runtime.getLocalImageMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of the function updating image.InputName (the only reason for it to need an image), have it return the updated value separately. This will allow simplifying the constructors of Image further. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Remove the getLocalImage() call from Image.SizeMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | All ways to create an Image{} have a non-nil .image field, and it is never set to nil, so this is dead code. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Use Runtime.NewFromLocal instead of open-coded copiesMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | All code creating an Image by looking up a name now uses Runtime.NewFromLocal. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Trivial simplificationMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Create two separate newImage instances in Runtime.NewMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not _trivially_ safe because newImage.getLocalImage() modifies newImage.ImageName, but we overwrite that value anyway. So, this should not change behavior, and it will make future refactoring easier to verify. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Call NewImageRuntimeFromStore from NewImageRuntimeFromOptionsMiloslav Trmač2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | ... so that there ultimately is only one constructor. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | | Merge pull request #5064 from mheon/pod_network_optsOpenShift Merge Robot2020-02-10
|\ \ \ | |_|/ |/| | Add backend code for pod network options
| * | Add backend code for pod network optionsMatthew Heon2020-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds network-related options to the pod in the database. We are going to add the CLI frontend in further patches. In short, this should greatly improve the ability of pods to configure networking, once the CLI parsing is added. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5107 from cevich/mirror_containersOpenShift Merge Robot2020-02-09
|\ \ \ | |_|/ |/| | Add mirroring dockerfiles
| * | Add dockerfile to mirror fedora-minimalChris Evich2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | This is needed to provide this image under quay.io/libpod/ namespace to provide some resiliency to automated testing (should other repositories be unavailable) Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #5129 from mheon/update_release_for_18OpenShift Merge Robot2020-02-07
|\ \ \ | | | | | | | | [CI:DOCS] Update readme to 1.8.0 release
| * | | Update readme to 1.8.0 releaseMatthew Heon2020-02-07
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #5126 from openSUSE/runtime-structOpenShift Merge Robot2020-02-07
|\ \ \ \ | |/ / / |/| | | Refactor runtime functions to pass options structure
| * | | Refactor runtime functions to pass options structureSascha Grunert2020-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the code easier to read but should not change the overall behavior. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | | Merge pull request #5104 from ↵OpenShift Merge Robot2020-02-07
|\ \ \ \ | |/ / / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/image/v5-5.2.1 build(deps): bump github.com/containers/image/v5 from 5.2.0 to 5.2.1
| * | | build(deps): bump github.com/containers/image/v5 from 5.2.0 to 5.2.1dependabot-preview[bot]2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.2.0 to 5.2.1. - [Release notes](https://github.com/containers/image/releases) - [Commits](https://github.com/containers/image/compare/v5.2.0...v5.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #5120 from nalind/varlink-build-idOpenShift Merge Robot2020-02-07
|\ \ \ \ | | | | | | | | | | LibpodAPI.BuildImage: don't require a name for the new image
| * | | | LibpodAPI.BuildImage: don't require a name for the new imageNalin Dahyabhai2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we finish building an image, we try to look up its ID by looking up the image using the name that we were asked to assign to the image. If we weren't asked to assign a name to the image, that would produce an error. The BuildImage() API we're using returns the image's ID anyway, so we can skip the lookup and just return the ID directly. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | | | Merge pull request #5119 from mheon/bump-1.8.0OpenShift Merge Robot2020-02-07
|\ \ \ \ \ | |/ / / / |/| | | | Bump to v1.8.0
| * | | | Bump to v1.8.1-devMatthew Heon2020-02-06
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Bump to v1.8.0v1.8.0Matthew Heon2020-02-06
|/ / / / | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #5118 from baude/podmansystemservicesucks2OpenShift Merge Robot2020-02-06
|\ \ \ \ | | | | | | | | | | [CI:DOCS]update contrib systemd user
| * | | | [CI:DOCS]update contrib systemd userBrent Baude2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | one more update Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5111 from mheon/service_to_system_serviceOpenShift Merge Robot2020-02-06
|\ \ \ \ \ | |/ / / / |/| | | | Move podman-service to podman-system-service
| * | | | Move podman-service to podman-system-serviceMatthew Heon2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #5108 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #5117 from baude/podmansystemservicesucksOpenShift Merge Robot2020-02-06
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS]fix systemd files for apiv2
| * | | | | [CI:DOCS]fix systemd files for apiv2Brent Baude2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the paths and instructions for running the new api via systemd needed updates due to a change in the command. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5116 from mheon/release_notes_1.8.0_finalOpenShift Merge Robot2020-02-06
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [CI:DOCS] Update release notes for final release of v1.8.0
| * | | | | Update release notes for final release of v1.8.0Matthew Heon2020-02-06
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #5099 from mheon/fix_pod_cgroup_pidsOpenShift Merge Robot2020-02-06
|\ \ \ \ \ | |/ / / / |/| | | | Only modify conmon cgroup if we have running containers
| * | | | Only modify conmon cgroup if we have running containersMatthew Heon2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If there are no running containers - for example, if the pod was just created - the cgroup in question may not exist (under certain circumstances that we're not 100% sure about). However, regardless, we don't need to set a PID limit, as nothing will be making cleanup processes (no running conmon processes), so not changing the cgroup is safe regardless. Fixes #5072 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #5098 from rhatdan/memory-swapOpenShift Merge Robot2020-02-06
|\ \ \ \ \ | | | | | | | | | | | | Special case memory-swap=-1
| * | | | | Special case memory-swap=-1Daniel J Walsh2020-02-05
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | We document that memory-swap==-1 means unlimited, but currently we won't allow the user to specify the -1 value. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #5048 from TomSweeneyRedHat/dev/tsweeney/install.mdOpenShift Merge Robot2020-02-06
|\ \ \ \ \ | |_|_|/ / |/| | | | Move install.md to podman.io, leave link page
| * | | | Move install.md to podman.io, leave link pageTomSweeneyRedHat2020-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The installation instructions for podman were on this site and a second copy on podman.io. I've created https://github.com/containers/podman.io/pull/193 which has a merging of the installation instructions from both sites. Since the one on podman.io was created a few months ago, we've had a number of divergences. Maintaining only one copy should assist with that problem plus make it easier for people updating them. This PR should NOT be merged before the one in podman.io. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | | Merge pull request #5089 from baude/fixswaggeraddvalidateOpenShift Merge Robot2020-02-05
|\ \ \ \ \ | | | | | | | | | | | | fix swagger docs and make sure docs validation runs
| * | | | | fix swagger docs and make sure docs validation runsBrent Baude2020-02-05
| | |_|/ / | |/| | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5056 from ↵OpenShift Merge Robot2020-02-05
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.12.0 build(deps): bump github.com/onsi/ginkgo from 1.11.0 to 1.12.0
| * | | | build(deps): bump github.com/onsi/ginkgo from 1.11.0 to 1.12.0dependabot-preview[bot]2020-02-04
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.11.0...v1.12.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #5062 from vrothberg/update-imageOpenShift Merge Robot2020-02-05
|\ \ \ \ | | | | | | | | | | vendor github.com/containers/image/v5@v5.2.0
| * | | | vendor github.com/mtrmac/gpgme@v0.1.2Valentin Rothberg2020-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a build regression on CentOS 7 and RHEL 7 with older gpgme versions. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | vendor github.com/containers/image/v5@v5.2.0Valentin Rothberg2020-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See release notes: https://github.com/containers/image/releases/tag/v5.2.0 Fixes: #4877 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #5090 from openSUSE/containerfile-location-testOpenShift Merge Robot2020-02-05
|\ \ \ \ \ | | | | | | | | | | | | Add Containerfile location e2e test
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-29 14:46:33 +0000