summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix issue with order of flagsumohnani82018-01-25
| | | | | | | | | | The order of the flags was casuing issue. Enabled SkipArgReorder to fix the problem. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #259 Approved by: rhatdan
* Merge pull request #252 from baude/portDaniel J Walsh2018-01-24
|\ | | | | podman port
| * podman portbaude2018-01-23
| | | | | | | | | | | | | | | | | | | | | | podman port reports the port mappings per container. it can be used to report the ports ofa single container or latest container or all containers. in the case of a single container, the user can add an option filter for port and protocol. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #251 from baude/psbatchDaniel J Walsh2018-01-23
|\ \ | | | | | | Use batched operations in ps
| * | Use batched operations in psbaude2018-01-22
| | | | | | | | | | | | | | | | | | | | | | | | Because the podman ps command has to collection a lot of information from various places, many of which are controlled by locks, it is a good candidate for doing batch operations under a single lock. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #256 from baude/imageperfDaniel J Walsh2018-01-23
|\ \ \ | | | | | | | | Streamline image resolution
| * | | Streamline image resolutionbaude2018-01-23
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | When trying to determine if a user-provided string that describes an image (ID, fq name, shortname, tagged), there were some inefficiencies where we looked up images multiple times to derive information about local images. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #224 from ypu/import_testDaniel J Walsh2018-01-23
|\ \ \ | |/ / |/| | Update podman_import test to use podman
| * | Update podman_import test to use podmanYiqiao Pu2018-01-23
| | | | | | | | | | | | | | | | | | | | | Update the podman_import test to use podman run, and update the check method for string check method. Signed-off-by: Yiqiao Pu <ypu@redhat.com>
* | | libpod/oci.go: Perf issuebaude2018-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Matt Heon and I found that a defer statement was costing podman run dearly. We dont think the defer function was working (nor needed) and was timing out as well. Removing this defer statement decreased podman runtime by 1.5s or more. Signed-off-by: baude <bbaude@redhat.com> Closes: #253 Approved by: baude
* | | Fix issues with podman ps from QEumohnani82018-01-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QE pointed out a few things missing/wrong with ps This PR addresses those issues. Added functionality for getting mounts and size also Fixed a few issues with the --filter params, for example filter with partial information. Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #250 Approved by: rhatdan
* | | Expose ports from imagebaude2018-01-22
| |/ |/| | | | | | | | | | | | | | | | | | | | | When an image has a port to expose, we need to expose it. User's input overrides the image's port information. Also, enable port information in ps so we can see which random port is assigned. Signed-off-by: baude <bbaude@redhat.com> Closes: #249 Approved by: rhatdan
* | Override hostname for containerbaude2018-01-21
| | | | | | | | | | | | | | | | | | | | | | Adds the ability to override the container's hostname. Also, uses the first twelve characters of the container ID as the default hostname if none is provided. Signed-off-by: baude <bbaude@redhat.com> Closes: #248 Approved by: baude
* | Enable port bindingsbaude2018-01-20
| | | | | | | | | | | | | | | | | | | | | | | | | | Set up nbetworking ports for the following use cases: * bind the same port between host and container * bind a specific host port to a different container port * bind a random host port to a specific container port Signed-off-by: baude <bbaude@redhat.com> Closes: #214 Approved by: baude
* | Touchup build to add missing -q flagTomSweeneyRedHat2018-01-20
| | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #247 Approved by: rhatdan
* | Add dns testsbaude2018-01-19
| | | | | | | | | | | | | | | | | | | | In the dns commit, tests were accidently omitted due to a rebase against master. Signed-off-by: baude <bbaude@redhat.com> Closes: #245 Approved by: baude
* | Cleanup of podman statsDaniel J Walsh2018-01-19
| | | | | | | | | | | | | | | | | | | | | | | | Fix errors when containers are not running. --all, --latest, containers can not be used at same time. Should match the output of docker stats, 0 values replaced by "--" Should return stats right away if container is not running. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #244 Approved by: TomSweeneyRedHat
* | Add --dns-search, --dns-opt, --dns-server and --add-host.baude2018-01-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Each of these options are destructive in nature, meaning if the user adds one of them, all current ones are removed from the produced resolv.conf. * dns-server allows the user to specify dns servers. * dns-opt allows the user to specify special resolv.conf options * dns-search allows the user to specify search domains The add-host option is not destructive and truly just adds the host to /etc/hosts. Signed-off-by: baude <bbaude@redhat.com> Closes: #231 Approved by: mheon
* | Set NOTEST variable to skip tests in paprbaude2018-01-19
| | | | | | | | | | | | | | | | | | | | | | | | The papr test with ansible is really handy for setting up test nodes. However, most of the time you want to run the tests manually, specifically the integration tests. Passing NOTEST=1 will allow you to skip gofmt, lint, and friends and will exit before the integration tests. Signed-off-by: baude <bbaude@redhat.com> Closes: #242 Approved by: mheon
* | Touchup README.md and fix whitespace issuesTomSweeneyRedHat2018-01-19
| | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #243 Approved by: mheon
* | Merge pull request #240 from mheon/refactor_containerDaniel J Walsh2018-01-18
|\ \ | | | | | | Refactor container.go
| * | Fix gofmtMatthew Heon2018-01-18
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * | Rename containerRuntimeInfo to containerState for clarityMatthew Heon2018-01-18
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * | Rename ContainerState to ContainerStatusMatthew Heon2018-01-18
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * | Split container.go into three filesMatthew Heon2018-01-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Weighing in at ~1700 lines, container.go is just too big. Split it into three files: core structs and accessors (container.go), public API (container_api.go), and internal functions (container_internal.go). Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
* | | Merge pull request #216 from rhatdan/dockerDaniel J Walsh2018-01-18
|\ \ \ | | | | | | | | Add support for mimicing docker CLI
| * | | Add support for mimicing docker CLIDaniel J Walsh2018-01-18
| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #230 from TomSweeneyRedHat/dev/tsweeney/readmeDaniel J Walsh2018-01-18
|\ \ \ \ | | | | | | | | | | Slim down README.md and make tutorials page
| * | | | Slim down README.md and make tutorials pageTomSweeneyRedHat2018-01-17
| |/ / / | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Fix output for created containersbaude2018-01-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Created containers that haven't hit runc yet should still be considered created (not dead). Also, fixed loop for deleting containers as leftover code still exited there that prevented proper deletion of containers that could be deleted. Signed-off-by: baude <bbaude@redhat.com> Closes: #238 Approved by: rhatdan
* | | | Fix test syntaxbaude2018-01-18
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Remove the use of bash -c unless it involves a bash pipe. Also, use run test_runner.sh inside script so that centos can be happy. Signed-off-by: baude <bbaude@redhat.com> Closes: #239 Approved by: baude
* | | Fix seccomp supportDaniel J Walsh2018-01-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If user does not specify seccomp file or seccomp file does not exist, then use the default seccomp settings. Still need to not hard code /etc/crio/seccomp.json, should move this to /usr/share/seccomp/seccomp.json Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #233 Approved by: baude
* | | ETCDIR should be relative to DESTDIRDaniel J Walsh2018-01-17
|/ / | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #237 Approved by: rhatdan
* | Fix gofmtMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Fix in-memory state testsMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Convert remaining state tests to new styleMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Add ability to get dependencies of a containerMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Fix comment typoMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Fix gofmtMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Address review commentsMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Wire in logic for selecting backing state implMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Do no lint test helpersMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Modify unit tests for state to run on all state implementationsMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Change handling for pods in libpod stateMatthew Heon2018-01-17
| | | | | | | | | | | | | | | | | | | | Add new functions to update pods and add/remove containers from them Use these new functions in place of manually modifying pods Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Add ability to retrieve a pod's container from the stateMatthew Heon2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #229 Approved by: rhatdan
* | Add check for successful imageData callDaniel J Walsh2018-01-17
| | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #234 Approved by: baude
* | Remove --storage-opt from podman run/createDaniel J Walsh2018-01-17
| | | | | | | | | | | | | | | | | | | | | | podman command has storage options as a global option, these should be set there, rather then in the create and run commands. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #234 Approved by: baude
* | test/podman_networking.bats: kpod to podmanbaude2018-01-17
| | | | | | | | | | | | | | | | | | this test was still referring to KPOD_BINARY and not podman Signed-off-by: baude <bbaude@redhat.com> Closes: #235 Approved by: baude
* | switch to bats-corebaude2018-01-16
| | | | | | | | | | | | | | | | | | | | | | it seems the original bats project is deprecated and bats-core is an active fork of it. we dont have packages in distributions but will build from source. Signed-off-by: baude <bbaude@redhat.com> Closes: #232 Approved by: baude
* | Ensure batched containers have locksMatthew Heon2018-01-16
| | | | | | | | | | | | | | | | | | | | | | This won't matter during batched operatins, but if the container leaks outside of the Batch() function it will segfault if asked to do any operation that locks unless this is applied Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #226 Approved by: rhatdan