summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #6865 from vrothberg/2.0-v2-moduleOpenShift Merge Robot2020-07-06
|\ | | | | [2.0] move go module to v2
| * move go module to v2Valentin Rothberg2020-07-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the advent of Podman 2.0.0 we crossed the magical barrier of go modules. While we were able to continue importing all packages inside of the project, the project could not be vendored anymore from the outside. Move the go module to new major version and change all imports to github.com/containers/libpod/v2. The renaming of the imports was done via gomove [1]. [1] https://github.com/KSubedi/gomove Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #6860 from rhatdan/v2.0OpenShift Merge Robot2020-07-06
|\ \ | |/ |/| Vendor containers/common v0.14.4
| * Vendor containers/common v0.14.4Daniel J Walsh2020-07-06
|/ | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #6849 from TomSweeneyRedHat/dev/tsweeney/ib_v1.1.6_v2OpenShift Merge Robot2020-07-06
|\ | | | | Bump to imagebuilder v1.1.6 on v2 branch
| * Bump to imagebuilder v1.1.6 on v2 branchTomSweeneyRedHat2020-07-02
|/ | | | | | | | As the title says. Addresses: https://github.com/containers/buildah/issues/2424 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* Merge pull request #6802 from lsm5/v2.0-registry-port-numberOpenShift Merge Robot2020-06-29
|\ | | | | Account for non-default port number in image name (backported from master)
| * Account for non-default port number in image nameLokesh Mandvekar2020-06-27
|/ | | | | | | | | | | | | | | Previously, if an image was tagged with the format $REGISTRY:$PORT/$REPO:$TAG, then `podman images` would display $PORT/$REPO:$TAG under the "TAG" field. This commit correctly displays $REGISTRY:$PORT/$REPO under the "REPOSITORY" field while the "TAG" field only displays $TAG. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Fixes: gh#6665 (cherry picked from commit 71f6dd47ddce82545865739cb3382c0beb3f65a4)
* Merge pull request #6792 from baude/2.0swaggerOpenShift Merge Robot2020-06-26
|\ | | | | [CI:DOCS]Add swagger.yaml to docs/
| * [CI:DOCS]Add swagger.yaml to docs/Brent Baude2020-06-26
|/ | | | | | Adding the swagger.yaml to the docs directory so that we can version the read-the-docs API information. also, change the links to be relative in nature and point to the new swagger. Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #6782 from mheon/bump_201OpenShift Merge Robot2020-06-25
|\ | | | | [CI:DOCS] Bump to v2.0.1
| * Bump to v2.0.2-devMatthew Heon2020-06-25
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v2.0.1v2.0.1Matthew Heon2020-06-25
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #6780 from mheon/even_more_201_backportsOpenShift Merge Robot2020-06-25
|\ | | | | Even more v2.0.1 backports
| * Update release notes with further v2.0.1 changesMatthew Heon2020-06-25
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Fix inspect to display multiple label: changesDaniel J Walsh2020-06-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the user runs a container like podman run --security-opt seccomp=unconfined --security-opt label=type:spc_t --security-opt label=level:s0 ... Podman inspect was only showing the second option This change will show "SecurityOpt": [ "label=type:spc_t,label=level:s0:c60", "seccomp=unconfined" ], Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Set syslog for exit commands on log-level=debugMatthew Heon2020-06-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have a flag, --syslog, for telling logrus to log to syslog as well as to the terminal. Previously, this flag also set the exit command for containers to use `--syslog` (otherwise all output from exit commands is lost). I attempted to replicate this with Podman v2.0, but quickly ran into circular import hell (the flag is defined in cmd/podman, I needed it in cmd/podman/containers, cmd/podman imports cmd/podman/containers already, etc). Instead, let's just set the syslog flag automatically on `--log-level=debug` so we log exit commands automatically when debug-level logs are requested. This is consistent with Conmon and seems to make sense. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Friendly amendment for pr 6751Ed Santiago2020-06-25
| | | | | | | | | | | | More robust system test for podman run/create docker-archive Signed-off-by: Ed Santiago <santiago@redhat.com>
| * podman run/create: support all transportsValentin Rothberg2020-06-25
| | | | | | | | | | | | | | | | | | Support all image transports in podman run/create. It seems we regressed with v2 on that. Also add tests to make sure we're not regressing again. Fixes: #6744 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * systemd generate: allow manual restart of container units in podsValentin Rothberg2020-06-25
| | | | | | | | | | | | | | | | Allow manual restarts of container units that are part of a pod. This allows for configuring these containers for auto updates. Fixes: #6770 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Revert sending --remote flag to containersJhon Honce2020-06-25
| | | | | | | | | | | | * quick --remote fix, sent --remote to ctnrs as argument Signed-off-by: Jhon Honce <jhonce@redhat.com>
| * Print port mappings in `ps` for ctrs sharing networkMatthew Heon2020-06-25
|/ | | | | | | | | In Podman v1.9, we printed port mappings for the container, even if it shared its network namespace (and thus ports) with another container. We regressed on this in Podman v2.0, which is fixed here. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #6776 from vrothberg/2.0-vendor-commonOpenShift Merge Robot2020-06-25
|\ | | | | [2.0] vendor github.com/containers/common@v0.14.3
| * vendor github.com/containers/common@v0.14.3Valentin Rothberg2020-06-25
|/ | | | | | Includes several fixes for config parsing and AppArmor. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6758 from mheon/v2.0.1_backportsOpenShift Merge Robot2020-06-24
|\ | | | | V2.0.1 backports
| * Update release notes for v2.0.1Matthew Heon2020-06-24
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * utils: drop default mapping when running uid!=0Giuseppe Scrivano2020-06-24
| | | | | | | | | | | | | | | | | | | | this is a leftover from the first implementation of rootless. This code is never hit by podman rootless anymore as podman automatically creates a user namespace now. Fixes an issue with podman remote when used with uid != 0. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * Set stop signal to 15 when not explicitly setMatthew Heon2020-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When going through the output of `podman inspect` to try and identify another issue, I noticed that Podman 2.0 was setting StopSignal to 0 on containers by default. After chasing it through the command line and SpecGen, I determined that we were actually not setting a default in Libpod, which is strange because I swear we used to do that. I re-added the disappeared default and now all is well again. Also, while I was looking for the bug in SpecGen, I found a bunch of TODOs that have already been done. Eliminate the comments for these. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * podman untag: error if tag doesn't existValentin Rothberg2020-06-24
| | | | | | | | | | | | | | | | | | | | | | Throw an error if a specified tag does not exist. Also make sure that the user input is normalized as we already do for `podman tag`. To prevent regressions, add a set of end-to-end and systemd tests. Last but not least, update the docs and add bash completions. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Reformat inspect network settingsQi Wang2020-06-24
| | | | | | | | | | | | Reformat ports of inspect network settings to compatible with docker inspect. Close #5380 Signed-off-by: Qi Wang <qiwan@redhat.com>
| * APIv2: Return `StatusCreated` from volume creationmaybe-sybr2020-06-24
| | | | | | | | | | | | | | | | The swagdoc in `register_volumes.go` already correctly notes that a 201 should be returned upon success, so we only need to change the handler to match the spec. Signed-off-by: Matt Brindley <58414429+maybe-sybr@users.noreply.github.com>
| * APIv2:fix: Remove `/json` from compat network EPsmaybe-sybr2020-06-24
| | | | | | | | Signed-off-by: Matt Brindley <58414429+maybe-sybr@users.noreply.github.com>
| * Fix ssh-agent supportJhon Honce2020-06-24
| | | | | | | | | | | | | | * An identity of "" implies ssh-agent and user/password to be used * Fixed example Signed-off-by: Jhon Honce <jhonce@redhat.com>
| * libpod: specify mappings to the storageGiuseppe Scrivano2020-06-24
| | | | | | | | | | | | | | | | | | | | | | | | specify the mappings in the container configuration to the storage when creating the container so that the correct mappings can be configured. Regression introduced with Podman 2.0. Closes: https://github.com/containers/libpod/issues/6735 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * APIv2:doc: Fix swagger doc to refer to volumesmaybe-sybr2020-06-24
| | | | | | | | Signed-off-by: Matt Brindley <58414429+maybe-sybr@users.noreply.github.com>
| * Add podman network to bash command completionsDaniel J Walsh2020-06-24
| | | | | | | | | | | | network commands were not supported in command completions. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Fix typo in manpage for `podman auto update`.Peter Oliver2020-06-24
| | | | | | | | Signed-off-by: Peter Oliver <git@mavit.org.uk>
| * Add JSON output field for psBrent Baude2020-06-24
| | | | | | | | | | | | the toolbox team needs a field in our ps json that represents a human readable time. Signed-off-by: Brent Baude <bbaude@redhat.com>
| * V2 podman system connectionJhon Honce2020-06-24
| | | | | | | | | | | | | | | | | | * Implement command * Refactor podman-remote to pull from containers.conf by default * podman-remote defaults to --remote being true * Write podman-system-connection.1.md Signed-off-by: Jhon Honce <jhonce@redhat.com>
| * wipBrent Baude2020-06-24
| | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
| * image load: no args requiredValentin Rothberg2020-06-24
| | | | | | | | | | | | | | | | | | Disable the args requirement of `image load`. Instead of requiring a lower bound, we really need an upper one with at most 1 argument. Extend the system tests to prevent future regressions. Fixes: #6718 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Re-add PODMAN_USERNS environment variableMatthew Heon2020-06-24
| | | | | | | | | | | | | | | | | | | | This was lost during the Podman 2.0 migration. Turns out to be a very easy fix, fortunately - we want to use the environment var if not explicitly overridden. Fixes #6705 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Fix conflicts between privileged and other flagsMatthew Heon2020-06-24
| | | | | | | | | | | | | | | | The `--privileged` flag does not conflict with `--group-add` (this one was breaking Toolbox) and does not conflict with most parts of `--security-opt` (this was breaking Openstack). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Bump required go version to 1.13Ralf Haferkamp2020-06-24
| | | | | | | | | | | | | | | | | | Recent versions of libpod use features from github.com/pkg/errors that are only available when building with go 1.13 or newer. Closes #6708 Signed-off-by: Ralf Haferkamp <rhafer@suse.com>
| * Add explicit command to alpine container in test case.jgallucci322020-06-24
| | | | | | | | Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
| * Use POLL_DURATION for timerjgallucci322020-06-24
| | | | | | | | Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
| * Stop following logs using timersjgallucci322020-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This incorporates code from PR #6591 and #6614 but does not use event channels to detect container state and rather uses timers with a defined wait duration before calling t.StopAtEOF() to ensure the last log entry is output before a container exits. The polling interval is set to 250 milliseconds based on polling interval defined in hpcloud/tail here: https://github.com/hpcloud/tail/blob/v1.0.0/watch/polling.go#L117 Co-authored-by: Qi Wang <qiwan@redhat.com> Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
| * "pod" was being truncated to "po" in the names of the generated systemd unit ↵Gavin Campbell2020-06-24
| | | | | | | | | | | | | | | | files. s/po/pod Signed-off-by: Gavin Campbell <gavin@gavincampbell.dev>
| * rootless_linux: improve error messageDouglas Schilling Landgraf2020-06-24
| | | | | | | | | | | | | | Improve the error message for rootless mode. Git-Url: https://github.com/containers/libpod/issues/6572 Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
| * Fix podman build handling of --http-proxy flagDaniel J Walsh2020-06-24
| | | | | | | | | | | | Also fixed a todo for handling of cgroup manager while I was in there. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>