summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* wipBrent Baude2020-06-24
| | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* image load: no args requiredValentin Rothberg2020-06-24
| | | | | | | | | Disable the args requirement of `image load`. Instead of requiring a lower bound, we really need an upper one with at most 1 argument. Extend the system tests to prevent future regressions. Fixes: #6718 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Re-add PODMAN_USERNS environment variableMatthew Heon2020-06-24
| | | | | | | | | | This was lost during the Podman 2.0 migration. Turns out to be a very easy fix, fortunately - we want to use the environment var if not explicitly overridden. Fixes #6705 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Fix conflicts between privileged and other flagsMatthew Heon2020-06-24
| | | | | | | | The `--privileged` flag does not conflict with `--group-add` (this one was breaking Toolbox) and does not conflict with most parts of `--security-opt` (this was breaking Openstack). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Bump required go version to 1.13Ralf Haferkamp2020-06-24
| | | | | | | | | Recent versions of libpod use features from github.com/pkg/errors that are only available when building with go 1.13 or newer. Closes #6708 Signed-off-by: Ralf Haferkamp <rhafer@suse.com>
* Add explicit command to alpine container in test case.jgallucci322020-06-24
| | | | Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
* Use POLL_DURATION for timerjgallucci322020-06-24
| | | | Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
* Stop following logs using timersjgallucci322020-06-24
| | | | | | | | | | | | | | This incorporates code from PR #6591 and #6614 but does not use event channels to detect container state and rather uses timers with a defined wait duration before calling t.StopAtEOF() to ensure the last log entry is output before a container exits. The polling interval is set to 250 milliseconds based on polling interval defined in hpcloud/tail here: https://github.com/hpcloud/tail/blob/v1.0.0/watch/polling.go#L117 Co-authored-by: Qi Wang <qiwan@redhat.com> Signed-off-by: jgallucci32 <john.gallucci.iv@gmail.com>
* "pod" was being truncated to "po" in the names of the generated systemd unit ↵Gavin Campbell2020-06-24
| | | | | | | | files. s/po/pod Signed-off-by: Gavin Campbell <gavin@gavincampbell.dev>
* rootless_linux: improve error messageDouglas Schilling Landgraf2020-06-24
| | | | | | | Improve the error message for rootless mode. Git-Url: https://github.com/containers/libpod/issues/6572 Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
* Fix podman build handling of --http-proxy flagDaniel J Walsh2020-06-24
| | | | | | Also fixed a todo for handling of cgroup manager while I was in there. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* correct the absolute path of `rm` executableYuan-Hao Chen2020-06-24
| | | | Signed-off-by: Yuan-Hao Chen <yhchen0906@gmail.com>
* Merge pull request #6711 from lsm5/v2.0-custom-GO_BUILD-backportOpenShift Merge Robot2020-06-22
|\ | | | | Makefile: allow customizable GO_BUILD
| * Makefile: allow customizable GO_BUILDLokesh Mandvekar2020-06-22
|/ | | | | | | | This will let me use a customizable GO_BUILD so that I can run build targets for deb packages Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> (cherry picked from commit 78bd0e0a635470128a0452a67e242e4761723657)
* Merge pull request #6695 from cevich/update_v2.0OpenShift Merge Robot2020-06-20
|\ | | | | Cirrus: Change DEST_BRANCH to v2.0
| * Cirrus: Change DEST_BRANCH to v2.0Chris Evich2020-06-19
| | | | | | | | | | | | | | Also remove job that only runs on 'master', and reference most container image names using the v2.0 branch tag. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #6697 from mheon/bump_v2.0.0OpenShift Merge Robot2020-06-19
|\ \ | | | | | | [CI:DOCS] Bump to v2.0.0
| * | Update release notes to reflect we are now v2.0Matthew Heon2020-06-19
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Bump to v2.0.1-devMatthew Heon2020-06-19
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Bump to v2.0.0v2.0.0Matthew Heon2020-06-19
|/ / | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #6694 from mheon/release_notes_2.0OpenShift Merge Robot2020-06-19
|\ \ | |/ |/| [CI:DOCS] Update release notes for v2.0.0
| * Update release notes for v2.0.0Matthew Heon2020-06-19
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #6674 from jwhonce/issues/6670OpenShift Merge Robot2020-06-19
|\ | | | | Add support for image sorting for all options
| * Fixes #6670Jhon Honce2020-06-19
| | | | | | | | | | | | | | * Sort images for -q option, removing duplicate id's * Sort images for --format json Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #6637 from jwhonce/issues/6574OpenShift Merge Robot2020-06-19
|\ \ | |/ |/| Correct logic for demux'ing channels
| * Correct logic for demux'ing channelsJhon Honce2020-06-19
|/ | | | | | * Move check for requesting output into case statement Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #6677 from baude/pollOnEventsOpenShift Merge Robot2020-06-19
|\ | | | | Poll on events for file reading
| * Poll on events for file readingBrent Baude2020-06-19
| | | | | | | | | | | | | | | | When multiple connections are monitoring events via the remote API, the inotify in the hpcloud library seems unable to consistently send events. Switching from inotify to poll seems to clear this up. Fixes: #6664 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #6690 from vrothberg/fix-6687OpenShift Merge Robot2020-06-19
|\ \ | |/ |/| podman images --format json: pretty print
| * podman images --format json: pretty printValentin Rothberg2020-06-19
|/ | | | | | | | | Pretty print the JSON output when listing images. We regressed on that during v2 development. The indentation is now identical to the one of Podman v1.9.3. Fixes: #6687 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6684 from vrothberg/fix-ciOpenShift Merge Robot2020-06-19
|\ | | | | CI: force registry:2.6
| * CI: force registry:2.6Valentin Rothberg2020-06-19
|/ | | | | | | | | | | For using the `registry:2.6` image. 2.7 and beyond dropped the `htpasswd` binary from the rootfs which parts of our CI depends on. While this is not a sustainable solution (assuming `htpasswd` is gone for ever), it unblocks the CI for now. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6673 from ashley-cui/masterOpenShift Merge Robot2020-06-18
|\ | | | | [CI:DOCS] Fix remote docs
| * Fix remote docsAshley Cui2020-06-18
|/ | | | | | | | Fix renaming bug in remote-docs.sh Remove mentions of 'remote' in windows and mac dos Remove podman-remote.conf.5 Signed-off-by: Ashley Cui <acui@redhat.com>
* Merge pull request #6656 from mheon/recursive_initOpenShift Merge Robot2020-06-18
|\ | | | | Allow recursive dependency start with Init()
| * Allow recursive dependency start with Init()Matthew Heon2020-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of APIv2 Attach, we need to be able to attach to freshly created containers (in ContainerStateConfigured). This isn't something Libpod is interested in supporting, so we use Init() to get the container into ContainerStateCreated, in which attach is possible. Problem: Init() will fail if dependencies are not started, so a fresh container in a fresh pod will fail. The simplest solution is to extend the existing recursive start code from Start() to Init(), allowing dependency containers to be started when we initialize the container (optionally, controlled via bool). Also, update some comments in container_api.go to make it more clear how some of our major API calls work. Fixes #6646 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #6662 from ↵OpenShift Merge Robot2020-06-18
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/k8s.io/apimachinery-0.18.4 Bump k8s.io/apimachinery from 0.18.3 to 0.18.4
| * | Bump k8s.io/apimachinery from 0.18.3 to 0.18.4Daniel J Walsh2020-06-18
| |/ | | | | | | | | | | | | | | | | Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.18.3 to 0.18.4. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.18.3...v0.18.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #6669 from vrothberg/unflake-rmiOpenShift Merge Robot2020-06-18
|\ \ | |/ |/| unflake rmi tests
| * unflake rmi testsValentin Rothberg2020-06-18
| | | | | | | | | | | | | | Make sure to always get the older images that previously committed one depends on. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #6663 from containers/dependabot/go_modules/k8s.io/api-0.18.4OpenShift Merge Robot2020-06-18
|\ \ | | | | | | Bump k8s.io/api from 0.18.3 to 0.18.4
| * | Bump k8s.io/api from 0.18.3 to 0.18.4dependabot-preview[bot]2020-06-18
| |/ | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.18.3 to 0.18.4. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.18.3...v0.18.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #6661 from ↵OpenShift Merge Robot2020-06-18
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/go.etcd.io/bbolt-1.3.5 Bump go.etcd.io/bbolt from 1.3.4 to 1.3.5
| * | Bump go.etcd.io/bbolt from 1.3.4 to 1.3.5dependabot-preview[bot]2020-06-18
| |/ | | | | | | | | | | | | | | | | Bumps [go.etcd.io/bbolt](https://github.com/etcd-io/bbolt) from 1.3.4 to 1.3.5. - [Release notes](https://github.com/etcd-io/bbolt/releases) - [Commits](https://github.com/etcd-io/bbolt/compare/v1.3.4...v1.3.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #6658 from mheon/experimental_no_moreOpenShift Merge Robot2020-06-18
|\ \ | | | | | | Podman system service is no longer experimental
| * | Podman system service is no longer experimentalMatthew Heon2020-06-17
| | | | | | | | | | | | | | | | | | | | | As such, we can remove the warnings logs that previously printed every time it was run. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #6611 from lsm5/fix-Makefile-for-varlinkOpenShift Merge Robot2020-06-18
|\ \ \ | |_|/ |/| | Makefile: install.varlink needs to create dirs
| * | Makefile: install.varlink needs to create dirsLokesh Mandvekar2020-06-17
| | | | | | | | | | | | Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #6654 from rhatdan/keepidOpenShift Merge Robot2020-06-17
|\ \ \ | | | | | | | | Don't ignore --user flag in rootless --userns keepid
| * | | Don't ignore --user flag in rootless --userns keepidDaniel J Walsh2020-06-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently podman run --userns keep-id --user root:root fedora id The --user flag is ignored. Removing this makes the code work correctly. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>