summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #2378 from vrothberg/tree-statusOpenShift Merge Robot2019-02-20
|\ | | | | hack/tree_status.sh: preserve new lines
| * hack/tree_status.sh: preserve new linesValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | Quote the status output in echo to preserve the new lines. Having the output in one line complicated debugging issues and is not friendly to use. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2377 from vrothberg/kill-squaredOpenShift Merge Robot2019-02-20
|\ \ | | | | | | remove duplicate kill from `podman --help`
| * | remove duplicate kill from `podman --help`Valentin Rothberg2019-02-20
| |/ | | | | | | | | | | | | | | Remove the duplicate kill command and only keep it in the `mainCommands` containing commands that are implemented by the native client and the remote one. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2360 from vrothberg/parallel-searchOpenShift Merge Robot2019-02-20
|\ \ | | | | | | podman-search: run in parallel
| * | iopodman.SearchImages: add ImageSearchFilter to Varlink APIValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also add some argument checks to the Varlink function to avoid referencing nil pointers, and complement the API.md descriptions. The varlink endpoint can be tested via varlink CLI: $ varlink call -m unix:/run/podman/io.podman/io.podman.SearchImages \ '{"query": "ruby", "limit": 0, "tlsVerify": false, "filter": {}}' Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | image.SearchImages: use SearchFilter typeValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | | | | | | Use an `image.SearchFilter` instead of a `[]string` in the SearchImages API. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | SearchImages: extend API with filter parameterValentin Rothberg2019-02-20
| | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | podman-search: refactor code to libpod/image/search.goValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | | | | | | | | | Refactor the image-search logic from cmd/podman/search.go to libpod/image/search.go and update podman-search and the Varlink API to use it. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | podman-search: run in parallelValentin Rothberg2019-02-20
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Spin up a goroutine for each registry to make podman-search run in parallel. This has considerable speed improvements. For instance, a `podman search ruby` drops from 11 to 2 seconds when using the following search registries: ```toml [registries.search] registries = ['docker.io', 'registry.fedoraproject.org', 'quay.io', 'registry.access.redhat.com', 'registry.centos.org'] ``` The number of parallel goroutines is limited to 6 to play nice with local resources and the registries. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2374 from mheon/rootless_recursive_startOpenShift Merge Robot2019-02-20
|\ \ | |/ |/| Ensure that userns is created for stopped rootless pods
| * Ensure that userns is created for stopped rootless podsMatthew Heon2019-02-19
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #2373 from mheon/pod_has_no_argumentsOpenShift Merge Robot2019-02-19
|\ \ | |/ |/| Podman pod create now errors on receiving CLI args
| * Podman pod create now errors on receiving CLI argsMatthew Heon2019-02-19
|/ | | | | | | It has never accepted arguments, so we should error when passed args we will never use. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #2363 from TomSweeneyRedHat/dev/tsweeney/cobraex5OpenShift Merge Robot2019-02-19
|\ | | | | Fifth chunk of Cobra Examples
| * Fifth chunk of Cobra ExamplesTomSweeneyRedHat2019-02-18
| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> The fifth and final chunk of examples for the Cobra examples in the CLI help output. Also includes a few man page touchups. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #2348 from baude/remotepullverboseOpenShift Merge Robot2019-02-19
|\ \ | | | | | | podman-remote pull
| * | podman-remote pullbaude2019-02-19
|/ / | | | | | | | | | | Add status for remote users and podman remote-client pull. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2366 from haircommander/dont-start-started-depsOpenShift Merge Robot2019-02-19
|\ \ | |/ |/| Don't start running dependencies
| * Don't start running dependenciesPeter Hunt2019-02-19
|/ | | | | | Before, a container being run or started in a pod always restarted the infra container. This was because we didn't take running dependencies into account. Fix this by filtering for dependencies in the running state. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* Merge pull request #2361 from TomSweeneyRedHat/dev/tsweeney/cobraex4OpenShift Merge Robot2019-02-18
|\ | | | | Add 4th chunk of Cobra Examples
| * Add 4th chunk of Cobra ExamplesTomSweeneyRedHat2019-02-18
| | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds the 4th chunk of Cobra Examples to the CLI help. One more chunk of 10 to complete. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #1692 from sjug/opentracing_cleanOpenShift Merge Robot2019-02-18
|\ \ | |/ |/| OpenTracing First Impl
| * OpenTracing support added to start, stop, run, create, pull, and psSebastian Jug2019-02-18
|/ | | | | | Drop context.Context field from cli.Context Signed-off-by: Sebastian Jug <sejug@redhat.com>
* Merge pull request #2354 from rhatdan/varlinkOpenShift Merge Robot2019-02-18
|\ | | | | Add registry name to fields returned by varlink image search
| * Add registry name to fields returned by varlink image searchDaniel J Walsh2019-02-15
| | | | | | | | | | | | | | | | | | | | | | Cockpit team wants to list the registry name where the image was found. Also fix up SearchImages code to check if the user specified a registry in his call to use that rather then all the registries, This matches podman search command. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2359 from nitkon/masterOpenShift Merge Robot2019-02-18
|\ \ | | | | | | packer: Make Makefile host arch sensitive
| * | packer: Make Makefile host arch sensitiveNitesh Konkar2019-02-18
|/ / | | | | | | | | | | | | | | `make localunit` fails on non-amd64 archs as it unzips packer_1.3.2_linux_amd64.zip irrespective of host arch its running on. Signed-off-by: Nitesh Konkar <niteshkonkar@in.ibm.com>
* | Merge pull request #2357 from TomSweeneyRedHat/dev/tsweeney/cobrahelp3OpenShift Merge Robot2019-02-17
|\ \ | | | | | | Add 3rd chunk of Cobra examples
| * | Add 3rd chunk of Cobra examplesTomSweeneyRedHat2019-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds the third chunk of Cobra examples to the cli help. As were putting together a release tomorrow, tried to hit the heavy commands with this PR. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2295 from haircommander/recursive-startOpenShift Merge Robot2019-02-17
|\ \ \ | |/ / |/| | Recursively start a pod if a container is run in it
| * | pod infra container is started before a container in a pod is run, started, ↵Peter Hunt2019-02-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | or attached. Prior, a pod would have to be started immediately when created, leading to confusion about what a pod state should be immediately after creation. The problem was podman run --pod ... would error out if the infra container wasn't started (as it is a dependency). Fix this by allowing for recursive start, where each of the container's dependencies are started prior to the new container. This is only applied to the case where a new container is attached to a pod. Also rework container_api Start, StartAndAttach, and Init functions, as there was some duplicated code, which made addressing the problem easier to fix. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | Merge pull request #2340 from QiWang19/login_lyingOpenShift Merge Robot2019-02-17
|\ \ \ | | | | | | | | Fix `podman login` lying problem
| * | | Fix `podman login` lying problemQi Wang2019-02-14
| | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #2341 from TomSweeneyRedHat/dev/tsweeney/helpexamples2OpenShift Merge Robot2019-02-16
|\ \ \ \ | |_|/ / |/| | | Second chunk of Cobra help
| * | | Second chunk of Cobra helpTomSweeneyRedHat2019-02-15
| | |/ | |/| | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds examples to Cobra help for a second chunk of commands. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2335 from mheon/enable_detach_rmOpenShift Merge Robot2019-02-15
|\ \ \ | |/ / |/| | Enable --rm with --detach
| * | Fix error code retrieval for podman start --attachMatthew Heon2019-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we start a container with 'podman run' and it exits and is removed before we get the code, we grab its exit code from the Conmon exit file. Podman start --attach wants to do the same, but was missing the logic. Fix that here. Also, remove some --rm handling leftover in start. Don't need it anymore, we have the cleanup process now. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Enable --rm with --detachMatthew Heon2019-02-14
| | | | | | | | | | | | | | | | | | | | | We can now safely remove detached containers as --rm handling has moved into the cleanup process. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #2353 from giuseppe/honor-storage-optOpenShift Merge Robot2019-02-15
|\ \ \ | | | | | | | | podman: honor --storage-opt again
| * | | podman: honor --storage-opt againGiuseppe Scrivano2019-02-15
|/ / / | | | | | | | | | | | | | | | possibly a regression after we moved to Cobra Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2188 from TomSweeneyRedHat/dev/tsweeney/pullallOpenShift Merge Robot2019-02-15
|\ \ \ | | | | | | | | Add --all-tags to pull command
| * | | Add --all-tags to pull commandTomSweeneyRedHat2019-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Add --all-tags for the `podman pull` command so all tags of an image will be pulled, not just ':latest'. Emulates the change in Buildah https://github.com/containers/buildah/pull/1263 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #2346 from giuseppe/fix-runtime-lookupOpenShift Merge Robot2019-02-15
|\ \ \ \ | | | | | | | | | | libpod.conf: add backward compatibility for runtime_path
| * | | | docs: mention the new OCI runtime configurationGiuseppe Scrivano2019-02-15
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | libpod: honor runtime_path from libpod.confGiuseppe Scrivano2019-02-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add backward compatibility for `runtime_path` that was used by older versions of Podman. The issue was introduced with: 650cf122e1b33f4d8f4426ee1cc1a4bf00c14798 If `runtime_path` is specified, it overrides any other configuration and a warning is printed. It should be considered deprecated and will be removed in future. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | rootless: open the correct fileDaniel J Walsh2019-02-15
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #2305 from rhatdan/tlsverifyOpenShift Merge Robot2019-02-15
|\ \ \ \ \ | |/ / / / |/| | | | Add tlsVerify bool to SearchImage for varlink
| * | | | Add tlsVerify bool to SearchImage for varlinkDaniel J Walsh2019-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cockpit wants to be able to search images on systems without tlsverify turned on. tlsverify should be an optional parameter, if not set then we default to the system defaults defined in /etc/containers/registries.conf. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #2333 from TomSweeneyRedHat/dev/tsweeney/helpexamplesOpenShift Merge Robot2019-02-15
|\ \ \ \ \ | |_|_|_|/ |/| | | | Add examples for Cobra