summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* rootless: fix segfault when open fd >= FD_SETSIZEGiuseppe Scrivano2020-02-25
| | | | | | | | | if there are more than FD_SETSIZE open fds passed down to the Podman process, the initialization code could crash as it attempts to store them into a fd_set. Use an array of fd_set structs, each of them holding only FD_SETSIZE file descriptors. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #5297 from rhatdan/vendorOpenShift Merge Robot2020-02-25
|\ | | | | Update vendor of buildah and containers/common
| * Update vendor of buildah and containers/commonDaniel J Walsh2020-02-25
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5305 from mheon/check_for_common_deadlocksOpenShift Merge Robot2020-02-25
|\ \ | |/ |/| Add basic deadlock detection for container start/remove
| * Add basic deadlock detection for container start/removeMatthew Heon2020-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can easily tell if we're going to deadlock by comparing lock IDs before actually taking the lock. Add a few checks for this in common places where deadlocks might occur. This does not yet cover pod operations, where detection is more difficult (and costly) due to the number of locks being involved being higher than 2. Also, add some error wrapping on the Podman side, so we can tell people to use `system renumber` when it occurs. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5318 from giuseppe/fix-running-without-env-variablesOpenShift Merge Robot2020-02-25
|\ \ | | | | | | build: move initialization after SetXdgDirs
| * | build: move initialization after SetXdgDirsGiuseppe Scrivano2020-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | otherwise it triggers the config file initialization from vendor/github.com/containers/common/pkg/config before the init() in main.go can set correctly XDG_RUNTIME_DIR and DBUS_SESSION_BUS_ADDRESS when they are missing. commit 96de762eedd1470dfbe73cf424eea848589268d7 introduced the regression. Closes: https://github.com/containers/libpod/issues/5314 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | utils: relax check for directory to useGiuseppe Scrivano2020-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when we use namespaces, we set the run directory to 0711 to allow other users to access it. without this relaxation, the /run/user/$UID directory would be skipped. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5317 from baude/docsalwaysOpenShift Merge Robot2020-02-24
|\ \ \ | | | | | | | | always run the docs task on post-merge
| * | | always run the docs task on post-mergeBrent Baude2020-02-24
| |/ / | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5308 from lsm5/tests-apiv2OpenShift Merge Robot2020-02-24
|\ \ \ | |/ / |/| | add apiv2 tests for podman pause and stop
| * | add apiv2 tests for podman pause and stopLokesh Mandvekar2020-02-24
|/ / | | | | | | | | | | Initial ginkgo setup credit to Brent Baude <bbaude@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | Merge pull request #5281 from baude/bindingsciOpenShift Merge Robot2020-02-24
|\ \ | | | | | | enable ci on go binding tests
| * | enable ci on go binding testsBrent Baude2020-02-22
| | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5301 from baude/apiv2imagetests3OpenShift Merge Robot2020-02-24
|\ \ \ | |_|/ |/| | more image binding tests
| * | more image binding testsBrent Baude2020-02-23
| | | | | | | | | | | | | | | | | | | | | | | | add two additional bindings tests for image usage. add ability to use search filter on the endpoint. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #4889 from baude/portsearchOpenShift Merge Robot2020-02-23
|\ \ \ | | | | | | | | fix port list by container with port
| * | | Friendly amendment: tests, and a help messageEd Santiago2020-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) Help message for podman port was missing [PORT] 2) Add test for 'podman port'. And, actually, an entire networking test that I'd written some weeks ago but apparently didn't 'git add'. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Brent Baude <bbaude@redhat.com>
| * | | fix port list by container with portbaude2020-02-23
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | code was erronously misinterpretting the port as a containername. Fixes: #1791832 Signed-off-by: baude <bbaude@redhat.com> Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5300 from baude/disablehealthOpenShift Merge Robot2020-02-23
|\ \ \ | |/ / |/| | Add --no-healthcheck command to create/run
| * | Add --no-healthcheck command to create/runBrent Baude2020-02-22
| | | | | | | | | | | | | | | | | | | | | | | | Now support --no-healthcheck option to disable defined healthchecks in a container image. --health-cmd=none remains supported as well. Fixes: #5299 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5304 from stefanb2/topic-pr-4550OpenShift Merge Robot2020-02-23
|\ \ \ | | | | | | | | docs: symlink to host device is resolved
| * | | docs: symlink to host device is resolvedStefan Becker2020-02-23
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Also apply changes from commit 3fd9f0c028f9dab7c8923629d4dc5d38e594db1a to the other two commands that have the --device option. Documents #4550 Signed-off-by: Stefan Becker <chemobejk@gmail.com>
* | | Merge pull request #5287 from ↵OpenShift Merge Robot2020-02-23
|\ \ \ | |/ / |/| | | | | | | | containers/dependabot/go_modules/github.com/opencontainers/selinux-1.3.2 build(deps): bump github.com/opencontainers/selinux from 1.3.1 to 1.3.2
| * | build(deps): bump github.com/opencontainers/selinux from 1.3.1 to 1.3.2dependabot-preview[bot]2020-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/opencontainers/selinux/releases) - [Commits](https://github.com/opencontainers/selinux/compare/v1.3.1...v1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5290 from baude/apiv2imagetests2OpenShift Merge Robot2020-02-22
|\ \ \ | |_|/ |/| | add more image tests for go bindings
| * | add more image tests for go bindingsBrent Baude2020-02-21
| | | | | | | | | | | | | | | | | | adding more image tests for go bindings. one big change is that the params were converted from map[string]string to url.values to account for the ability to send []string as query params Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5294 from mheon/bump-1.8.1-rc1OpenShift Merge Robot2020-02-21
|\ \ \ | | | | | | | | Bump to v1.8.1-RC1
| * | | Bump to v1.8.1-devMatthew Heon2020-02-21
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | Bump to v1.8.1-rc1v1.8.1-rc1Matthew Heon2020-02-21
|/ / / | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5293 from mheon/RELEASE_NOTES_1.8.1OpenShift Merge Robot2020-02-21
|\ \ \ | |/ / |/| | [CI:DOCS] Update release notes for v1.8.1
| * | Update release notes for v1.8.1Matthew Heon2020-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5280 from baude/addreturnOpenShift Merge Robot2020-02-21
|\ \ \ | | | | | | | | search endpoint failure correction
| * | | search endpoint failure correctionBrent Baude2020-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when returning an invalid search, a return was omitted triggering a null on the consumer end. Fixes: #5228 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5292 from baude/nofirewallpluginisgoodOpenShift Merge Robot2020-02-21
|\ \ \ \ | |/ / / |/| | | disable generation of cni firewall plugin
| * | | disable generation of cni firewall pluginBrent Baude2020-02-21
|/ / / | | | | | | | | | | | | | | | | | | | | | it turns out that when the firewall plugin is not provided as part of the configuration, then the firewall cni plugin will dynamically figure out if it should use firewalld or iptables. also removing this from the default configuration file Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5213 from mheon/remove_db_imagevolOpenShift Merge Robot2020-02-21
|\ \ \ | | | | | | | | Remove ImageVolumes from database
| * | | Remove ImageVolumes from databaseMatthew Heon2020-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before Libpod supported named volumes, we approximated image volumes by bind-mounting in per-container temporary directories. This was handled by Libpod, and had a corresponding database entry to enable/disable it. However, when we enabled named volumes, we completely rewrote the old implementation; none of the old bind mount implementation still exists, save one flag in the database. With nothing remaining to use it, it has no further purpose. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #5263 from baude/logsizeOpenShift Merge Robot2020-02-21
|\ \ \ \ | |_|/ / |/| | | implement reverse reader for log reads
| * | | implement reverse reader for log readsBrent Baude2020-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in cases where the log file exceeds the available memory of a system, we had a bug that triggered an oom because the entire logfile was being read when the tail parameter was given. this reads in chunks and is more or less memory safe. fixes: #5131 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5236 from marusak/filter_by_idOpenShift Merge Robot2020-02-21
|\ \ \ \ | | | | | | | | | | apiv2: Image filtering and fixup docs
| * | | | apiv2: Fixup /containers/json filters documentationMatej Marusak2020-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mention what is the input format plus put literals into quotation marks for better readability (plus it seems that some tags were not rendered). Signed-off-by: Matej Marusak <mmarusak@redhat.com>
| * | | | apiv2: Enable filtering images by IDMatej Marusak2020-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is more practical for API usage and also it is more in sync how filtering of containers works. Signed-off-by: Matej Marusak <mmarusak@redhat.com>
* | | | | Merge pull request #5178 from marusak/expose_cpuOpenShift Merge Robot2020-02-21
|\ \ \ \ \ | | | | | | | | | | | | stats: Expose CPU usage in API
| * | | | | stats: Expose CPU usage in APIMatej Marusak2020-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `stats.CPU` is a number representing CPU usage in percents. It is possible to calculate it from other exposed fields (once they are implemented correctly) but why to do it, when this is already calculated. This does not break API, it just adds another field. Signed-off-by: Matej Marusak <mmarusak@redhat.com>
* | | | | | Merge pull request #5279 from edsantiago/swagger_fixesOpenShift Merge Robot2020-02-21
|\ \ \ \ \ \ | | | | | | | | | | | | | | Swagger: yet more fixes
| * | | | | | Swagger: yet more fixesEd Santiago2020-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR #5204 added /libpod/containers/create but with the wrong swagger comment. Fix that. Also fix some other inconsistencies: missing 'libpod' prefix, missing 'Container' suffix, and change 'ContainerCreate' to 'CreateContainer'; all of these changes preserve consistency with both the invoked function as well as the overall naming conventions used in this module. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #5221 from Jumanjii/fix-package-install-f31OpenShift Merge Robot2020-02-21
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | Fix make package-install on fedora31
| * | | | | | Upgrade make package-install for fedora31Allan Jacquet-Cretides2020-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The package golang-github-cpuguy83-go-md2man has been renamed into golang-github-cpuguy83-md2man in f31 repository. That leads to an Error: Unable to find a match: golang-github-cpuguy83-go-md2man This patch handles the renaming of this package and fixes the command for f31 and the one that will follows without breaking compatibility with older versions. Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@gmail.com>
* | | | | | | Merge pull request #5271 from baude/dnsnameusernsOpenShift Merge Robot2020-02-21
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | populate resolv.conf with dnsname responses when in usernamespace