summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Populate ExecSession with all required fieldsMatthew Heon2020-03-18
| | | | | | | | | As part of the rework of exec sessions, we want to split Create and Start - and, as a result, we need to keep everything needed to start exec sessions in the struct, not just the bare minimum for tracking running ones. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #5532 from baude/filetimeoutflakeOpenShift Merge Robot2020-03-18
|\ | | | | fix timeout file flake
| * Fix vendoring on masterMatthew Heon2020-03-17
| | | | | | | | | | | | | | It looks like something snuck in and now make vendor fails on master. This should make things happy. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * fix timeout file flakeBrent Baude2020-03-17
| | | | | | | | | | | | this is a temporary fix for the flake that has been troubling us. once conmon is in fedora 30 and 31 stable, we can remove this fix. the images will just need to be rebuilt. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5533 from mheon/bump-1.8.2-rc1OpenShift Merge Robot2020-03-18
|\ \ | | | | | | Bump to v1.8.2-RC1
| * | Bump to v1.8.2-devMatthew Heon2020-03-17
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Bump to v1.8.2-rc1v1.8.2-rc1Matthew Heon2020-03-17
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #5536 from giuseppe/avoid-conmon-zombieOpenShift Merge Robot2020-03-18
|\ \ \ | |/ / |/| | podman: avoid conmon zombie on exec
| * | podman: avoid conmon zombie on execGiuseppe Scrivano2020-03-18
| | | | | | | | | | | | | | | | | | | | | conmon forks itself, so make sure we reap the first process and not leave a zombie process. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5528 from mheon/fix_master_vendorOpenShift Merge Robot2020-03-17
|\ \ \ | |_|/ |/| | Fix vendoring on master
| * | Fix vendoring on masterMatthew Heon2020-03-17
| | | | | | | | | | | | | | | | | | | | | It looks like something snuck in and now make vendor fails on master. This should make things happy. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #5529 from mheon/release_notes_182_rc1OpenShift Merge Robot2020-03-17
|\ \ \ | |/ / |/| | [CI:DOCS] Update release notes for v1.8.2-RC1
| * | Update release notes for v1.8.2-rc1Matthew Heon2020-03-17
|/ / | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5524 from rhatdan/vendorOpenShift Merge Robot2020-03-17
|\ \ | | | | | | Update containers/storage to v1.16.5
| * | Update containers/storage to v1.16.5Daniel J Walsh2020-03-17
| |/ | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5449 from baude/manifestsOpenShift Merge Robot2020-03-17
|\ \ | | | | | | apiv2 addition of manifests
| * | apiv2 addition of manifestsBrent Baude2020-03-16
| | | | | | | | | | | | | | | | | | | | | | | | add endpoints for create, add, remove, inspect, and push. this allows manifests to be managed through the restful interfaces. also added go-bindings and tests Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5520 from giuseppe/make-warning-clearerOpenShift Merge Robot2020-03-17
|\ \ \ | |_|/ |/| | config: make warning clearer
| * | config: make warning clearerGiuseppe Scrivano2020-03-17
|/ / | | | | | | | | | | | | | | | | make clearer that the warning could also happen because the logger is set to use systemd. Closes: https://github.com/containers/libpod/issues/5443 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #5515 from edsantiago/ci_sundry_small_fixesOpenShift Merge Robot2020-03-16
|\ \ | | | | | | Four small CI fixes:
| * | Four small CI fixes:Ed Santiago2020-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) 'podman system info' (in logcollector): has been silently failing in special_testing_rootless, with: logcollector.sh: line 16: podman: command not found Use ./bin/podman instead of just podman; this is probably the right thing to do in the general case anyway 2) logformatter: highlight 'panic:', seen in bindings test: https://storage.googleapis.com/cirrus-ci-5385732420009984-fcae48/artifacts/containers/libpod/6693715108429824/html/integration_test.log.html 3) logformatter: handle Unicode bullet in front of 'Running', seen in bindings test. 4) logformatter: turn down contrast on BATS 'ok' results, for legibility Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #5490 from containers/dependabot/go_modules/k8s.io/api-0.17.4OpenShift Merge Robot2020-03-16
|\ \ \ | | | | | | | | Bump k8s.io/api from 0.17.3 to 0.17.4
| * | | Bump k8s.io/api from 0.17.3 to 0.17.4dependabot-preview[bot]2020-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.17.3 to 0.17.4. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.17.3...v0.17.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #5489 from ↵OpenShift Merge Robot2020-03-16
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/common-0.5.0 Bump github.com/containers/common from 0.4.2 to 0.5.0
| * | | Bump github.com/containers/common from 0.4.2 to 0.5.0dependabot-preview[bot]2020-03-13
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/common](https://github.com/containers/common) from 0.4.2 to 0.5.0. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.4.2...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5514 from vrothberg/fix-ciEd Santiago2020-03-16
|\ \ \ | | | | | | | | fix systemd generate tests
| * | | fix systemd generate testsValentin Rothberg2020-03-16
|/ / / | | | | | | | | | | | | | | | Add the `default.target` to the failing tests. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5439 from ttys3/fixup-systemdgen-with-new-paramOpenShift Merge Robot2020-03-16
|\ \ \ | | | | | | | | systemd generator: force run container detached if CreateCommand has no detach param
| * | | force run container detached if container CreateCommand missing the detach param荒野無燈2020-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the podman generated systemd service file has `Type=forking` service, so the command after `ExecStart=` should not run in front. if someone created a container and has the detach(`-d`) param missing like this ``` podman create --name ngxdemo -P nginxdemos/hello ``` and generate the file with `--new` param: ``` podman generate systemd --name --new ngxdemo ``` because `podman run xxx` has no `-d` param, so the container is not run in background and nerver exit. and systemd will fail to start the service: ``` sudo systemctl start container-ngxdemo.service Job for container-ngxdemo.service failed because a timeout was exceeded. See "systemctl status container-ngxdemo.service" and "journalctl -xe" for details. ``` Signed-off-by: 荒野無燈 <ttys3@outlook.com>
* | | | Merge pull request #5252 from QiWang19/not-reset-tempdirOpenShift Merge Robot2020-03-16
|\ \ \ \ | | | | | | | | | | Fix bug podman reset to not remove $XDG_RUNTIME_DIR
| * | | | Fix bug podman reset to not remove $XDG_RUNTIME_DIRQi Wang2020-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some older systems we point the temporary directory to /run/user/1000 which leads podman system reset to clear unrelated files under XDG_RUNTIME_DIR. This patch only removes files created by podman if TmpDir is the same as the XDG_RUNTIME_DIR. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | Merge pull request #5505 from tonybenoy/tony_typoOpenShift Merge Robot2020-03-16
|\ \ \ \ \ | | | | | | | | | | | | Missing double quotes in troubleshooting guide.
| * | | | | Missing double quotes in troubleshooting guide.Tony Benoy2020-03-15
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Tony Benoy <me@tonybenoy.com>
* | | | | | Merge pull request #5476 from edsantiago/run_rmi_test_fixOpenShift Merge Robot2020-03-16
|\ \ \ \ \ \ | | | | | | | | | | | | | | run --rmi test: make it work
| * | | | | | run --rmi test: make it workEd Santiago2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The recently-added 'run --rmi' test was not actually doing what it thinks it was doing: for one, 'run_podman | grep' is never going to work; also, the test was leaving behind stray images. Rework to do what I believe the intention was; and, combine into one test (down from two) for readability. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #5508 from baude/buildaddarchosOpenShift Merge Robot2020-03-16
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | add os|arch attributes when building
| * | | | | | add os|arch attributes when buildingBrent Baude2020-03-15
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when building images, we can now add the os and arch of the image using overrides from the commandline. the commandline options set sane defaults so we use those as well. Fixes: #5503 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5496 from baude/preemptiveOpenShift Merge Robot2020-03-14
|\ \ \ \ \ \ | | | | | | | | | | | | | | eat signal 23 in signal proxy
| * | | | | | eat signal 23 in signal proxyBrent Baude2020-03-13
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | due to a change in golang-1.14 and it's changes to make go funcs with tight loops preemptive, signals are now getting "through" that never were before. From the golang-1.14 announce: Goroutines are now asynchronously preemptible. As a result, loops without function calls no longer potentially deadlock the scheduler or significantly delay garbage collection. This is supported on all platforms except windows/arm, darwin/arm, js/wasm, and plan9/*. A consequence of the implementation of preemption is that on Unix systems, including Linux and macOS systems, programs built with Go 1.14 will receive more signals than programs built with earlier releases. This means that programs that use packages like syscall or golang.org/x/sys/unix will see more slow system calls fail with EINTR errors. Those programs will have to handle those errors in some way, most likely looping to try the system call again. For more information about this see man 7 signal for Linux systems or similar documentation for other systems. Fixes #5483 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5491 from ↵OpenShift Merge Robot2020-03-14
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/fsnotify/fsnotify-1.4.9 Bump github.com/fsnotify/fsnotify from 1.4.7 to 1.4.9
| * | | | | | Bump github.com/fsnotify/fsnotify from 1.4.7 to 1.4.9dependabot-preview[bot]2020-03-13
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.4.7 to 1.4.9. - [Release notes](https://github.com/fsnotify/fsnotify/releases) - [Changelog](https://github.com/fsnotify/fsnotify/blob/master/CHANGELOG.md) - [Commits](https://github.com/fsnotify/fsnotify/compare/v1.4.7...v1.4.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #5327 from baude/apiv2hcOpenShift Merge Robot2020-03-13
|\ \ \ \ \ \ | |/ / / / / |/| | | | | add apiv2 healthcheck code
| * | | | | add apiv2 healthcheck codeBrent Baude2020-03-13
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | reworking binding and endpoint to actually work. added documentation in swagger for and various return code possibilities. add a good start on tests though we need some other container functions not yet implemented for that. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5470 from ↵OpenShift Merge Robot2020-03-12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.16.3 Bump github.com/containers/storage from 1.16.2 to 1.16.3
| * | | | | Bump github.com/containers/storage from 1.16.2 to 1.16.3dependabot-preview[bot]2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.16.2 to 1.16.3. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.16.2...v1.16.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #5484 from baude/bindingsnocolorOpenShift Merge Robot2020-03-12
|\ \ \ \ \ \ | | | | | | | | | | | | | | turn off color-mode for bindings
| * | | | | | turn off color-mode for bindingsBrent Baude2020-03-12
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | the binding ginkgo tests were using color mode which throws in a bunch of ansi garbage that makes it hard to read the logs Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5482 from baude/removeimagefilterOpenShift Merge Robot2020-03-12
|\ \ \ \ \ \ | |/ / / / / |/| | | | | remove imagefilter for varlink remote client
| * | | | | remove imagefilter for varlink remote clientBrent Baude2020-03-12
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | the api for getting images changed to use filters but back level podman versions cannot handle it. so temporarily disabling the filtering for remote clients until the restful approach can be used. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5474 from giuseppe/detect-containers-rootlessport-child-exitOpenShift Merge Robot2020-03-12
|\ \ \ \ \ | | | | | | | | | | | | rootlessport: detect rootless-child exit
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-18 15:07:09 +0000