summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
| * change ps Created to unixbaude2021-02-12
| | | | | | | | | | | | | | | | change from unixnano to unix for ps created --format json [NO TESTS NEEDED] Signed-off-by: baude <bbaude@redhat.com>
| * container ps json format miscuebaude2021-02-12
| | | | | | | | | | | | | | | | | | | | when printing out json format, we mistakenly changed the Created field output to be a time.time in a different commit. This allows for override of the Created field to be a unix ts as type int64. Fixes: #9315 Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #9346 from vrothberg/3.0-layer-tree-errorsOpenShift Merge Robot2021-02-13
|\ \ | | | | | | [3.0] make layer-tree lookup errors non-fatal
| * | make layer-tree lookup errors non-fatalValentin Rothberg2021-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Internally, Podman constructs a tree of layers in containers/storage to quickly compute relations among layers and hence images. To compute the tree, we intersect all local layers with all local images. So far, lookup errors have been fatal which has turned out to be a mistake since it seems fairly easy to cause storage corruptions, for instance, when killing builds. In that case, a (partial) image may list a layer which does not exist (anymore). Since the errors were fatal, there was no easy way to clean up and many commands were erroring out. To improve usability, turn the fatal errors into warnings that guide the user into resolving the issue. In this case, a `podman system reset` may be the approriate way for now. [NO TESTS NEEDED] because I have no reliable way to force it. [1] https://github.com/containers/podman/issues/8148#issuecomment-778253474 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #9344 from mheon/cstorage_1246OpenShift Merge Robot2021-02-13
|\ \ \ | |_|/ |/| | Bump c/storage to v1.24.6
| * | Bump c/storage to v1.24.6Matthew Heon2021-02-12
|/ / | | | | | | | | | | Addresses RHBZ#1924562. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #9321 from lsm5/v3.0OpenShift Merge Robot2021-02-12
|\ \ | | | | | | [backport v3.0] hardening flags for fedora rpmbuilds
| * | hardening flags for fedora rpmbuildsLokesh Mandvekar2021-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit sets the CGO_CFLAGS variable for hardening the Fedora rpm binaries. The flags used are the same as those in the official Fedora rpms. Setting the flags in upstream spec would provide early warnings for flag adjustments or other hardening issues. (cherry picked from commit 21deafba85b21aa76ccd464c620dfa45085fc90f) Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #9332 from giuseppe/cgroup-split-v1-backport-to-3.0OpenShift Merge Robot2021-02-12
|\ \ \ | | | | | | | | [3.0] utils: takes the longest path on cgroup v1
| * | | utils: takes the longest path on cgroup v1Giuseppe Scrivano2021-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | now getCgroupProcess takes the longest path on cgroup v1, instead of complaining if the paths are different. This should help when --cgroups=split is used on cgroup v1 and the process cgroups look like: $ cat /proc/self/cgroup 11:pids:/user.slice/user-0.slice/session-4.scope 10:blkio:/ 9:cpuset:/ 8:devices:/user.slice 7:freezer:/ 6:memory:/user.slice/user-0.slice/session-4.scope 5:net_cls,net_prio:/ 4:hugetlb:/ 3:cpu,cpuacct:/ 2:perf_event:/ Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 660a06f2f79fc1edf68e286ee452ceb9dcd5e03a)
| * | | utils: create parent cgroupsGiuseppe Scrivano2021-02-12
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 1b5f3ed24d367cc30432b8a260d1e9465b979c2b)
| * | | utils: ignore unified on cgroupv1 if not presentGiuseppe Scrivano2021-02-12
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 9196a5ce36a559cc0d10230194f93a61b40e870a)
| * | | utils: skip empty linesGiuseppe Scrivano2021-02-12
|/ / / | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit f4fd25a005ae00afe7574bd4eb9a428a6b5c81dd)
* | | Merge pull request #9327 from mheon/30_finalOpenShift Merge Robot2021-02-11
|\ \ \ | |/ / |/| | Bump to v3.0 Final
| * | Bump to v3.0.1-devMatthew Heon2021-02-11
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump to v3.0.0v3.0.0Matthew Heon2021-02-11
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Update release notes for v3.0 finalMatthew Heon2021-02-11
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Rewrite copy-up to use buildah CopierMatthew Heon2021-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old copy-up implementation was very unhappy with symlinks, which could cause containers to fail to start for unclear reasons when a directory we wanted to copy-up contained one. Rewrite to use the Buildah Copier, which is more recent and should be both safer and less likely to blow up over links. At the same time, fix a deadlock in copy-up for volumes requiring mounting - the Mountpoint() function tried to take the already-acquired volume lock. Fixes #6003 Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Display correct value for unlimited ulimitbaude2021-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When doing a container inspect on a container with unlimited ulimits, the value should be -1. But because the OCI spec requires the ulimit value to be uint64, we were displaying the inspect values as a uint64 as well. Simple change to display as an int64. Fixes: #9303 Signed-off-by: baude <bbaude@redhat.com>
| * | make `podman rmi` more robustValentin Rothberg2021-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The c/storage library is subject to TOCTOUs as the central container and image storage may be shared by many instances of many tools. As shown in #6510, it's fairly easy to have multiple instances of Podman running in parallel and yield image-lookup errors when removing them. The underlying issue is the TOCTOU of removal being split into multiple stages of first reading the local images and then removing them. Some images may already have been removed in between the two stages. To make image removal more robust, handle errors at stage two when a given image is not present (anymore) in the storage. Fixes: #6510 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | Allow path completion for podman create/run --rootfsPaul Holzinger2021-02-11
|/ / | | | | | | | | | | | | | | | | | | | | If the --rootfs flag is set podman create/run expect a host path as first argument. The shell completion should provide path completion in that case. [NO TESTS NEEDED] This can manually be verified with `podman run --rootfs [TAB]`. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | Merge pull request #9287 from vrothberg/3.0-vendor-imageOpenShift Merge Robot2021-02-09
|\ \ | | | | | | [3.0] vendor github.com/containers/image v5.10.2
| * | vendor github.com/containers/image v5.10.2Valentin Rothberg2021-02-09
| | | | | | | | | | | | | | | Fixes: #8559 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #9285 from jwhonce/issues/8773-v3.0.0OpenShift Merge Robot2021-02-09
|\ \ \ | |/ / |/| | Add default template functions
| * | Add default template functionsJhon Honce2021-02-09
|/ / | | | | | | | | | | | | | | | | For commands that use the golang template library directly add the compatible template functions Fixes #8773 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #9273 from mheon/backport_api_changesOpenShift Merge Robot2021-02-08
|\ \ | | | | | | [v3.0] Backport final breaking API change to v3.0
| * | Fix per review requestMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | Increase timeouts in some testsMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | Add test for Docker APIv2 waitMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | Implement Docker wait conditionsMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | Improve ContainerEngine.ContainerWait()Matej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | Improve container libpod.Wait*() functionsMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | [NO TESTS NEEDED] style: indendationMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | [NO TESTS NEEDED] fixup: remove debug codeMatej Vasek2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com> <MH: Regenerate bindings> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | [NO TESTS NEEDED] Generated filesMatej Vasek2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com> <MH: Regenerated bindings> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Cleanup bindings for image pullDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove bindings that are not handled over the API. Leaving this one to not use image pull, since this would break progress handling. We should revisit this in the future. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | [NO TESTS NEEDED] Improve generatorMatej Vasek2021-02-08
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | Fix invalid wait condition on killDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using the compatability tests on kill, the kill function goes into an infinite wait loop taking all of the CPU. This change will use the correct wait function and exit properly. Fixes: https://github.com/containers/podman/issues/9206 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | Switch podman image push handlers to use abiDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change API Handlers to use the same functions that the local podman uses. At the same time: Cleanup and pass proper bindings. Remove cli options from podman-remote push. Cleanup manifest push. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | podman-remote ps --external --pod --sort do not work.Daniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixup the bindings and the handling of the --external --por and --sort flags. The --storage option was renamed --external, make sure we use external up and down the stack. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | Fix --arch and --os flags to work correctlyDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently podman implements --override-arch and --overide-os But Podman has made these aliases for --arch and --os. No reason to have to specify --override, since it is clear what the user intends. Currently if the user specifies an --override-arch field but the image was previously pulled for a different Arch, podman run uses the different arch. This PR also fixes this issue. Fixes: https://github.com/containers/podman/issues/8001 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | Switch podman stop/kill/wait handlers to use abiDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change API Handlers to use the same functions that the local podman uses. At the same time: implement remote API for --all and --ignore flags for podman stop implement remote API for --all flags for podman stop Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | Fix handling of container removeDaniel J Walsh2021-02-08
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found several problems with container remove podman-remote rm --all Was not handled podman-remote rm --ignore Was not handled Return better errors when attempting to remove an --external container. Currently we return the container does not exists, as opposed to container is an external container that is being used. This patch also consolidates the tunnel code to use the same code for removing the container, as the local API, removing duplication of code and potential problems. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #9267 from mheon/bump_300_rc3OpenShift Merge Robot2021-02-08
|\ \ | | | | | | Bump to v3.0.0-RC3
| * | Bump to v3.0.0-devMatthew Heon2021-02-08
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | Bump to v3.0.0-RC3v3.0.0-rc3Matthew Heon2021-02-08
|/ / | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #9237 from mheon/backports_300_RC3OpenShift Merge Robot2021-02-05
|\ \ | | | | | | Backports for v3.0,0-RC3
| * | Further release notes for v3.0Matthew Heon2021-02-05
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump remote API version to 3.0.0Matthew Heon2021-02-05
| | | | | | | | | | | | | | | | | | Fixes #9175 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | fix logic when not creating a workdirValentin Rothberg2021-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When resolving the workdir of a container, we may need to create unless the user set it explicitly on the command line. Otherwise, we just do a presence check. Unfortunately, there was a missing return that lead us to fall through into attempting to create and chown the workdir. That caused a regression when running on a read-only root fs. Fixes: #9230 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2025-04-03 16:06:07 +0000