summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Bump to v3.2.0v3.2.0Matthew Heon2021-06-03
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Fix network create macvlan with subnet optionPaul Holzinger2021-06-03
| | | | | | | | | | Creating a macvlan network with the subnet or ipRange option should set the ipam plugin type to `host-local`. We also have to insert the default route. Fixes #10283 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* Final release notes updates for v3.2.0Matthew Heon2021-06-03
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* add ipv6 nameservers only when the container has ipv6 enabledPaul Holzinger2021-06-03
| | | | | | | | | | | | | | | The containers /etc/resolv.conf allways preserved the ipv6 nameserves from the host even when the container did not supported ipv6. Check if the cni result contains an ipv6 address or slirp4netns has ipv6 support enabled and only add the ipv6 nameservers when this is the case. The test needs to have an ipv6 nameserver in the hosts /etc/hosts but we should never mess with this file on the host. Therefore the test is skipped when no ipv6 is detected. Fixes #10158 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Use request context instead of backgroundMatej Vasek2021-06-03
| | | | | | | | | | This prevents goroutine leak: If background context were used then push operation would continue even if client aborted request by closing connection. [NO TESTS NEEDED] Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Merge pull request #10534 from vrothberg/v3.2-fix-10507OpenShift Merge Robot2021-06-02
|\ | | | | [v.3.2] events: support disjunctive filters
| * [v.3.2] events: support disjunctive filtersValentin Rothberg2021-06-02
|/ | | | | | | | | | While different filters are applied in conjunction, the same filter (but with different values) should be applied in disjunction. This allows, for instance, to query the events of two containers. Fixes: #10507 Backport-of: commit 37f39eefee72ec4fb6c6bd71642e9d384c448387 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10532 from edsantiago/mount_colon_zOpenShift Merge Robot2021-06-02
|\ | | | | [v3.2] System tests: add :Z to volume mounts
| * System tests: add :Z to volume mountsEd Santiago2021-06-02
|/ | | | | | | | | | | | | | | | | | selinux-policy-34.9-1.fc34 breaks a behavior we've relied on since (at least) January 2020: - Revert "Add permission open to files_read_inherited_tmp_files() interface" That's probably the correct thing to do, but it breaks our existing tests. Solution: add ':Z' where needed. Tested on Ed's laptop, which has the offending selinux-policy as of 2021-05-31. Tests pass root and rootless. (I mention this because tests will obviously pass in CI, which has a much older selinux-policy). Signed-off-by: Ed Santiago <santiago@redhat.com>
* Merge pull request #10509 from ↵OpenShift Merge Robot2021-06-01
|\ | | | | | | | | vrothberg/v3.2-cherry-pick-53072184192e9952daa3a84bc6f55c15e9ea352e [v3.2] generate systemd: make mounts portable
| * generate systemd: make mounts portableValentin Rothberg2021-05-31
|/ | | | | | | | | | | | | | | | | | | Commit 748826fc88fc fixed a bug where slow mounting of the runroot was causing issues when the units are started at boot. The fix was to add the container's runroot to the required mounts; the graph root has been added as well. Hard-coding the run- and graphroot to the required mounts, however, breaks the portability of units generated with --now. Those units are intended to be running on any machine as, theoreticaly, any user. Make the mounts portable by using the `%t` macro for the run root. Since the graphroot's location varies across root and ordinary users, drop it from the list of required mounts. The graphroot was not causing issues. Fixes: #10493 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10505 from vrothberg/v3.2-vendor-storageOpenShift Merge Robot2021-05-31
|\ | | | | vendor containers/storage@v1.31.3
| * vendor containers/storage@v1.31.3Valentin Rothberg2021-05-31
|/ | | | | | | | * store: ReloadIfChanged propagates errors from Modified() * store: load additional image stores once * store: fix graphLock reload Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10484 from vrothberg/3.2-vendor-commonDaniel J Walsh2021-05-27
|\ | | | | vendor containers/common@v0.38.5
| * vendor containers/common@v0.38.5Valentin Rothberg2021-05-27
|/ | | | | | * pull: don't resolve short names on explicit docker:// reference Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10473 from mheon/bump_320_rc3OpenShift Merge Robot2021-05-26
|\ | | | | [CI:DOCS] Bump to v3.2.0-RC3
| * Bump to v3.2.0-devMatthew Heon2021-05-26
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v3.2.0-RC3v3.2.0-rc3Matthew Heon2021-05-26
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #10461 from mheon/rc3_backportsOpenShift Merge Robot2021-05-26
|\ | | | | Backports for v3.2.0-RC3
| * Update release notes for v3.2.0-RC3Matthew Heon2021-05-25
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Fix race on podman start --allDaniel J Walsh2021-05-25
| | | | | | | | | | | | | | | | | | Make sure all containers exit after start There is a race condition in that container could still be running when we attempt to remove them. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Fix race condition in running ls container in a podDaniel J Walsh2021-05-25
| | | | | | | | | | | | | | | | | | | | All of the tests has an assumption that RunLsContainer and RunLsContainerInPod completes the container before returning. But since the container is running in back ground mode, the container could be still running before tools attempt to remove it. Removing the "-d" from the command fixes the container to match the assumption. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * docs: --cert-dir: point to containers-certs.d(5)Valentin Rothberg2021-05-25
| | | | | | | | | | | | | | | | | | Point to containers-certs.d(5) for details on the default paths, the lookup logic and the structure of these directories. Previously, the man pages stated that the default path would be in `/etc/containers/...` which is not entirely and a red herring for users (see #10116). Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Handle hard links in different directoriesDaniel J Walsh2021-05-25
| | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/10444 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Improve OCI Runtime errorDaniel J Walsh2021-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | ErrOCIRuntimeNotFound error is misleading. Try to make it more understandable to the user that the OCI Runtime IE crun or runc is not missing, but the command they attempted to run within the container is missing. [NO TESTS NEEDED] Regular tests should handle this. Fixes: https://github.com/containers/podman/issues/10432 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Handle hard links in remote buildsDaniel J Walsh2021-05-25
| | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/9893 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Podman info add support for status of cgroup controllersflouthoc2021-05-25
| | | | | | | | Signed-off-by: flouthoc <flouthoc.git@gmail.com>
| * Drop container does not exist on removal to debugfDaniel J Walsh2021-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have race conditions where a container can be removed by two different processes when running podman --remove rm. It can be cleaned up in the API or by the conmon executing podman container cleanup. When we fail to remove a container that does not exists we should not be printing errors or warnings, we should just debug the fact. [NO TESTS NEEDED] Since this is a race condition it is difficult to test. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Downgrade API service routing table loggingJhon Honce2021-05-25
| | | | | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] * Log the routing table output at Trace vs. Debug level. Reduce noise in debugging output. * Tweak SDNotify message to report Warn when it fails. Previously failures were silent. Signed-off-by: Jhon Honce <jhonce@redhat.com>
| * add libimage eventsValentin Rothberg2021-05-25
| | | | | | | | | | | | | | | | | | | | | | libimage now supports events which `libpod.Runtime` now uses for image events. Signed-off-by: Valentin Rothberg <rothberg@redhat.com> <MH: Removed vendor bits, kept other changes> Signed-off-by: Matthew Heon <mheon@redhat.com>
| * docs: generate systemd: XDG_RUNTIME_DIRValentin Rothberg2021-05-25
| | | | | | | | | | | | | | A conversation on the customer portal suggests that to add an extra note about the requirement of XDG_RUNTIME_DIR to be set. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Fix problem copying files when container is in host pid namespaceDaniel J Walsh2021-05-25
|/ | | | | | | | | | | | | | When attempting to copy files into and out of running containers within the host pidnamespace, the code was attempting to join the host pidns again, and getting an error. This was causing the podman cp command to fail. Since we are already in the host pid namespace, we should not be attempting to join. This PR adds a check to see if the container is in NOT host pid namespace, and only then attempts to join. Fixes: https://github.com/containers/podman/issues/9985 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #10418 from mheon/bump_320_rc2OpenShift Merge Robot2021-05-20
|\ | | | | [CI:DOCS] Bump to v3.2.0-RC2
| * Bump to v3.2.0-devMatthew Heon2021-05-20
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v3.2.0-RC2v3.2.0-rc2Matthew Heon2021-05-20
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #10415 from mheon/32_vendorOpenShift Merge Robot2021-05-20
|\ | | | | [v3.2] Update vendors of container projects
| * update c/commonValentin Rothberg2021-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update containers common to the latest HEAD. Some bug fixes in libimage forced us to have a clearer separation between ordinary images and manifest lists. Hence, when looking up manifest lists without recursing into any of their instances, we need to use `LookupManifestList()`. Also account for some other changes in c/common (e.g., the changed order in the security labels). Further vendor the latest HEAD from Buildah which is required to get the bud tests to pass. Signed-off-by: Valentin Rothberg <rothberg@redhat.com> <MH: Stripped out vendor bits - just left remaining changes> Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Update Cirrus DEST_BRANCH to v3.2Matthew Heon2021-05-20
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Updated vendors of c/image, c/storage, BuildahMatthew Heon2021-05-20
|/ | | | | | Last PR before 3.2.0-RC2 Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #10388 from mheon/release_notes_320rc2OpenShift Merge Robot2021-05-20
|\ | | | | [CI:DOCS] Release notes for v3.2.0-RC2
| * Initial release notes for v3.2.0-RC2Matthew Heon2021-05-19
| | | | | | | | | | | | | | Missing the updated vendor bits, but the vendor dance is not yet done. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Add script for identifying commits in release branchesMatthew Heon2021-05-18
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | One of the worst parts of a Podman release is writing the release notes. It requires manually going through all merged commits since the last release, figuring out what was actually done, and writing a small blurb about what was fixed. The worst part of this is the difficulty in finding the commits that were actually included in previous releases - our extensive backports to prior releases mean that there are usually dozens of commits that were included in a prior release, but do not have a matching SHA (as the original author did not do the backport, and often the commit required massaging to cherry-pick in). This script automates the job of finding commits in one release branch that are not in another, with filtering to remove most cherry-picked commits. It makes my life a lot easier during releases, so I figured I'd include it in hack/ so anyone else stuck with the enjoyable task of writing release notes can have a slightly easier life. The script is written in absolutely terrible Ruby and its performance is absolutely terrible, but you only need to run it once per major release and a 30-second wait to generate the list of commits to include isn't bad. Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #10363 from vrothberg/fix-10350OpenShift Merge Robot2021-05-17
|\ | | | | image prune: remove unused images only with `--all`
| * image prune: remove unused images only with `--all`Valentin Rothberg2021-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a regression in `podman image prune` where unused images were accidentally removed even when `--all=false`. Extend and partially rewrite the e2e tests to make sure we're not regressing again in the future. Fixing the aforementioned issue revealed another issue in the default prune filter. While prune should remove all "dangling" images (i.e., those without tag), it removed only "intermediate" ones; dangling images without children. Remove the mistaken comment from the libimage migration. Also clarify the help message and man page. Fixes: #10350 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #9972 from bblenard/issue-5651-hostname-for-container-gatewayOpenShift Merge Robot2021-05-17
|\ \ | | | | | | Add host.containers.internal entry into container's etc/hosts
| * | Add host.containers.internal entry into container's etc/hostsBaron Lenardson2021-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds the entry `host.containers.internal` to the `/etc/hosts` file within a new containers filesystem. The ip address is determined by the containers networking configuration and points to the gateway address for the containers networking namespace. Closes #5651 Signed-off-by: Baron Lenardson <lenardson.baron@gmail.com>
* | | Merge pull request #10356 from Luap99/network-reload-rootlessOpenShift Merge Robot2021-05-17
|\ \ \ | |_|/ |/| | podman network reload add rootless support
| * | podman network reload add rootless supportPaul Holzinger2021-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow podman network reload to be run as rootless user. While it is unlikely that the iptable rules are flushed inside the rootless cni namespace, it could still happen. Also fix podman network reload --all to ignore errors when a container does not have the bridge network mode, e.g. slirp4netns. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #10357 from srcshelton/patch-1OpenShift Merge Robot2021-05-17
|\ \ \ | |/ / |/| | Update to actions/stale@v3
| * | Use more recent `stale` release...Stuart Shelton2021-05-16
|/ / | | | | | | | | | | … as currently with `v1`, `remove-stale-when-updated` is set but isn't causing labels to be updated when comments are added. Signed-off-by: Stuart Shelton <stuart@shelton.me>