summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #9200 from edsantiago/make_ginkgo_refactorOpenShift Merge Robot2021-02-02
|\ | | | | Makefile: refactor ginkgo * ginkgo-remote
| * Makefile: refactor ginkgo * ginkgo-remoteEd Santiago2021-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create a new common target, ginkgo-run, with the main ginkgo test incantation; ginkgo and ginkgo-remote now invoke that, with a clearer distinction between their arguments. Reason for this: 'make remoteintegration' was not generating ginkgo logs in CI. Reason: '-debug' option was missing from the ginkgo incantation. Reason: impossibility of maintaining duplicate long-complicated lines. This PR distills the common aspects, making the differences clearer between local & remote. IMPORTANT NOTE: '-nodes 3' was also missing from remote ginkgo. This PR adds it. If this was intentionally omitted, please let me know (with reasons) so I can refactor that too. [NO TESTS NEEDED] Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #9185 from mheon/pod_no_networkOpenShift Merge Robot2021-02-02
|\ \ | | | | | | Allow pods to use --net=none
| * | Allow pods to use --net=noneMatthew Heon2021-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need an extra field in the pod infra container config. We may want to reevaluate that struct at some point, as storing network modes as bools will rapidly become unsustainable, but that's a discussion for another time. Otherwise, straightforward plumbing. Fixes #9165 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #9116 from iwita/ls-volumes-before-pruningOpenShift Merge Robot2021-02-02
|\ \ \ | |_|/ |/| | List volumes before pruning
| * | list volumes before pruningAchilleas Tzenetopoulos2021-01-31
| | | | | | | | | | | | Signed-off-by: Achilleas Tzenetopoulos <atzenetopoulos@gmail.com>
* | | Merge pull request #9195 from ↵OpenShift Merge Robot2021-02-02
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.15.0 Bump github.com/onsi/ginkgo from 1.14.2 to 1.15.0
| * | | Bump github.com/onsi/ginkgo from 1.14.2 to 1.15.0dependabot-preview[bot]2021-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.14.2 to 1.15.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.14.2...v1.15.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #9192 from mheon/release_notes_300OpenShift Merge Robot2021-02-02
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Update release notes for v3.0.0
| * | | | Update release notes for v3.0.0Matthew Heon2021-02-01
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #9189 from baude/macvlandriverOpenShift Merge Robot2021-02-02
|\ \ \ \ | |_|/ / |/| | | add macvlan as a supported network driver
| * | | add macvlan as a supported network driverbaude2021-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of using the --macvlan to indicate that you want to make a macvlan network, podman network create now honors the driver name of *macvlan*. Any options to macvlan, like the parent device, should be specified as a -o option. For example, -o parent=eth0. the --macvlan option was marked as deprecated in the man page but is still supported for the duration of 3.0. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #9190 from edsantiago/make_completionsOpenShift Merge Robot2021-02-01
|\ \ \ \ | | | | | | | | | | New 'make completions' target
| * | | | New 'make completions' targetEd Santiago2021-02-01
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Generate shell completion files for podman and podman-remote and for all known shells (bash, fish, zsh). Fix Readme file in completions dir: it suggested running 'make completion', singular; no such target existed. Since the install target is plural, I choose to make the new target plural also. This is intended for use in CI some day, in a check such as: (in contrib/cirrus/runner.sh): make completions SUGGESTION="run 'make completions' and commit all changes" ./hack/tree_status.sh The goal would be to make sure that any new podman subcommands or flags are accompanied by their corresponding shell helpers on all commits. IT IS NOT POSSIBLE TO ENFORCE THIS NOW. As I understand it, Cobra is slow to incorporate community PRs, so the podman team has chosen to sneak in completion files generated by an unreleased and un-vendored version of Cobra. Running 'make completions' right now would clobber those and result in a diminished user experience. I'm submitting this anyway as a stepping-stone toward that future day when we can create such a CI hook. [NO TESTS NEEDED] Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #9177 from ↵OpenShift Merge Robot2021-02-01
|\ \ \ \ | |/ / / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.13.0 Bump github.com/rootless-containers/rootlesskit from 0.12.0 to 0.13.0
| * | | Bump github.com/rootless-containers/rootlesskit from 0.12.0 to 0.13.0dependabot-preview[bot]2021-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.12.0 to 0.13.0. - [Release notes](https://github.com/rootless-containers/rootlesskit/releases) - [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.12.0...v0.13.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #9178 from Luap99/fix-9176OpenShift Merge Robot2021-02-01
|\ \ \ \ | |_|/ / |/| | | Fix podman generate systemd --new special char handling
| * | | Fix podman generate systemd --new special char handlingPaul Holzinger2021-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a systemd unit dollar and percent signs are used for variables. A backslash is used for escape sequences. If any of these characters are used in the create command we have to properly escape them so systemd does not try to interpret them. Fixes #9176 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #9168 from Luap99/fix-pod-create-network-parsingOpenShift Merge Robot2021-02-01
|\ \ \ \ | | | | | | | | | | Fix --network parsing for podman pod create
| * | | | Fix --network parsing for podman pod createPaul Holzinger2021-01-31
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `--network` flag is parsed differently for `podman pod create`. This causes confusion and problems for users. The extra parsing logic ignored unsupported network options such as `none`, `container:...` and `ns:...` and instead interpreted them as cni network names. Tests are added to ensure the correct errors are shown. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #9051 from rhatdan/rmOpenShift Merge Robot2021-02-01
|\ \ \ \ | |_|/ / |/| | | Switch podman stop/kill/wait handlers to use abi
| * | | Switch podman stop/kill/wait handlers to use abiDaniel J Walsh2021-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change API Handlers to use the same functions that the local podman uses. At the same time: implement remote API for --all and --ignore flags for podman stop implement remote API for --all flags for podman stop Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #9173 from mlegenovic/api_fixesOpenShift Merge Robot2021-02-01
|\ \ \ \ | | | | | | | | | | Endpoint that lists containers does not return correct Status value
| * | | | Endpoint that lists containers does not return correct Status valueMilivoje Legenovic2021-01-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eclipse and Intellij Docker plugin determines the state of the container via the Status field, returned from /containers/json call. Podman always returns empty string, and because of that, both IDEs show the wrong state of the container. Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | | | | Merge pull request #9151 from rhatdan/mountOpenShift Merge Robot2021-02-01
|\ \ \ \ \ | | | | | | | | | | | | Docker ignores mount flags that begin with constency
| * | | | | Docker ignores mount flags that begin with constencyDaniel J Walsh2021-01-30
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1915332 ``` According to the Docker docs, the consistency option should be ignored on Linux. the possible values are 'cached', 'delegated', and 'consistent', but they should be ignored equally. This is a widely used option in scripts run by developer machines, as this makes file I/O less horribly slow on MacOS. ``` Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #9138 from mlegenovic/masterOpenShift Merge Robot2021-02-01
|\ \ \ \ \ | |/ / / / |/| | | | podman generate kube ignores --network=host
| * | | | podman generate kube ignores --network=hostMilivoje Legenovic2021-01-30
| |/ / / | | | | | | | | | | | | Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | | | Merge pull request #9063 from cevich/master_fix_validateOpenShift Merge Robot2021-01-30
|\ \ \ \ | |/ / / |/| | | Cirrus: Fix running Validate task on branches
| * | | Cirrus: Fix running Validate task on branchesChris Evich2021-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Followup to dbb9943 Despite skipping the `Smoke` check, it was observed on a *new* branch, the `validate` task (specifically `git-validation`) will fail. This is because: * `$CIRRUS_LAST_GREEN_CHANGE` will be empty on a new branch. * `$CIRRUS_BASE_SHA` is always empty for runs triggered by branch-push * `$EPOCH_TEST_COMMIT` will be set to `YOU_FOUND_A_BUG`. Fix this by eliminating the `Smoke` task entirely, simplifying all the `make validate` operations into the `validate` cirrus task. Ensure this task does not run when a new branch or tag is pushed. Also, eliminate the `$CIRRUS_BUILD_ID` value as it's confusing and not actually used anywhere. It was formerly used for building VM images, but this has moved to another repo entirely. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #9161 from baude/macosbuildOpenShift Merge Robot2021-01-29
|\ \ \ \ | | | | | | | | | | [CI:DOCS]build instructions for macOS
| * | | | [CI:DOCS]build instructions for macOSbaude2021-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add instructions on how to build podman on macOS. big thanks to acui for help in getting this written down. Fixes: #9032 Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #9160 from rhatdan/VENDOROpenShift Merge Robot2021-01-29
|\ \ \ \ \ | | | | | | | | | | | | Vendor in containers/buildah v1.19.3
| * | | | | Vendor in containers/buildah v1.19.3Daniel J Walsh2021-01-29
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #9150 from baude/playkubednsOpenShift Merge Robot2021-01-29
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Honor custom DNS in play|generate kube
| * | | | | Honor custom DNS in play|generate kubebaude2021-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when creating kubernetes yaml from containers and pods, we should honor any custom dns settings the user provided. in the case of generate kube, these would be provided by --dns, --dns-search, and --dns-opt. if multiple containers are involved in the generate, the options will be cumulative and unique with the exception of dns-opt. when replaying a kube file that has kubernetes dns information, we now also add that information to the pod creation. the options for dnspolicy is not enabled as there seemed to be no direct correlation between kubernetes and podman. Fixes: #9132 Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #9144 from vrothberg/fix-9134OpenShift Merge Robot2021-01-29
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Revert "podman build --pull: use correct policy"
| * | | | | podman build --pull: refine help message and docsValentin Rothberg2021-01-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refine and correct the wording of the `--pull` flag in the help message and the docs. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | | Revert "podman build --pull: use correct policy"Valentin Rothberg2021-01-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 15caebfe561952eaadd4896b7efb56f26724cce5. The previous behaviour of `--pull` to *always* attempt to pull the image and error out if the pull failed aligns with Docker. Since Podman aims at feature parity with Docker, the `--pull` behaviour must match. Fixes: #9134 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #9149 from rhatdan/docsOpenShift Merge Robot2021-01-29
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Podman-remote push can support --format
| * | | | | Podman-remote push can support --formatDaniel J Walsh2021-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix man page to document podman push --format fully. Also found that push was not handling the tlsverify so fixed this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #9143 from cevich/static_remoteOpenShift Merge Robot2021-01-29
|\ \ \ \ \ \ | | | | | | | | | | | | | | Cirrus: Build static podman-remote
| * | | | | | Cirrus: Build static podman-remoteChris Evich2021-01-28
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit, the "Static Build" task only produced a `bin/podman`. Update this to also include a `bin/podman-remote` binary. Update the pr-should-include-tests checker to ignore the `nix` directory, which isn't applicable. Lastly, restore the static build task to 'required' for CI success. Leaving the comment inplace in case it needs to be bypassed in the future on short notice. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | Merge pull request #9156 from ↵OpenShift Merge Robot2021-01-29
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/image/v5-5.10.1 Bump github.com/containers/image/v5 from 5.10.0 to 5.10.1
| * | | | | | Bump github.com/containers/image/v5 from 5.10.0 to 5.10.1dependabot-preview[bot]2021-01-29
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.10.0 to 5.10.1. - [Release notes](https://github.com/containers/image/releases) - [Commits](https://github.com/containers/image/compare/v5.10.0...v5.10.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #9133 from rhatdan/pull1OpenShift Merge Robot2021-01-29
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Cleanup bindings for image pull
| * | | | | Cleanup bindings for image pullDaniel J Walsh2021-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove bindings that are not handled over the API. Leaving this one to not use image pull, since this would break progress handling. We should revisit this in the future. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #9110 from rhatdan/cgroupsOpenShift Merge Robot2021-01-28
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Don't fail if one of the cgroups is not setup
| * | | | | Don't fail if one of the cgroups is not setupDaniel J Walsh2021-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is fairly common for certain cgroups controllers to not be enabled on a system. We should Warn when this happens versus failing, when doing podman stats command. This way users can get information from the other controllers. Fixes: https://github.com/containers/podman/issues/8588 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #9140 from ↵OpenShift Merge Robot2021-01-28
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/image/v5-5.10.0 Bump github.com/containers/image/v5 from 5.9.0 to 5.10.0
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-16 07:17:44 +0000