| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
sudo is not required when running as root, and # indicates
that you are already root. $ indicates you are not root.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
|
|
|
|
|
|
| |
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes: #304
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made a change to make sure that the output paths of podman inspect
matches that of docker inspect. For example to get the stop signal
you should be able to do podman inspect ctr --format {{.Config.StopSignal}}
and the same thing in docker will give the same results.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #292
Approved by: rhatdan
|
|
|
|
|
|
|
| |
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes: #299
Approved by: rhatdan
|
|
|
|
|
|
|
| |
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes: #299
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
podman search queries a registry for a matching image and prints
the output.
I added a new flag called "registry" giving the user the option
to search a specific registry if they don't want to search all
their default registries.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #241
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
| |
Latest containers/image has support for searching registries.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #241
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
| |
Otherwise causes rpmlint error for manpage
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Closes: #296
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate the following to the ginkgo integration tests:
* images
* import
* inspect
* logs
* run_dns
Signed-off-by: baude <bbaude@redhat.com>
Closes: #295
Approved by: mheon
|
|
|
|
|
|
|
|
|
| |
sysfs should be mounted rw for a privileged container.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #279
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
| |
Migrate the diff, exec, export, and history bats tests to
the ginkgo test suite.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #287
Approved by: baude
|
|
|
|
|
|
|
|
|
| |
Wrote a small primer to setup for integration testing.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #288
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue #169 describes a common failure when running podman top where
if the commands inside the container container a space in them, podman
will panic. This was occuring because we take the output from ps and
attempt to format it nicely for output and things like JSON. Given that
this cannot be predicted or dealt with programatically, the decision was
made to deprecate the format switch and simply output what ps provides
us.
Migrated top integration tests to ginkgo.
Resolves Issue: https://github.com/projectatomic/libpod/issues/169
Signed-off-by: baude <bbaude@redhat.com>
Closes: #291
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to have sd_notify from systemd to work in containers
we need to pass down the NOTIFY_SOCKET environment variable to
the container.
LISTEN_FDS, tells the application inside of the container to use
socket activation and grab the FDS that are leaked into the container.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #271
Approved by: umohnani8
|
|
|
|
|
|
|
| |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #135
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate create and commit bats tests to the ginkgo
test suite. In doing so, some structures had to be
moved to pkg/podmanstructs/podmanstructs.go so we
could do better verification of test results.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #286
Approved by: rhatdan
|
|\
| |
| | |
Update containerd/cgroups to fix perf issue
|
| |
| |
| |
| | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
|\ \
| | |
| | | |
Set default configuration container type annotation to sandbox
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows podman to provide sufficient hints to
start containers with Intel Clear Containers:
https://github.com/clearcontainers/runtime/blob/master/docs/architecture/architecture.md#oci-annotations
Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
podman login would add on the registry name to the cert-dir path
making containers/image look in a directory that did not exist for
certificates.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #283
Approved by: rhatdan
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| | |
Migrate kill tests to the ginkgo suite and remove the
podman_kill bats.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #281
Approved by: baude
|
| |
| |
| |
| |
| |
| |
| | |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Closes: #280
Approved by: mheon
|
|/
|
|
|
|
|
|
|
|
| |
When network == none, the container should only have a
loopback interface and that's it.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #176
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
| |
To account for more path possibilities, we now iterate
a string array of possible paths to try and find paths
to runc and conmon.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #278
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate ps, pull, push, and rm from bats to ginkgo.
Also, fixed a conditional issue with adding ports
when an image defines the port and the user wants
to override it.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #277
Approved by: baude
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ubuntu installs runc to /usr/sbin/runc so we now account
for that. Also, added small check when creating a new
runtime that if we cannot find the runc binary, we bail
out.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #276
Approved by: baude
|
|
|
|
|
|
|
|
|
| |
Adding in how to install and run podman on Ubuntu.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #275
Approved by: baude
|
|
|
|
|
|
|
|
|
|
| |
The container's hostname should be set as an environment
variable for the container.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #273
Approved by: baude
|
|
|
|
|
|
|
|
|
|
| |
Migrate the start, stats, and stop integration tests to the
Ginkgo style.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #274
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
| |
Normal Stop should not need a timeout, and should use the default
Add a function that does accept a timeout aside it
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes: #272
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the ginkgo integration test framework for
podman. As tests are migrated from bats to ginkgo, we will
still run both integration suites. When a test is migrated,
we remove the tests from bats at that time. All new tests
should be just for the ginkgo framework.
One exception is that we only run the ginkgo suit in the
travis/ubuntu environment. The CentOS and Fedora PAPR nodes
will more than cover those.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #261
Approved by: baude
|
|\
| |
| | |
Remove libkpod
|
| |
| |
| |
| | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #269
Approved by: TomSweeneyRedHat
|
|\ \
| |/
|/| |
Add containernetworking-cni to install reqs
|
|/
|
|
| |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
When the Go template was given with \t in between fields,
the \t was not being recognized as a tab.
Fixes that issue.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #265
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
| |
conmon should not be built in two different places.
conmon is now a separate package in Fedora so we can just
add requires, for use on Ubuntu we can just require cri-o to
be installed.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #151
Approved by: mheon
|
|
|
|
|
|
|
| |
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes: #263
Approved by: umohnani8
|
|
|
|
|
|
|
|
|
| |
From CRI-O #1288
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes: #263
Approved by: umohnani8
|
|
|
|
|
|
|
|
|
|
|
| |
Add results check to make sure the container is not shows up after
it is stopped. And also add some debug lines to help to figure out
which step has problem if case failed.
Signed-off-by: Yiqiao Pu <ypu@redhat.com>
Closes: #264
Approved by: rhatdan
|
|
|
|
|
|
|
| |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #255
Approved by: mheon
|
|
|
|
|
|
|
|
|
|
|
|
| |
QE found issues with formatting the go template and
the man page was lacking information.
Changed the format of the output to match latest docker.
Add shortID function that returns the truncated ID
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #258
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the Created At value to match the format of docker ps
and fixed the value for Running For to reflect the time elapsed
since the container has been started. Initially it was showing
the time elapsed since the container was created.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #257
Approved by: rhatdan
|
|
|
|
|
|
|
|
|
|
| |
The order of the flags was casuing issue.
Enabled SkipArgReorder to fix the problem.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes: #259
Approved by: rhatdan
|
|\
| |
| | |
podman port
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
podman port reports the port mappings per container. it can be used
to report the ports ofa single container or latest container or all
containers.
in the case of a single container, the user can add an option filter for
port and protocol.
Signed-off-by: baude <bbaude@redhat.com>
|