summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Rewrite Rename backend in a more atomic fashionMatthew Heon2021-03-02
| | | | | | | | | | | | | Move the core of renaming logic into the DB. This guarantees a lot more atomicity than we have right now (our current solution, removing the container from the DB and re-creating it, is *VERY* not atomic and prone to leaving a corrupted state behind if things go wrong. Moving things into the DB allows us to remove most, but not all, of this - there's still a potential scenario where the c/storage rename fails but the Podman rename succeeds, and we end up with a mismatched state. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #9561 from Luap99/update-ocicniOpenShift Merge Robot2021-03-02
|\ | | | | Bump github.com/cri-o/ocicni to latest master
| * Bump github.com/cri-o/ocicni to latest masterPaul Holzinger2021-03-01
| | | | | | | | | | | | Fixes #9472 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | Merge pull request #9563 from mlegenovic/masterOpenShift Merge Robot2021-03-02
|\ \ | | | | | | Compat api containers/json Ports field is null
| * | Compat api containers/json Ports field is nullMilivoje Legenovic2021-03-02
| |/ | | | | | | | | | | Fixes #9553 Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | Merge pull request #9565 from AkihiroSuda/bump-rootlesskit-20210302OpenShift Merge Robot2021-03-02
|\ \ | |/ |/| Bump RootlessKit v0.14.0-beta.0
| * Bump RootlessKit v0.14.0-beta.0Akihiro Suda2021-03-02
|/ | | | | | https://github.com/rootless-containers/rootlesskit/releases/tag/v0.14.0-beta.0 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
* Merge pull request #9556 from jwhonce/wip/dockerOpenShift Merge Robot2021-03-01
|\ | | | | Refactor python tests to run against python3.9
| * Refactor python tests to run against python3.9Jhon Honce2021-03-01
|/ | | | | | | | * Introduce sub-package compat to meet packaging and import requirements * Update documenation for running tests * Add requirements.txt to improve IDE support Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #9555 from edsantiago/apiv2_test_readabilityOpenShift Merge Robot2021-03-01
|\ | | | | APIv2 tests: make more maintainable
| * APIv2 tests: make more maintainableEd Santiago2021-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While I wasn't looking, some completely unreadable cruft crept in here, and it's totally my fault: I never knew you could pass JSON to a GET query. Everyone who DID know that, did so, but had to URL-escape it into a completely gobbledygook mess to make curl happy. Solution: trivial, do the URL-escaping in 't' itself. I just never realized that was needed. I'm so sorry. I hope this helps. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #9142 from cevich/releaseprocessOpenShift Merge Robot2021-03-01
|\ \ | | | | | | [CI:DOCS]First pass at release process
| * | [CI:DOCS] Improve release process docsChris Evich2021-03-01
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | [CI:DOCS]First pass at release processbaude2021-02-09
| | | | | | | | | | | | | | | | | | | | | | | | take the existing release process from the google docs and get it checked into our git repo. organized the process by adding task headers and steps beneath them where possible. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #9542 from vrothberg/rmi-hardeningOpenShift Merge Robot2021-03-01
|\ \ \ | |_|/ |/| | podman rmi: handle corrupted storage better
| * | podman rmi: handle corrupted storage betterValentin Rothberg2021-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The storage can easily be corrupted when a build or pull process (or any process *writing* to the storage) has been killed. The corruption surfaces in Podman reporting that a given layer could not be found in the layer tree. Those errors must not be fatal but only logged, such that the image removal may continue. Otherwise, a user may be unable to remove an image. [NO TESTS NEEDED] as I do not yet have a reliable way to cause such a storage corruption. Reported-in: https://github.com/containers/podman/issues/8148#issuecomment-787598940 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #9531 from Luap99/fix-9526OpenShift Merge Robot2021-03-01
|\ \ \ | |/ / |/| | compat api network ls accept both format options
| * | compat api network ls accept both format optionsPaul Holzinger2021-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Docker allows both the old `map[string]map[string]bool` and the newer `map[string][]string` for the filter param so we should too. Fixes #9526 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #9509 from mlegenovic/masterOpenShift Merge Robot2021-03-01
|\ \ \ | | | | | | | | Correct compat images/create?fromImage response
| * | | Correct compat images/create?fromImage responseMilivoje Legenovic2021-02-26
| | | | | | | | | | | | | | | | Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
* | | | Merge pull request #9527 from rhatdan/hostsOpenShift Merge Robot2021-03-01
|\ \ \ \ | | | | | | | | | | Enable no_hosts from containers.conf
| * | | | Enable no_hosts from containers.confDaniel J Walsh2021-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we have no good way to enable this on the server side, we will just allow it to be set on the client side. This should solve almost all cases. Partially fixes: https://github.com/containers/podman/issues/9500 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #9533 from elimisteve/patch-3OpenShift Merge Robot2021-02-27
|\ \ \ \ \ | |_|_|/ / |/| | | | [CI:DOCS] podman-image-sign.1.md: typo fix
| * | | | podman-image-sign.1.md: typo fixSteve Phillips2021-02-27
|/ / / / | | | | | | | | | | | | | | | | | | | | identify -> identity Signed-off-by: Steve Phillips <steve@tryingtobeawesome.com>
* | | | Merge pull request #8749 from edsantiago/upgrade_testOpenShift Merge Robot2021-02-26
|\ \ \ \ | |/ / / |/| | | podman upgrade tests
| * | | podman upgrade testsEd Santiago2021-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initial validation of using podman-in-podman to create an old-podman root, then use new-podman to play with the containers created therein. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #9505 from TristanCacqueray/masterOpenShift Merge Robot2021-02-26
|\ \ \ \ | | | | | | | | | | [CI:DOCS] swagger: removes the schema type for PodSpecGenerator $ref
| * | | | swagger: removes the schema type for PodSpecGenerator $refTristan Cacqueray2021-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using a $ref, the type is ignored and it can confuse the openapi codegen and make it fails with this error: attribute paths.'/libpod/pods/create'(post).[create].type is unexpected This change removes the schema type attribute. Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
* | | | | Merge pull request #9491 from edsantiago/testimage_multiarchOpenShift Merge Robot2021-02-25
|\ \ \ \ \ | | | | | | | | | | | | system test image: build it multiarch
| * | | | | system test image: build it multiarchEd Santiago2021-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | buildah now supports running under emulation[1] as well as creating manifests. Use those features to create a multiarch testimage that can be used to test podman on other arches. [1] on Fedora 33, this requires the qemu-user-static package We also build a new :00000001 image, replacing :00000000, because (sigh) some tests try to run 'true' in the container. Include instructions on building said image. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #9518 from baude/pruneremotecommandOpenShift Merge Robot2021-02-25
|\ \ \ \ \ \ | | | | | | | | | | | | | | prune remotecommand dependency
| * | | | | | prune remotecommand dependencybaude2021-02-25
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | prune a dependency that was only being used for a simple struct. Should correct checksum issue on tarballs [NO TESTS NEEDED] Fixes: #9355 Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #9487 from giuseppe/split-test-named-hierarchiesOpenShift Merge Robot2021-02-25
|\ \ \ \ \ \ | | | | | | | | | | | | | | test: ignore named hierarchies for cgroups=split
| * | | | | | test: ignore named hierarchies for cgroups=splitGiuseppe Scrivano2021-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ignore named hierarchies for the --cgroups=split test as crun does not set it. Closes: https://github.com/containers/podman/pull/9302#issuecomment-784157272 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | | Merge pull request #8010 from ParkerVR/format-networks/listOpenShift Merge Robot2021-02-25
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | networks/list.go updates for --format
| * | | | | | Updated based on Jhonce commentsParker Van Roy2021-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added ID to default removed outdated imports slight refactor Test Network Headers added to network_test.go Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
| * | | | | | updated common to 0.35.0Parker Van Roy2021-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
| * | | | | | Refactored fileParker Van Roy2021-02-24
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | moved --format to templateOut() Rm parse package except JSON Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
* | | | | | Merge pull request #9504 from kierdavis/fix-manpageOpenShift Merge Robot2021-02-24
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | [CI:DOCS] podman-system-connection.1.md: fix copy/paste error
| * | | | | podman-system-connection.1.md: fix copy/paste errorKier Davis2021-02-24
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Kier Davis <me@kierdavis.com>
* | | | | Merge pull request #9494 from mheon/sort_capsOpenShift Merge Robot2021-02-24
|\ \ \ \ \ | | | | | | | | | | | | Sort CapDrop in inspect to guarantee order
| * | | | | Sort CapDrop in inspect to guarantee orderMatthew Heon2021-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The order of CapAdd when inspecting containers is deterministic. However, the order of CapDrop is not (for unclear reasons). Add a quick sort on the final array to guarantee a consistent order. Fixes #9490 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | Merge pull request #9501 from Luap99/dns-search-cniOpenShift Merge Robot2021-02-24
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Add dns search domains from cni response to resolv.conf
| * | | | | Add dns search domains from cni response to resolv.confPaul Holzinger2021-02-24
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes slow local host name lookups. see containers/dnsname#57 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | Merge pull request #9497 from Luap99/fix-9496OpenShift Merge Robot2021-02-23
|\ \ \ \ \ | | | | | | | | | | | | Network connect error if net mode is not bridge
| * | | | | Network connect error if net mode is not bridgePaul Holzinger2021-02-23
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only the the network mode bridge supports cni networks. Other network modes cannot use network connect/disconnect so we should throw a error. Fixes #9496 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | Merge pull request #9485 from vrothberg/fix-9479OpenShift Merge Robot2021-02-23
|\ \ \ \ \ | |/ / / / |/| | | | container removal: handle already removed containers
| * | | | container removal: handle already removed containersValentin Rothberg2021-02-23
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit d54478d8eaec, a container's lock is released before attempting to stop it via the OCI runtime. This opened the window for various kinds of race conditions. One of them led to #9479 where the removal+cleanup sequences of a `run --rm` session overlapped with `rm -af`. Make both execution paths more robust by handling the case of an already removed container. Fixes: #9479 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #9483 from ↵OpenShift Merge Robot2021-02-23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.13.2 Bump github.com/rootless-containers/rootlesskit from 0.13.1 to 0.13.2
| * | | | Bump github.com/rootless-containers/rootlesskit from 0.13.1 to 0.13.2dependabot-preview[bot]2021-02-23
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.13.1 to 0.13.2. - [Release notes](https://github.com/rootless-containers/rootlesskit/releases) - [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.13.1...v0.13.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>