summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Move RenumberLocks into runtime initMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | We can't do renumbering after init - we need to open a potentially invalid locks file (too many/too few locks), and then potentially delete the old locks and make new ones. We need to be in init to bypass the checks that would otherwise make this impossible. This leaves us with two choices: make RenumberLocks a separate entrypoint from NewRuntime, duplicating a lot of configuration load code (we need to know where the locks live, how many there are, etc) - or modify NewRuntime to allow renumbering during it. Previous experience says the first is not really a viable option and produces massive code bloat, so the second it is. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Remove locks from volumesMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | I was looking into why we have locks in volumes, and I'm fairly convinced they're unnecessary. We don't have a state whose accesses we need to guard with locks and syncs. The only real purpose for the lock was to prevent concurrent removal of the same volume. Looking at the code, concurrent removal ought to be fine with a bit of reordering - one or the other might fail, but we will successfully evict the volume from the state. Also, remove the 'prune' bool from RemoveVolume. None of our other API functions accept it, and it only served to toggle off more verbose error messages. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Expand renumber to also renumber pod locksMatthew Heon2019-02-21
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Add ability to rewrite pod configs in the databaseMatthew Heon2019-02-21
| | | | | | Necessary for rewriting lock IDs as part of renumber. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Add initial version of renumber backendMatthew Heon2019-02-21
| | | | | | | | | Renumber is a way of renumbering container locks after the number of locks available has changed. For now, renumber only works with containers. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Add a function for overwriting container configMatthew Heon2019-02-21
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #2387 from baude/remotepodrmOpenShift Merge Robot2019-02-21
|\ | | | | enable podman-remote pod rm
| * enable podman-remote pod rmbaude2019-02-21
| | | | | | | | | | | | add the ability to delete a pod from the remote client. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2392 from haraldh/masterOpenShift Merge Robot2019-02-21
|\ \ | |/ |/| Adjust LISTEN_PID for reexec in varlink mode
| * Adjust LISTEN_PID for reexec in varlink modeHarald Hoyer2019-02-21
|/ | | | | | | | Because the varlink server honors the socket activation protocol, LISTEN_PID has to be adjusted with the new PID. https://varlink.org/FAQ.html#how-does-socket-activation-work Signed-off-by: Harald Hoyer <harald@redhat.com>
* Merge pull request #2390 from mheon/update_cstorageOpenShift Merge Robot2019-02-21
|\ | | | | Update c/storage vendor to v1.10 release
| * Update c/storage vendor to v1.10 releaseMatthew Heon2019-02-20
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2367 from baude/remotesaveOpenShift Merge Robot2019-02-20
|\ \ | |/ |/| podman-remote save [image]
| * podman-remote save [image]baude2019-02-20
|/ | | | | | | Add the ability to save an image from the remote-host to the remote-client. Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #2378 from vrothberg/tree-statusOpenShift Merge Robot2019-02-20
|\ | | | | hack/tree_status.sh: preserve new lines
| * hack/tree_status.sh: preserve new linesValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | Quote the status output in echo to preserve the new lines. Having the output in one line complicated debugging issues and is not friendly to use. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2377 from vrothberg/kill-squaredOpenShift Merge Robot2019-02-20
|\ \ | | | | | | remove duplicate kill from `podman --help`
| * | remove duplicate kill from `podman --help`Valentin Rothberg2019-02-20
| |/ | | | | | | | | | | | | | | Remove the duplicate kill command and only keep it in the `mainCommands` containing commands that are implemented by the native client and the remote one. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2360 from vrothberg/parallel-searchOpenShift Merge Robot2019-02-20
|\ \ | | | | | | podman-search: run in parallel
| * | iopodman.SearchImages: add ImageSearchFilter to Varlink APIValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also add some argument checks to the Varlink function to avoid referencing nil pointers, and complement the API.md descriptions. The varlink endpoint can be tested via varlink CLI: $ varlink call -m unix:/run/podman/io.podman/io.podman.SearchImages \ '{"query": "ruby", "limit": 0, "tlsVerify": false, "filter": {}}' Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | image.SearchImages: use SearchFilter typeValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | | | | | | Use an `image.SearchFilter` instead of a `[]string` in the SearchImages API. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | SearchImages: extend API with filter parameterValentin Rothberg2019-02-20
| | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | podman-search: refactor code to libpod/image/search.goValentin Rothberg2019-02-20
| | | | | | | | | | | | | | | | | | | | | | | | Refactor the image-search logic from cmd/podman/search.go to libpod/image/search.go and update podman-search and the Varlink API to use it. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | podman-search: run in parallelValentin Rothberg2019-02-20
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Spin up a goroutine for each registry to make podman-search run in parallel. This has considerable speed improvements. For instance, a `podman search ruby` drops from 11 to 2 seconds when using the following search registries: ```toml [registries.search] registries = ['docker.io', 'registry.fedoraproject.org', 'quay.io', 'registry.access.redhat.com', 'registry.centos.org'] ``` The number of parallel goroutines is limited to 6 to play nice with local resources and the registries. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2374 from mheon/rootless_recursive_startOpenShift Merge Robot2019-02-20
|\ \ | |/ |/| Ensure that userns is created for stopped rootless pods
| * Ensure that userns is created for stopped rootless podsMatthew Heon2019-02-19
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #2373 from mheon/pod_has_no_argumentsOpenShift Merge Robot2019-02-19
|\ \ | |/ |/| Podman pod create now errors on receiving CLI args
| * Podman pod create now errors on receiving CLI argsMatthew Heon2019-02-19
|/ | | | | | | It has never accepted arguments, so we should error when passed args we will never use. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #2363 from TomSweeneyRedHat/dev/tsweeney/cobraex5OpenShift Merge Robot2019-02-19
|\ | | | | Fifth chunk of Cobra Examples
| * Fifth chunk of Cobra ExamplesTomSweeneyRedHat2019-02-18
| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> The fifth and final chunk of examples for the Cobra examples in the CLI help output. Also includes a few man page touchups. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #2348 from baude/remotepullverboseOpenShift Merge Robot2019-02-19
|\ \ | | | | | | podman-remote pull
| * | podman-remote pullbaude2019-02-19
|/ / | | | | | | | | | | Add status for remote users and podman remote-client pull. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2366 from haircommander/dont-start-started-depsOpenShift Merge Robot2019-02-19
|\ \ | |/ |/| Don't start running dependencies
| * Don't start running dependenciesPeter Hunt2019-02-19
|/ | | | | | Before, a container being run or started in a pod always restarted the infra container. This was because we didn't take running dependencies into account. Fix this by filtering for dependencies in the running state. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* Merge pull request #2361 from TomSweeneyRedHat/dev/tsweeney/cobraex4OpenShift Merge Robot2019-02-18
|\ | | | | Add 4th chunk of Cobra Examples
| * Add 4th chunk of Cobra ExamplesTomSweeneyRedHat2019-02-18
| | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds the 4th chunk of Cobra Examples to the CLI help. One more chunk of 10 to complete. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #1692 from sjug/opentracing_cleanOpenShift Merge Robot2019-02-18
|\ \ | |/ |/| OpenTracing First Impl
| * OpenTracing support added to start, stop, run, create, pull, and psSebastian Jug2019-02-18
|/ | | | | | Drop context.Context field from cli.Context Signed-off-by: Sebastian Jug <sejug@redhat.com>
* Merge pull request #2354 from rhatdan/varlinkOpenShift Merge Robot2019-02-18
|\ | | | | Add registry name to fields returned by varlink image search
| * Add registry name to fields returned by varlink image searchDaniel J Walsh2019-02-15
| | | | | | | | | | | | | | | | | | | | | | Cockpit team wants to list the registry name where the image was found. Also fix up SearchImages code to check if the user specified a registry in his call to use that rather then all the registries, This matches podman search command. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2359 from nitkon/masterOpenShift Merge Robot2019-02-18
|\ \ | | | | | | packer: Make Makefile host arch sensitive
| * | packer: Make Makefile host arch sensitiveNitesh Konkar2019-02-18
|/ / | | | | | | | | | | | | | | `make localunit` fails on non-amd64 archs as it unzips packer_1.3.2_linux_amd64.zip irrespective of host arch its running on. Signed-off-by: Nitesh Konkar <niteshkonkar@in.ibm.com>
* | Merge pull request #2357 from TomSweeneyRedHat/dev/tsweeney/cobrahelp3OpenShift Merge Robot2019-02-17
|\ \ | | | | | | Add 3rd chunk of Cobra examples
| * | Add 3rd chunk of Cobra examplesTomSweeneyRedHat2019-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds the third chunk of Cobra examples to the cli help. As were putting together a release tomorrow, tried to hit the heavy commands with this PR. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2295 from haircommander/recursive-startOpenShift Merge Robot2019-02-17
|\ \ \ | |/ / |/| | Recursively start a pod if a container is run in it
| * | pod infra container is started before a container in a pod is run, started, ↵Peter Hunt2019-02-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | or attached. Prior, a pod would have to be started immediately when created, leading to confusion about what a pod state should be immediately after creation. The problem was podman run --pod ... would error out if the infra container wasn't started (as it is a dependency). Fix this by allowing for recursive start, where each of the container's dependencies are started prior to the new container. This is only applied to the case where a new container is attached to a pod. Also rework container_api Start, StartAndAttach, and Init functions, as there was some duplicated code, which made addressing the problem easier to fix. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | Merge pull request #2340 from QiWang19/login_lyingOpenShift Merge Robot2019-02-17
|\ \ \ | | | | | | | | Fix `podman login` lying problem
| * | | Fix `podman login` lying problemQi Wang2019-02-14
| | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #2341 from TomSweeneyRedHat/dev/tsweeney/helpexamples2OpenShift Merge Robot2019-02-16
|\ \ \ \ | |_|/ / |/| | | Second chunk of Cobra help
| * | | Second chunk of Cobra helpTomSweeneyRedHat2019-02-15
| | |/ | |/| | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Adds examples to Cobra help for a second chunk of commands. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>