summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* [CI:DOCS]addition of specgen packageBrent Baude2020-02-04
| | | | | | | | | | warning: the naming of this might change as well as the location. this is a build on a PR from mheon from last year that proposes a shift from our current approach of creating containers based on the arbitrarily made createconfig. the new approach would be to have a specification that is detached from the podman cli. the spec could then be generated and used to make a container. this theoretically is the beginning of a long-needed refactor involving how we get from the cli -> libpod | apiv2 -> libpod with code re-use and less duplication. the intent is to build the apiv2 container creation based on this approach only. wiring to the podman cli will happen after the fact. Signed-off-by: Brent Baude <bbaude@redhat.com>
* Initial implementation of a spec generator packageMatthew Heon2020-02-04
| | | | | | | | | | | | | | | | | | | | | | | The current Libpod pkg/spec has become a victim of the better part of three years of development that tied it extremely closely to the current Podman CLI. Defaults are spread across multiple places, there is no easy way to produce a CreateConfig that will actually produce a valid container, and the logic for generating configs has sprawled across at least three packages. This is an initial pass at a package that generates OCI specs that will supersede large parts of the current pkg/spec. The CreateConfig will still exist, but will effectively turn into a parsed CLI. This will be compiled down into the new SpecGenerator struct, which will generate the OCI spec and Libpod create options. The preferred integration point for plugging into Podman's Go API to create containers will be the new CreateConfig, as it's less tied to Podman's command line. CRI-O, for example, will likely tie in here. Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #5066 from cevich/fix_gate_wrong_commitOpenShift Merge Robot2020-02-03
|\ | | | | Cirrus: Fix gate task + make lint|validate
| * Cirrus: Fix gate task + make lint|validateChris Evich2020-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A recent Makefile change (4ec893a748) removed a side-effect necessary for 'make validation' to pass under automation. Making things worse, change 12bd7e927c was found upon investigation to always point at the latest upstream HEAD. However, this is rarely a fork-point for pull-requests. Further investigation showed the built-in Cirrus-CI, golang-based git does not obtain sufficient data for the Makefile command `git merge-base HEAD $${DEST_BRANCH:-master}` to function properly (in the context of the gate container). Fix this by customizing the clone operation and slightly adjust the Makefile command to function as intended in the gate container. Also add checks to the validate and lint targets which validate the variable EPOCH_TEST_COMMIT value is never an empty string or whitespace. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #5067 from jwhonce/wip/pingOpenShift Merge Robot2020-02-03
|\ \ | |/ |/| [CI:DOCS] Update /_ping support
| * Update /_ping supportJhon Honce2020-02-03
|/ | | | | | | | | | | | | | | | | | | | | * Add swagger support and documentation * Promote handler as there can only ever be one * Update swagger tags Between verbs and paths there are four endpoints for /_ping. I've attempted to document them well without four copies of the details. Time will tell. Clients will use the headers `Libpod-API-Version` and `Libpod-Buildha-Version` to determine if they are connecting to a Podman service or some other compatible engine. Client calls GET(/_ping): * VARLINK engines will fail with error message * Compatible engines will return 200 without Libpod headers * Podman engines will return 200 and Libpod headers Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #5044 from jwhonce/issues/4335OpenShift Merge Robot2020-02-03
|\ | | | | Update XML to not embed quote in PATH on windows
| * Update XML to not embed quote in PATH on windowsJhon Honce2020-01-31
| | | | | | | | | | | | | | | | * Remove the unsupported commend in lua script Fixes #4335 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5053 from ↵Daniel J Walsh2020-02-03
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.15.8 build(deps): bump github.com/containers/storage from 1.15.7 to 1.15.8
| * | build(deps): bump github.com/containers/storage from 1.15.7 to 1.15.8dependabot-preview[bot]2020-02-03
| |/ | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.15.7 to 1.15.8. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.15.7...v1.15.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5054 from ↵Daniel J Walsh2020-02-03
|\ \ | |/ |/| | | | | containers/dependabot/go_modules/github.com/onsi/gomega-1.9.0 build(deps): bump github.com/onsi/gomega from 1.8.1 to 1.9.0
| * build(deps): bump github.com/onsi/gomega from 1.8.1 to 1.9.0dependabot-preview[bot]2020-02-03
|/ | | | | | | | | | Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.8.1 to 1.9.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/gomega/compare/v1.8.1...v1.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #5041 from mheon/bump-1.8.0-rc1OpenShift Merge Robot2020-01-31
|\ | | | | Bump to v1.8.0-rc1
| * Bump to v1.8.0-devMatthew Heon2020-01-31
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Bump to v1.8.0-rc1v1.8.0-rc1Matthew Heon2020-01-31
|/ | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #5038 from mheon/fix_release_scriptOpenShift Merge Robot2020-01-31
|\ | | | | [CI:DOCS] Fix a syntax error in hack/release.sh
| * Fix a syntax error in hack/release.shMatthew Heon2020-01-31
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5036 from vrothberg/fix-5034OpenShift Merge Robot2020-01-31
|\ \ | | | | | | sigproxy: return after closing the channel
| * | sigproxy: return after closing the channelValentin Rothberg2020-01-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When stopping signal handling (e.g., to properly handle ^C) we are also closing the signal channel. We should really return from the go-routine instead of continuing and risking double-closing the channel which leads to a panic. Fixes: #5034 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5030 from baude/apiv2longnameOpenShift Merge Robot2020-01-31
|\ \ \ | |_|/ |/| | fix longname handling for bindings
| * | fix longname handling for bindingsBrent Baude2020-01-31
| |/ | | | | | | | | | | the api needs to account for image input where the image is encoded as a fqd image name. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5037 from mheon/release_notes_1.8.0OpenShift Merge Robot2020-01-31
|\ \ | |/ |/| [CI:DOCS] Minor update to release notes
| * Minor update to release notesMatthew Heon2020-01-31
|/ | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #5032 from mheon/release_notes_1.8.0OpenShift Merge Robot2020-01-30
|\ | | | | Update release notes for v1.8.0
| * Update release notes for v1.8.0Matthew Heon2020-01-30
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5028 from baude/commitimageOpenShift Merge Robot2020-01-30
|\ \ | | | | | | make image reference for commit optional
| * | make image reference for commit optionalBrent Baude2020-01-30
| |/ | | | | | | | | | | | | | | to match docker compat, the image tag should be optional. Fixes: #5027 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5020 from baude/bindingtestrootlessOpenShift Merge Robot2020-01-30
|\ \ | | | | | | Bindingtestrootless
| * | rootless: enable shortcut only for podmanGiuseppe Scrivano2020-01-29
| | | | | | | | | | | | | | | | | | | | | disable joining automatically the user namespace if the process is not podman. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | test: honor TEMPDIR variableGiuseppe Scrivano2020-01-29
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5022 from ssbarnea/fix/validateOpenShift Merge Robot2020-01-30
|\ \ \ | | | | | | | | Assure validate includes lint
| * | | Assure validate includes lintSorin Sbarnea2020-01-30
| | |/ | |/| | | | | | | | | | | | | Fixed issue where lint was not run on CI, so we missed to prevent regressions. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
* | | Merge pull request #5024 from rpjday/markdown/asterisksOpenShift Merge Robot2020-01-30
|\ \ \ | | | | | | | | markdown: fix erroneous asterisk markup for options
| * | | markdown: fix erroneous asterisk markup for optionsRobert P. J. Day2020-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix option markup in a number of man pages so it renders properly when viewing online. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
* | | | Merge pull request #5031 from baude/apiv2dockercontainerslashOpenShift Merge Robot2020-01-30
|\ \ \ \ | |_|/ / |/| | | compat container names begin with /
| * | | compat container names begin with /Brent Baude2020-01-30
|/ / / | | | | | | | | | | | | | | | when using the apiv2, containers names are preceeded with a /. fixing this for inspect and listcontainers. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5025 from delight/feature/ubuntu_doc_adjustmentOpenShift Merge Robot2020-01-30
|\ \ \ | | | | | | | | Feature/ubuntu doc adjustment
| * | | adjusts install.md (Ubuntu): replaces ${NAME} with hard-encoded Ubuntu to ↵Konstantinos Kostarellis2020-01-30
| | | | | | | | | | | | | | | | | | | | | | | | support all *buntu flavors - combines downloading and registering of the apt-secure key into a piped oneliner
| * | | adjusts install.md (Ubuntu): registries.conf setup is now in ↵Konstantinos Kostarellis2020-01-30
| | |/ | |/| | | | | | | containers-image package
* | | Merge pull request #5017 from vrothberg/fix-4829OpenShift Merge Robot2020-01-30
|\ \ \ | | | | | | | | Makefile cleanups
| * | | speed up MakefileValentin Rothberg2020-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speed up the Makefile by removing variable references from the release targets. Now, the variables will only be (lazily) evaluated when they are actually needed and not for each invocation of the Makefile which has it down considerably. Fixes: #4829 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | Makefile: systemd: echo instead of warnValentin Rothberg2020-01-30
| | | | | | | | | | | | | | | | | | | | | | | | Just echo the message instead of warning to not impact the exit code. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | Makefile: remove redundant BUILDFLAGSValentin Rothberg2020-01-30
| | | | | | | | | | | | | | | | | | | | | | | | We don't set it, so there's no need to keep it. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | Makefile: consistent PHONY useValentin Rothberg2020-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a .PHONY line over each target instead of mixing this notation with a separate but incomplete single list. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | Makefile: remove dead vagrant targetValentin Rothberg2020-01-30
| | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | Makefile: move systemd buildtag checkValentin Rothberg2020-01-30
| |/ / | | | | | | | | | | | | | | | | | | | | | Move the systemd-buildtag check into the `bin/podman` target. No need to execute the check for all invocations of the Makefile. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #4951 from rpjday/docs/unshareOpenShift Merge Robot2020-01-30
|\ \ \ | | | | | | | | markdown: fix grammar/formatting, standardize on markdown
| * | | markdown: fix grammar/formatting, standardize on markdownRobert P. J. Day2020-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While fixing grammar and list formatting issues, standardize on markdown as follows: - commands are marked by '**' - files are marked by backquotes - list items are marked with leading '-' Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
* | | | Merge pull request #5019 from cevich/fix_gate_epochOpenShift Merge Robot2020-01-30
|\ \ \ \ | |_|/ / |/| | | Cirrus: Set EPOCH_TEST_COMMIT during gate task
| * | | Cirrus: Set EPOCH_TEST_COMMIT during gate taskChris Evich2020-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For whatever reason, this required variable is not set when `make` is doing validation within automation. Fix this by establishing the value based on data provided from the CI system. Since this data is specific to automation executing against a PR, limit this specific job to not run during testing of branches (post-merge). This is safe since we can assume the PR would not have been merged, if the basics checked during gating did not pass. Signed-off-by: Chris Evich <cevich@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-06 07:25:25 +0000