summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* container runlabel respect $PWDbaude2019-03-08
| | | | | | | | | When doing environment variable substitution, we need to make sure $PWD is replaced with the current working directory. fixes issue #2171 Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #2582 from baude/issue2574OpenShift Merge Robot2019-03-08
|\ | | | | label parsing in non-quoted field
| * label parsing in non-quoted fieldbaude2019-03-08
| | | | | | | | | | | | | | | | | | switch from a stringslice to a stringarray for labels to handle quoted input. fixes issue #2574 Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2580 from rhatdan/cleanup1OpenShift Merge Robot2019-03-08
|\ \ | | | | | | More cleanup for failures on missing commands.
| * | More cleanup for failures on missing commands.Daniel J Walsh2019-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently in podman if a user specifies a command that does not exist the tool shows the help information. This patch changes it to show information like: $ ./bin/podman foobar Error: unrecognized command 'podman foobar' Try 'podman --help' for more information. $ ./bin/podman volume foobar Error: unrecognized command `podman volume foobar` Try 'podman volume --help' for more information. $ ./bin/podman container foobar Error: unrecognized command `podman container foobar` Try 'podman container --help' for more information. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2579 from edsantiago/add_healthcheck_to_podman_1OpenShift Merge Robot2019-03-08
|\ \ \ | |_|/ |/| | add podman-healthcheck(1) to podman(1)
| * | add podman-healthcheck(1) to podman(1)Ed Santiago2019-03-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...caught by hack/podman-commands.sh script. Which had a little buglet, which I fixed: add a special case for 'help', which neither has nor needs a man page. I believe the podman-commands.sh script is ready to be run in CI, hint hint. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #2533 from edsantiago/batsOpenShift Merge Robot2019-03-07
|\ \ \ | | | | | | | | New system tests under BATS
| * | | Implement review feedbackEd Santiago2019-03-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - document a recommended convention for fail-fast tests - document the requirement for jq. (And, add a fail-fast test for its presence; remove the duplicated checks in subtests) - add further sanity checks to 'help' test. Add missing documentation. Remove a no-longer-needed workaround for usage-message bug fixed in #2486 - add a documented TEMPLATE - and, since we're at 1.1, enable 'Remote API' check in version test - better diagnostics in setup/teardown; add vim filetype hint; better formatting of actual-vs-expect errors - new pod-top, logs, build tests - improve error messages - add $IMAGE alias for ridiculous $PODMAN_TEST_IMAGE_FQN - final cleanup, in prep for merge Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | new system tests under BATSEd Santiago2019-03-07
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initial attempt at writing a framework for podman system tests. The idea is to define a useful set of primitives that will make it easy to write actual tests and to interpret results of failing ones. This is a proof-of-concept right now; only a small number of tests, by no means comprehensive. I am requesting review in order to find showstopper problems: reasons why this approach cannot work. Should there be none, we can work toward running these as gating tests for Fedora and RHEL8. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #2570 from muayyad-alsadi/alsadi-tests-20190307OpenShift Merge Robot2019-03-07
|\ \ \ | |_|/ |/| | test to cover parallel execution and networking
| * | implement showerror and accept HOST_PORT env which defaults to 8080alsadi2019-03-07
| | | | | | | | | | | | Signed-off-by: alsadi <alsadi@gmail.com>
| * | add test to cover networkingalsadi2019-03-07
| | | | | | | | | | | | Signed-off-by: alsadi <alsadi@gmail.com>
| * | tests to cover locks and parallel execution #2551alsadi2019-03-07
| | | | | | | | | | | | Signed-off-by: alsadi <alsadi@gmail.com>
* | | Merge pull request #2564 from rhatdan/cleanupOpenShift Merge Robot2019-03-07
|\ \ \ | |_|/ |/| | Fix help commands to show short and long description.
| * | Fix help commands to show short and long description.Daniel J Walsh2019-03-07
|/ / | | | | | | | | | | Cleanup lots of help information to look good when displayed. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2214 from cevich/cirrus_imgts_activateOpenShift Merge Robot2019-03-07
|\ \ | | | | | | Cirrus: Use imgts container to record metadata (needs #2213)
| * | Cirrus: Use imgts container to record metadataChris Evich2019-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make use of the built imgts container image to track VM image usage statistics for every automation run. Also update and add small check to the gate test that verifies expected formatting/content of the `.cirrus.yml` file WRT VM Image names. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #2573 from giuseppe/exec-extra-filesOpenShift Merge Robot2019-03-07
|\ \ \ | | | | | | | | oci: make explicit the extra files to the exec
| * | | oci: make explicit the extra files to the execGiuseppe Scrivano2019-03-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the previous version I forgot to add the fds to preserve into AdditionalFiles. It doesn't make a difference as the files were still preserved, but this seems to be the correct way of making it explicit. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #2550 from wking/language-dot-splitOpenShift Merge Robot2019-03-07
|\ \ \ \ | | | | | | | | | | libpod/container_internal: Split locale at the first dot, etc.
| * | | | libpod/container_internal: Split locale at the first dot, etc.W. Trevor King2019-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to feed this into Go's BCP 47 language parser. Language tags have the form [1]: language ["-" script] ["-" region] *("-" variant) *("-" extension) ["-" privateuse] and locales have the form [2]: [language[_territory][.codeset][@modifier]] The modifier is useful for collation, but Go's language-based API [3] does not provide a way for us to supply it. This code converts our locale to a BCP 47 language by stripping the dot and later and replacing the first underscore, if any, with a hyphen. This will avoid errors like [4]: WARN[0000] failed to parse language "en_US.UTF-8": language: tag is not well-formed when feeding language.Parse(...). [1]: https://tools.ietf.org/html/bcp47#section-2.1 [2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_02 [3]: https://github.com/golang/go/issues/25340 [4]: https://github.com/containers/libpod/issues/2494 Signed-off-by: W. Trevor King <wking@tremily.us>
* | | | | Merge pull request #2565 from edsantiago/healthcheck_run_usage_fixOpenShift Merge Robot2019-03-07
|\ \ \ \ \ | |_|/ / / |/| | | | Yet another seemingly minor tweak to usage message
| * | | | Yet another seemingly minor tweak to usage messageEd Santiago2019-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add explicit [flags] to podman healthcheck run Use message. Reason: Cobra checks for the string '[flags]' in the Use text. If absent, and command has options, Cobra appends it. This is misleading to humans, because the --help output looks like: podman healthcheck run CONTAINER [flags] ...when of course that won't work. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #2563 from mheon/lookup_double_match_always_returns_nameOpenShift Merge Robot2019-03-07
|\ \ \ \ \ | |_|_|_|/ |/| | | | Change LookupContainer logic to match Docker
| * | | | Change LookupContainer logic to match DockerMatthew Heon2019-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When looking up a container or pod by from user input, we handle collisions between names and IDs differently than Docker at present. In Docker, when there is a container with an ID starting with "c1" and a container named "c1", commands on "c1" will always act on the container named "c1". For the same scenario in podman, we throw an error about name collision. Change Podman to follow Docker, by returning the named container or pod instead of erroring. This should also have a positive effect on performance in the lookup-by-full-name case, which no longer needs to fully traverse the list of all pods or containers. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #2534 from jwhonce/wip/remote_waitOpenShift Merge Robot2019-03-06
|\ \ \ \ \ | |_|/ / / |/| | | | Implement podman-remote wait command and container subcommand
| * | | | Implement podman-remote wait command and container subcommandJhon Honce2019-03-06
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #2442 from baude/remotepodtopOpenShift Merge Robot2019-03-06
|\ \ \ \ \ | | | | | | | | | | | | podman-remote pod top|stats
| * | | | | podman-remote pod top|statsbaude2019-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this is the final enablement for the pod subcommand. it includes the ability to run podman-remote pod top and stats. Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #2412 from QiWang19/iss2380OpenShift Merge Robot2019-03-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | Enable specifying directory as device on container with --device
| * | | | | | fix bug --device enable specifying directory as deviceQi Wang2019-03-06
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | | Merge pull request #2545 from haircommander/weird_pod_bugOpenShift Merge Robot2019-03-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix pod create failure
| * | | | | | Fix incorrect pod create failurePeter Hunt2019-03-06
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before, a pod create would fail if it was set to share no namespaces, but had an infra container. While inefficient (you add a container for no reason), it shouldn't be a fatal failure. Fix this by only failing if the pod was set to share namespaces, but had no infra container, and writing a warning if vice versa. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | | | Merge pull request #2532 from QiWang19/i2520OpenShift Merge Robot2019-03-06
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | add flag --extract tar file in podman cp
| * | | | | add flag --extract tar file in podman cpQi Wang2019-03-06
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | Merge pull request #2491 from baude/healtcheckphase1OpenShift Merge Robot2019-03-06
|\ \ \ \ \ | |_|_|_|/ |/| | | | podman healthcheck run (phase 1)
| * | | | podman healthcheck run (phase 1)baude2019-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the ability to manually run a container's healthcheck command. This is only the first phase of implementing the healthcheck. Subsequent pull requests will deal with the exposing the results and history of healthchecks as well as the scheduling. Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #2547 from haircommander/pod_volume_mountOpenShift Merge Robot2019-03-06
|\ \ \ \ \ | |_|/ / / |/| | | | Add volume mounting to podman play kube
| * | | | Add volume mounting to podman play kubePeter Hunt2019-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before, podman play kube ignored HostPath and VolumeMounts fields in a k8s yaml file. Add this functionality, allowing for a user to create a volume mount from a .yaml file Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | | Merge pull request #2543 from giuseppe/fix-rootless-s390x-crisOpenShift Merge Robot2019-03-06
|\ \ \ \ \ | | | | | | | | | | | | rootless: fix clone syscall on s390 and cris archs
| * | | | | rootless: fix clone syscall on s390 and cris archsGiuseppe Scrivano2019-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from the clone man page: On the cris and s390 architectures, the order of the first two arguments is reversed: long clone(void *child_stack, unsigned long flags, int *ptid, int *ctid, unsigned long newtls); Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1672714 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #2430 from QiWang19/issfiltetOpenShift Merge Robot2019-03-06
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Support filter image by reference to the image name
| * | | | | Support filter image by reference to the repo nameQi Wang2019-03-04
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | | Merge pull request #2518 from haircommander/pod_hostOpenShift Merge Robot2019-03-05
|\ \ \ \ \ \ | | | | | | | | | | | | | | Append hosts to dependency container's /etc/hosts file
| * | | | | | Append hosts to dependency container's /etc/hosts filePeter Hunt2019-03-05
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Before, any container with a netNS dependency simply used its dependency container's hosts file, and didn't abide its configuration (mainly --add-host). Fix this by always appending to the dependency container's hosts file, creating one if necessary. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | | | Merge pull request #2519 from jwhonce/wip/remote_killOpenShift Merge Robot2019-03-05
|\ \ \ \ \ \ | | | | | | | | | | | | | | Support podman-remote kill container(s)
| * | | | | | Support podman-remote kill container(s)Jhon Honce2019-03-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | | Merge pull request #2529 from cevich/use_vendor_ginkgoOpenShift Merge Robot2019-03-05
|\ \ \ \ \ \ \ | |_|_|_|_|_|/ |/| | | | | | cirrus: Drop ginkgo, gomega, easyjson install
| * | | | | | cirrus: Drop ginkgo, gomega, easyjson installChris Evich2019-03-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is potentially harmful, since ginkgo and it's dependencies are now vendored and installed by `make .install.ginkgo`, and may not agree with installed 'go get' code under `$GOPATH`. Prune this (and easyjson install) from automation scripts. Signed-off-by: Chris Evich <cevich@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-26 22:57:36 +0000