summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix four errors tagged by Cobra macro debuggingMatthew Heon2019-02-27
| | | | | | | | Three flags are unimplemented (never implemented) One had an incorrect retrieval macro Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Add debugging for errors to Cobra compatibility macrosMatthew Heon2019-02-27
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Fix ignored --stop-timeout flag to 'podman create'Matthew Heon2019-02-27
| | | | | | | | | Also add some extra debug information to help figure out what's going on when stop goes bad. Fixes: #2472 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #2454 from mheon/all_your_defaults_belong_to_libpodOpenShift Merge Robot2019-02-27
|\ | | | | Move all storage configuration defaults into libpod
| * Centralize setting default volume pathMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | No reason to do it in util/ anymore. It's always going to be a subdirectory of c/storage graph root by default, so we can just set it after the return. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Ensure volume path is set appropriately by defaultMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | There are some cases where we might not be properly adjusting the volume path after setting the storage graph root. Ensure that we always set volume path to be a child of graph root. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Move all storage configuration defaults into libpodMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | | | Instead of passing in defaults via WithStorageConfig after computing them in cmd/podman/libpodruntime, do all defaults in libpod itself. This can alleviate ordering issues which caused settings in the libpod config (most notably, volume path) to be ignored. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2456 from edsantiago/better_synopsesOpenShift Merge Robot2019-02-27
|\ \ | | | | | | Better usage synopses for subcommands
| * | Better usage synopses for subcommandsEd Santiago2019-02-26
| |/ | | | | | | | | | | | | Conceptually simple: include, where applicable, a brief description of command-line options for each subcommand. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #2460 from adrianreber/restoreOpenShift Merge Robot2019-02-27
|\ \ | | | | | | Remove restore as podman subcommand
| * | Remove restore as podman subcommandAdrian Reber2019-02-27
| | | | | | | | | | | | | | | | | | | | | | | | The commands checkpoint and restore should only be available under 'podman container'. This is probably a result of the recent cobra migration. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | Merge pull request #2458 from mheon/bump-1.1.0OpenShift Merge Robot2019-02-27
|\ \ \ | | | | | | | | Bump to 1.1.0
| * | | Bump gitvalidation epochMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | Bump to v1.2.0-devMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | Bump to v1.1.0v1.1.0Matthew Heon2019-02-26
|/ / / | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #2434 from mheon/release_notes_v1.1OpenShift Merge Robot2019-02-26
|\ \ \ | | | | | | | | Update release notes for v1.1.0
| * | | Update release notes for v1.1.0Matthew Heon2019-02-26
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #2440 from rhatdan/buildahOpenShift Merge Robot2019-02-26
|\ \ \ \ | |_|_|/ |/| | | Vendor in buildah v1.7.1
| * | | Vendor in latest buildah 1.7.1Daniel J Walsh2019-02-26
|/ / / | | | | | | | | | | | | | | | | | | This release updates buildah to use containers/image v1.5 Which fixes a crash issue when pulling container images. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2448 from giuseppe/volumes-skip-user-bindsOpenShift Merge Robot2019-02-26
|\ \ \ | | | | | | | | volume: do not create a volume if there is a bind
| * | | volume: do not create a volume if there is a bindGiuseppe Scrivano2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if there is already a bind mount specified for the target, do not create a new volume. Regression introduced by 52df1fa7e054d577e8416d1d46db1741ad324d4a Closes: https://github.com/containers/libpod/issues/2441 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #2446 from mheon/add_image_volumeOpenShift Merge Robot2019-02-26
|\ \ \ \ | | | | | | | | | | Only remove image volumes when removing containers
| * | | | Only remove image volumes when removing containersMatthew Heon2019-02-26
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When removing volumes with rm --volumes we want to only remove volumes that were created with the container. Volumes created separately via 'podman volume create' should not be removed. Also ensure that --rm implies volumes will be removed. Fixes #2441 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #2443 from baude/playstartrecursiveOpenShift Merge Robot2019-02-26
|\ \ \ \ | | | | | | | | | | start pod containers recursively
| * | | | start pod containers recursivelybaude2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when using the play kube command, we need to make sure that containers with dependancies are started in proper order. in this case, the infra container must be started first. Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #2444 from adrianreber/logsOpenShift Merge Robot2019-02-26
|\ \ \ \ \ | |_|/ / / |/| | | | Fix podman logs -l
| * | | | Fix podman logs -lAdrian Reber2019-02-26
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | 'podman logs -l' was no longer working. This fixes it by replacing &waitCommand.Latest with &logsCommand.Latest. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | Merge pull request #2439 from vrothberg/vendor-imageOpenShift Merge Robot2019-02-26
|\ \ \ \ | | | | | | | | | | vendor containers/image v1.5
| * | | | vendor containers/image v1.5Valentin Rothberg2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes are race condition in the blobinfocache when copying images leading to a panic(). Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #2397 from mheon/volume_path_fixesOpenShift Merge Robot2019-02-26
|\ \ \ \ \ | |_|/ / / |/| | | | Volume path fixes
| * | | | Record when volume path is explicitly set in configMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures we won't overwrite it when it's set in the config we load from disk. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add debug information when overriding paths with the DBMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add path for named volumes to `podman info`Matthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add volume path to default libpod.conf (and manpage)Matthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Validate VolumePath against DB configurationMatthew Heon2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If this doesn't match, we end up not being able to access named volumes mounted into containers, which is bad. Use the same validation that we use for other critical paths to ensure this one also matches. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | When location of c/storage root changes, set VolumePathMatthew Heon2019-02-26
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want named volumes to be created in a subdirectory of the c/storage graph root, the same as the libpod root directory is now. As such, we need to adjust its location when the graph root changes location. Also, make a change to how we set the default. There's no need to explicitly set it every time we initialize via an option - that might conflict with WithStorageConfig setting it based on graph root changes. Instead, just initialize it in the default config like our other settings. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #2289 from 4383/improve-hackingDaniel J Walsh2019-02-26
|\ \ \ \ | |/ / / |/| | | [skip ci]Introduce how to start to hack on libpod.
| * | | Introduce how to start to hack on libpod.Hervé Beraud2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce a new part inside the contribution guide who explain how to start to hack on libpod: - setup environment - install tools - using make - building podman - test your changes locally Signed-off-by: Hervé Beraud <hberaud@redhat.com>
* | | | Merge pull request #2438 from vrothberg/scope-v2OpenShift Merge Robot2019-02-26
|\ \ \ \ | | | | | | | | | | [skip ci] readme/docs update
| * | | | docs: cross-reference `podman-{generate,play}-kube`Valentin Rothberg2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | Addresses: https://github.com/containers/libpod/pull/2428#discussion_r260200694 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | README: refine "Out of scope" sectionValentin Rothberg2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Based on user feedback, refine the "Out of scope" section regarding `docker-compose`: * Explain why Podman uses Kubernetes YAML. * Explain how `podman-play-kube` and `podman-generate-kube` fit into the picture. Addresses: https://github.com/containers/libpod/pull/2428#discussion_r259996507 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #2382 from adrianreber/selinuxOpenShift Merge Robot2019-02-26
|\ \ \ \ \ | | | | | | | | | | | | Fix one (of two) SELinux denials during checkpointing
| * | | | | Label CRIU log files correctlyAdrian Reber2019-02-26
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CRIU creates a log file during checkpointing in .../userdata/dump.log. The problem with this file is, is that CRIU injects a parasite code into the container processes and this parasite code also writes to the same log file. At this point a process from the inside of the container is trying to access the log file on the outside of the container and SELinux prohibits this. To enable writing to the log file from the injected parasite code, this commit creates an empty log file and labels the log file with c.MountLabel(). CRIU uses existing files when writing it logs so the log file label persists and now, with the correct label, SELinux no longer blocks access to the log file. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | | Merge pull request #2437 from giuseppe/runtime-nice-errorOpenShift Merge Robot2019-02-26
|\ \ \ \ \ | |/ / / / |/| | | | oci: improve error message when the OCI runtime is not found
| * | | | oci: improve error message when the OCI runtime is not foundGiuseppe Scrivano2019-02-26
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | We were previously returning the not so nice error directly from conmon. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #2428 from vrothberg/docker-compose-out-of-scopeOpenShift Merge Robot2019-02-26
|\ \ \ \ | |_|/ / |/| | | README: update "out of scope" section
| * | | README: update "out of scope" sectionValentin Rothberg2019-02-25
| | |/ | |/| | | | | | | | | | | | | | | | Also mention that Podman does/will not support `docker-compose`. Fixes: https://github.com/containers/libpod/issues/746#issuecomment-467011211 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #2362 from mheon/add_locks_to_configOpenShift Merge Robot2019-02-26
|\ \ \ | | | | | | | | Add num_locks to the default libpod config
| * | | Add num_locks to the default libpod configMatthew Heon2019-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow adjusting number of locks in libpod.conf via an already available knob we previously didn't expose in the default config file. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #2436 from baude/remotepodpauseOpenShift Merge Robot2019-02-26
|\ \ \ \ | | | | | | | | | | podman-remote pod pause|unpause|restart
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-02 08:38:24 +0000