summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Generate kube should'd add podman default environment varsDaniel J Walsh2021-09-22
| | | | | | | | | | | | Currently we add the default PATH, TERM and container from Podman to every kubernetes.yaml file. These values should not be recorded in the yaml files. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> <MH: Fixed cherry-pick conflicts> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* sync container state before reading the healthcheckPaul Holzinger2021-09-22
| | | | | | | | | | The health check result is stored in the container state. Since the state can change or might not even be set we have to retrive the current state before we try to read the health check result. Fixes #11687 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Eighty-six eighty-eightyEd Santiago2021-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (Sorry, couldn't resist). CI flakes have been coming down - thank you to everyone who has been making them a priority. This leaves a noisy subset that I've just been ignoring for months: Running: podman ... -p 8080:something ...cannot listen on the TCP port: listen tcp4 :8080: bind: address already in use Sometimes these are one-time errors resolved on 2nd try; sometimes they fail three times, forcing CI user to hit Rerun. In all cases they make noise in my flake logs, which costs me time. My assumption is that this has to do with ginkgo running random tests in parallel. Since many e2e tests simplemindedly use 8080, collisions are inevitable. Solution: simplemindedly replace 8080 with other (also arbitrarily picked) numbers. This is imperfect -- it requires human developers to pick a number NNNN and 'grep NNNN test/e2e/*' before adding new tests, which I am 100% confident ain't gonna happen -- but it's better than what we have now. Side note: I considered writing and using a RandomAvailablePort() helper, but that would still be racy. Plus, it would be a pain to interpolate strings into so many places. Finally, with this hand-tooled approach, if/when we _do_ get conflicts on port NNNN, it should be very easy to grep for NNNN, find the offending tests that reuse that port, and fix one of them. Signed-off-by: Ed Santiago <santiago@redhat.com>
* vendor c/psgo@v1.7.1Valentin Rothberg2021-09-22
| | | | | | | | | | psgo added support for listing supplementary groups via two new descriptors: * `groups` for supplementary groups inside the container * `hgroups` for the counterpart on the host Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Add a backoff and retries to retrieving exited eventMatthew Heon2021-09-22
| | | | | | | | | | | | | | | | | | There's a potential race around extremely short-running containers and events with journald. Events may not be written for some time (small, but appreciable) after they are received, and as such we can fail to retrieve it if there is a sufficiently short time between us writing the event and trying to read it. Work around this by just retrying, with a 0.25 second delay between retries, up to 4 times. [NO TESTS NEEDED] because I have no idea how to reproduce this race in CI. Fixes #11633 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* [CI:DOCS] Add network alias note in man pagesTomSweeneyRedHat2021-09-22
| | | | | | | Adds a note about the limitation of network aliases to the man pages This should satisfy https://issues.redhat.com/browse/RUN-1189 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* Remove references to kube being developmentBrent Baude2021-09-22
| | | | | | | | | | At this point and even though we are always improving the play and generate kube functions, I would say it no longers needs to be denoted as under development. [NO TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* Support --format tables in ps outputJhon Honce2021-09-22
| | | | | | | | | | | - Added tests to help ensure there is no future regressions - Added WaitWithTimeout(int) rather than calling WaitWithDefaultTimeout() multiple times - Exposed DefaultWaitTimeout to allow test to use a multiplier Fixes #2221 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Add podman image/container inspect man pagesDaniel J Walsh2021-09-22
| | | | | | | | [NO TESTS NEEDED] since this is really a docs change. Concludes: https://github.com/containers/podman/pull/11620 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* compat API: /images/json prefix image id with sha256Paul Holzinger2021-09-22
| | | | | | | | | Docker adds the `sha256:` prefix to the image ID, so our compat endpoint has to do this as well. Fixes #11623 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* [CI:DOCS] Add link to skopeo delete in podman rmiUrvashi Mohnani2021-09-22
| | | | | | | Add a note pointing to skopeo delete for when users want to delete an image in a remote registry. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* remote untag: support digestsValentin Rothberg2021-09-22
| | | | | | | | | Fix a bug when remotely untagging an image via tag@digest. The digest has been lost in the remote client and hence led to a wrong behaviour on the server. Fixes: #11557 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* System tests: cleanup, and remove obsolete skipsEd Santiago2021-09-22
| | | | | | | | | | | | | | | | * 070-build: - remove workaround for #9567, which is closed. - add many more cases to the ignorefile test, to test complicated special cases of Buildah PR 3486. * 160-volumes: - remove a skip_if_remote, volumes now work on remote - use a random name for tarball, and clean up when done using it. This fixes a gating-test failure (test runs as root, then rootless, and rootless can't clobber root's file). Signed-off-by: Ed Santiago <santiago@redhat.com>
* Remove unused code from libpodPaul Holzinger2021-09-22
| | | | | | | | | | | | | The libpod package should only compile on linux. The remote client should never try to import this package. Since these files do not add any value we should remove them, this prevents people from accidentally importing this package because it would fail to compile on windows/macos. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* [CI:DOCS] markdown cleanupEd Santiago2021-09-22
| | | | | | | | | | | | | | | | | | | | | * podman-inspect: make references be live links, not a static list. Also, remove container- and image-inspect, because those are NOPs. * podman-pull: add a missing right-paren * podman-search, podman: remove unwanted indentation from some file descriptions. Markdown indentation renders as one very very long line, requiring the user to use a horizontal scroll bar to read the text. I searched using grep '^ ' and eyeball-looking for text that doesn't look like one-line code examples, and see no more, but eyeball checks are fragile. One bug remains: MyST renders mailto: links uglily. I can find no way to fix this other than patching the source code. Signed-off-by: Ed Santiago <santiago@redhat.com>
* Only add 127.0.0.1 entry to /etc/hosts with --net=nonePaul Holzinger2021-09-22
| | | | | | | | | | | The check for net=none was wrong. It just assumed when we do not create the netns but have one set that we use the none mode. This however also applies to a container which joins the pod netns. To correctly check for the none mode use `config.NetMode.IsNone()`. Fixes #11596 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* container runlabel remove image tag from namePaul Holzinger2021-09-22
| | | | | | | | | | | When no name is given for podman container runlabel it will default to the image base name. However this can contain a tag. Since podman does not accept container names with a colon the run command will fail if it contains something like `podman run --name NAME ...`. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2004263 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Fix /auth compat endpointMatej Vasek2021-09-22
| | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fix inverted conditionMatej Vasek2021-09-22
| | | | | | [NO TESTS NEEDED] Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Merge pull request #11624 from giuseppe/3.4-fix-pause-processDaniel J Walsh2021-09-20
|\ | | | | [3.4] runtime: move pause process to scope
| * utils: return error message from StartTransientUnitGiuseppe Scrivano2021-09-20
| | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit eea5d251267d070d7920008056e3e4d603cae204)
| * utils: raise warning only on cgroupv2Giuseppe Scrivano2021-09-20
| | | | | | | | | | | | | | | | | | | | | | | | if it is not running on cgroup v2, print only a debug message since rootless users cannot create the cgroup. commit 9c1e27fdd536f6026efe3da4360755a3e9135ca8 introduced the regression. [NO TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 4caca0969863f5b8d13ff377ed1cc24d4033ed1a)
| * runtime: move pause process to scopeGiuseppe Scrivano2021-09-17
| | | | | | | | | | | | | | | | | | | | | | | | make sure the pause process is moved to its own scope as well as what we do when we join an existing user+mount namespace. Closes: https://github.com/containers/podman/issues/11560 [NO TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit a2c8b5d9d6d6e46679fe9540619d4303d4b4601d)
| * system: move MovePauseProcessToScope to utilsGiuseppe Scrivano2021-09-17
| | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 72534a74b3c2ff35ae1711a890406a6bce5fa44f)
| * system: always move pause process when running on systemdGiuseppe Scrivano2021-09-17
| | | | | | | | | | | | | | | | when running on a systemd with systemd, always try to move the pause process to its own scope. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit 9c1e27fdd536f6026efe3da4360755a3e9135ca8)
| * system: avoid reading pause pid fileGiuseppe Scrivano2021-09-17
| | | | | | | | | | | | | | | | we already know the path to the pause PID file, no need to calculate it again. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> (cherry picked from commit fa9728c5509f1ef3bb1c80055e89b910d9740efd)
* | Merge pull request #11655 from vrothberg/3.4-vendor-commonOpenShift Merge Robot2021-09-20
|\ \ | |/ |/| [3.4] vendor c/common@v0.44.1
| * test/apiv2: set main version back to 3Valentin Rothberg2021-09-20
| | | | | | | | | | | | Must have slipped through when creating the 3.4 branch. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * [3.4] vendor c/common@v0.44.1Valentin Rothberg2021-09-20
|/ | | | | | | | | | | Finalizes the linked BZ to fix passing down custom authfiles during auto updates. Also fixes the if-newer pull policy. [NO TESTS NEEDED] for now validated manually. A new system test will be added to the main branch shortly. BZ: bugzilla.redhat.com/show_bug.cgi?id=2000943 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #11616 from mheon/bump_340rc1OpenShift Merge Robot2021-09-16
|\ | | | | [CI:DOCS] Bump to v3.4.0-RC1
| * Bump to v3.4.0-devMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v3.4.0-rc1v3.4.0-rc1Matthew Heon2021-09-16
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #11598 from mheon/34_backportsreleasenotesOpenShift Merge Robot2021-09-16
|\ | | | | Backports and release notes for v3.4.0-RC1
| * Fix buildah-bud tests by using main's diff fileMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Fix podman-build manpages by using version from mainMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Fix release notesMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Remove Pod CPU testsMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Set DEST_BRANCH in cirrus to fix CIMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Final release notes for v3.4.0 RC1Matthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * libpod: honor --cgroups=split also with podsGiuseppe Scrivano2021-09-16
| | | | | | | | | | | | Honor --cgroups=split also when the container is running in a pod. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * build: take advantage of --platform listsNalin Dahyabhai2021-09-16
| | | | | | | | | | | | | | | | | | | | | | The builder can take a list of platforms in the Platforms field of its BuildOptions argument, and we should definitely take advantage of that. The `bud-multiple-platform-values` test from buildah exercises support for this, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
| * build.bats: fix copy tests after containers/buildah#3486Aditya Rajan2021-09-16
| | | | | | | | | | | | | | | | Fix copy tests after https://github.com/containers/buildah/pull/3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@gmail.com>
| * build: mirror --authfile to filesystem if pointing to FD instead of fileAditya Rajan2021-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Following commit makes sure that podman mirrors --authfile to a temporary file in filesystem if arg is pointing to an FD instead of actual file as FD can be only consumed once. Reference: * https://github.com/containers/buildah/pull/3498 * https://github.com/containers/buildah/issues/3070 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
| * Bump to Buildah v1.23.0Matthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Further release notes updatesMatthew Heon2021-09-16
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Show variant and codename of the distributionAnders F Björklund2021-09-16
| | | | | | | | | | | | | | | | | | | | | | | | Along with the name (id) and the version(_id) But only show the information if is available Examples: Fedora CoreOS, Ubuntu Focal [NO TESTS NEEDED] Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
| * api: handle nil pointer dereference in rest endpointsJelle van der Waa2021-09-16
| | | | | | | | | | | | | | | | When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
| * Fix example in podman machine init man pagePaul Holzinger2021-09-16
| | | | | | | | | | | | Fixes #11582 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * Document `all` query parameter for /libpod/images/pruneJelle van der Waa2021-09-16
| | | | | | | | Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
| * tests: enable --cgroups=disabled test for rootlessGiuseppe Scrivano2021-09-16
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-26 22:18:33 +0000