summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* libpod/image: unit tests: defer cleanupValentin Rothberg2021-03-25
| | | | | | Defer cleaning up the test artifacts as early as possible. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* libpod/image: unit tests: use `require.NoError`Valentin Rothberg2021-03-25
| | | | | | | | In contrast to `assert.NoError`, `require.NoError` treats mismatches fatally which in many cases is necessary to prevent subsequent checks from segfaulting. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #9768 from mheon/fix_9608OpenShift Merge Robot2021-03-25
|\ | | | | Ensure manually-created volumes have correct ownership
| * Ensure manually-created volumes have correct ownershipMatthew Heon2021-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of a fix for an earlier bug (#5698) we added the ability for Podman to chown volumes to correctly match the user running in the container, even in adverse circumstances (where we don't know the right UID/GID until very late in the process). However, we only did this for volumes created automatically by a `podman run` or `podman create`. Volumes made by `podman volume create` do not get this chown, so their permissions may not be correct. I've looked, and I don't think there's a good reason not to do this chwon for all volumes the first time the container is started. I would prefer to do this as part of volume copy-up, but I don't think that's really possible (copy-up happens earlier in the process and we don't have a spec). There is a small chance, as things stand, that a copy-up happens for one container and then a chown for a second, unrelated container, but the odds of this are astronomically small (we'd need a very close race between two starting containers). Fixes #9608 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #9811 from ↵OpenShift Merge Robot2021-03-25
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.28.1 Bump github.com/containers/storage from 1.28.0 to 1.28.1
| * | Bump github.com/containers/storage from 1.28.0 to 1.28.1dependabot[bot]2021-03-25
| | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.28.0 to 1.28.1. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.28.0...v1.28.1) Signed-off-by: dependabot[bot] <support@github.com>
* | | Merge pull request #9812 from ↵OpenShift Merge Robot2021-03-25
|\ \ \ | |/ / |/| | | | | | | | containers/dependabot/go_modules/github.com/containers/common-0.35.4 Bump github.com/containers/common from 0.35.3 to 0.35.4
| * | Bump github.com/containers/common from 0.35.3 to 0.35.4dependabot[bot]2021-03-25
|/ / | | | | | | | | | | | | Bumps [github.com/containers/common](https://github.com/containers/common) from 0.35.3 to 0.35.4. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.35.3...v0.35.4) Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #9808 from thephoenixofthevoid/issue-9650-fixedOpenShift Merge Robot2021-03-24
|\ \ | | | | | | [NO TESTS NEEDED] Fix rootless volume plugins
| * | [NO TESTS NEEDED] Fix rootless volume pluginsPhoenix The Fallen2021-03-24
| | | | | | | | | | | | | | | | | | In a case of volume plugins with custom options. Signed-off-by: Phoenix The Fallen <thephoenixofthevoid@gmail.com>
* | | Merge pull request #9747 from rhatdan/ttyOpenShift Merge Robot2021-03-24
|\ \ \ | | | | | | | | Check if stdin is a term in --interactive --tty mode
| * | | Check if stdin is a term in --interactive --tty modeDaniel J Walsh2021-03-24
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you are attempting to run a container in interactive mode, and want a --tty, then there must be a terminal in use. Docker exits right away when a user specifies to use a --interactive and --TTY but the stdin is not a tty. Currently podman will pull the image and then fail much later. Podman will continue to run but will print an warning message. Discussion in : https://github.com/containers/podman/issues/8916 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #9809 from rhatdan/tmpdirOpenShift Merge Robot2021-03-24
|\ \ \ | |/ / |/| | [NO TESTS NEEDED] Remove /tmp/containers-users-* files on reboot
| * | [NO TESTS NEEDED] Remove /tmp/containers-users-* files on rebootDaniel J Walsh2021-03-24
|/ / | | | | | | | | | | Helps Fix https://github.com/containers/podman/issues/9765 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #9790 from matejvasek/fix-isolation-serdeOpenShift Merge Robot2021-03-24
|\ \ | | | | | | fix: build endpoint for compat API
| * | fixupMatej Vasek2021-03-23
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | fix: build endpoint for compat APIMatej Vasek2021-03-23
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #9723 from ↵OpenShift Merge Robot2021-03-24
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.14.0 Bump github.com/rootless-containers/rootlesskit from 0.14.0-beta.0 to 0.14.0
| * | | Bump github.com/rootless-containers/rootlesskitDaniel J Walsh2021-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.14.0-beta.0 to 0.14.0. - [Release notes](https://github.com/rootless-containers/rootlesskit/releases) - [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.14.0-beta.0...v0.14.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #9785 from jmguzik/unification-of-label-filterOpenShift Merge Robot2021-03-24
|\ \ \ \ | |/ / / |/| | | Unification of label and until filters across list/prune endpoints
| * | | Unification of until filter across list/prune endpointsJakub Guzik2021-03-24
| | | | | | | | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
| * | | Unification of label filter across list/prune endpointsJakub Guzik2021-03-24
| |/ / | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | Merge pull request #9749 from jwillikers/generate-kube-persistent-volume-claimOpenShift Merge Robot2021-03-23
|\ \ \ | | | | | | | | Generate Kubernetes PersistentVolumeClaims from named volumes
| * | | Generate Kubernetes PersistentVolumeClaims from named volumesJordan Williams2021-03-19
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #5788 This commit adds support for named volumes in podman-generate-kube. Named volumes are output in the YAML as PersistentVolumeClaims. To avoid naming conflicts, the volume name is suffixed with "-pvc". This commit adds a corresponding suffix for host path mounts. Host path volumes are suffixed with "-host". Signed-off-by: Jordan Williams <jordan@jwillikers.com>
* | | Merge pull request #9537 from TomSweeneyRedHat/dev/tsweeney/tz_checkOpenShift Merge Robot2021-03-23
|\ \ \ | | | | | | | | Validate passed in timezone from tz option
| * | | Validate passed in timezone from tz optionTomSweeneyRedHat2021-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Erik Sjolund reported an issue where a badly formated file could be passed into the `--tz` option and then the date in the container would be badly messed up: ``` erik@laptop:~$ echo Hello > file.txt erik@laptop:~$ podman run --tz=../../../home/erik/file.txt --rm -ti docker.io/library/alpine cat /etc/localtime Hello erik@laptop:~$ podman --version podman version 3.0.0-rc1 erik@laptop:~$ ``` This fix checks to make sure the TZ passed in is a valid value and then proceeds with the rest of the processing. This was first reported as a potential security issue, but it was thought not to be. However, I thought closing the hole sooner rather than later would be good. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #9774 from TomSweeneyRedHat/dev/tsweeney/usrns_manOpenShift Merge Robot2021-03-23
|\ \ \ \ | |_|_|/ |/| | | [CI:DOCS] Add note to mappings for user/group userns in build
| * | | [CI:DOCS] Add note to mappings for user/group userns in buildTomSweeneyRedHat2021-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a note to the `--userns-uid-map` and `--userns-gid-map` options in the `podman build` man page. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1930509 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #9296 from edsantiago/test_buildah_budOpenShift Merge Robot2021-03-23
|\ \ \ \ | | | | | | | | | | run buildah bud tests using podman
| * | | | WIP: run buildah bud tests using podmanEd Santiago2021-03-21
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set of scripts to run buildah's bud.bats test using podman build in podman CI. podman build is not 100% compatible with buildah bud. In particular: * podman defaults to --layers=true; buildah to false * podman defaults to --force-rm=true; buildah to false * podman error exit status is 125; buildah is 2 * differences in error messages, command-line arguments Some of the above can be dealt with programmatically, by tweaking the buildah helpers.bash (BATS helpers). Some need to be tweaked by patching bud.bats itself. This PR includes a patch that will, I fear, need to be periodically maintained over time. There will likely be failures when vendoring in a new buildah, possibly because new tests were added for new features that don't exist in podman, possibly (I hope unlikely) if existing tests are changed in ways that make the patch file fail to apply. I've tried to write good instructions and to write the run script in such a way that it will offer helpful hints on failure. My instructions and code will be imperfect; I hope they will be good enough to merit continued use of this test (possibly with improvements to the instructions as we learn more about real-world failures). Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #9778 from containers/dependabot/go_modules/k8s.io/api-0.20.5OpenShift Merge Robot2021-03-22
|\ \ \ \ | | | | | | | | | | Bump k8s.io/api from 0.20.1 to 0.20.5
| * | | | Bump k8s.io/api from 0.20.1 to 0.20.5dependabot[bot]2021-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.20.1 to 0.20.5. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.20.1...v0.20.5) Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #9773 from jmguzik/containers-prune-filters-http-apiOpenShift Merge Robot2021-03-22
|\ \ \ \ \ | | | | | | | | | | | | Fix containers list/prune http api filter behaviour
| * | | | | Fix containers list/prune http api filter behaviourJakub Guzik2021-03-20
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem described in #9711 and followed by #9758 affects containers as well. When user provides wrong filter input, error message should occur, not fallback to full list/prune command. This change fixes the issue. Additionally, there are error message fixes for docker http api compat. Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | | | Merge pull request #9775 from jmguzik/system-prune-msg-fixOpenShift Merge Robot2021-03-22
|\ \ \ \ \ | |_|_|/ / |/| | | | Fix system prune cmd user message with options
| * | | | Fix system prune cmd user message with optionsJakub Guzik2021-03-21
| |/ / / | | | | | | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | | Merge pull request #9757 from jwhonce/wip/loadOpenShift Merge Robot2021-03-22
|\ \ \ \ | | | | | | | | | | Cleanup /libpod/images/load handler
| * | | | Cleanup /libpod/images/load handlerJhon Honce2021-03-19
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove orphaned code * Add meaningful error from LoadImageFromSingleImageArchive() when heuristic fails to determine payload format * Correct swagger to output correct types and headers Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #9779 from ↵OpenShift Merge Robot2021-03-22
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/coreos/go-systemd/v22-22.3.0 Bump github.com/coreos/go-systemd/v22 from 22.1.0 to 22.3.0
| * | | Bump github.com/coreos/go-systemd/v22 from 22.1.0 to 22.3.0dependabot[bot]2021-03-22
|/ / / | | | | | | | | | | | | | | | | | | Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.1.0 to 22.3.0. - [Release notes](https://github.com/coreos/go-systemd/releases) - [Commits](https://github.com/coreos/go-systemd/compare/v22.1.0...v22.3.0) Signed-off-by: dependabot[bot] <support@github.com>
* | | Merge pull request #9771 from edsantiago/batsOpenShift Merge Robot2021-03-22
|\ \ \ | |_|/ |/| | System tests: reenable a bunch of skipped tests
| * | System tests: reenable a bunch of skipped testsEd Santiago2021-03-20
|/ / | | | | | | | | | | | | | | Checking for 'skip.*[0-9]{4,5}', and checking status on said issues, finds several that have been closed. Let's see if they're really fixed. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #9762 from giuseppe/use-bounding-caps-for---privilegedOpenShift Merge Robot2021-03-19
|\ \ | |/ |/| security: use the bounding caps with --privileged
| * vendor: drop replace for github.com/syndtr/gocapabilityGiuseppe Scrivano2021-03-19
| | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * security: use the bounding caps with --privilegedGiuseppe Scrivano2021-03-19
| | | | | | | | | | | | | | | | | | when --privileged is used, make sure to not request more capabilities than currently available in the current context. [NO TESTS NEEDED] since it fixes existing tests. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * Bump github.com/containers/common from 0.35.0 to 0.35.3dependabot[bot]2021-03-19
| | | | | | | | | | | | | | | | Bumps [github.com/containers/common](https://github.com/containers/common) from 0.35.0 to 0.35.3. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.35.0...v0.35.3) Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #9735 from ↵OpenShift Merge Robot2021-03-19
|\ \ | |/ |/| | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.15.2 Bump github.com/onsi/ginkgo from 1.15.1 to 1.15.2
| * Bump github.com/onsi/ginkgo from 1.15.1 to 1.15.2dependabot-preview[bot]2021-03-18
| | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.15.1 to 1.15.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.15.1...v1.15.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #9758 from jmguzik/volumes-networks-http-fixOpenShift Merge Robot2021-03-19
|\ \ | | | | | | Fix volumes and networks list/prune filters in http api
| * | Fix volumes and networks list/prune filters in http apiJakub Guzik2021-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the continuation work started in #9711. It turns out that list/prune commands for volumes in libpod/compat api have very dangerous error handling when broken filter input is supplied. Problem also affects network list/prune in libpod. This commit unifies filter handling across libpod/compat api and adds sanity apiv2 testcases. Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-10-31 19:24:09 +0000